From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AF4E35E944 for ; Mon, 13 Apr 2026 10:07:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074840; cv=none; b=vC24S3eYTj4nS1IHfCnAQFHGGRrCR20IyXlXEJrxf68I6ZMmNyWPBOXBFYru1dedWBWwPSD4spgvIq/ZMNK8zyvrPr2268G53wOaaDN8wxP0Lcc2A8e7uDxf4ueNh5jxy2uzsos1d+PwUdkUadFq2VRGiKd39NHv2frgABJtv64= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776074840; c=relaxed/simple; bh=UxDiNz5aVAd8jaiS8WbKwd6IwvkgGniodqaG9fbAjlc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Ztzu5b2nyjCsBx8+RtKW9XZ1AYSbW3/6nUiW7QkXDsRvfj4KhWJR9J4kK0rlaTJzikMJa1SgrCECndXcBjTq61EPUkFOeTAAnqQ3F98xJwfQyQcmmt7ji0eMPnFpR+DV3coJopQGcG5fmZvbXo+B09d9F4dnGIqcumUKmQsob2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Puu4Oz87; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Puu4Oz87" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-823c56765fdso2343847b3a.1 for ; Mon, 13 Apr 2026 03:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776074839; x=1776679639; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qz15EdajgaOwwJlVpi9rRF2MEm37YEfE9zUFEPe5XVQ=; b=Puu4Oz87KxIsta5K9aTtHoBxLJqMIHgxrKMkNcJfIFa1QeLxPIkM3xIf6Co+94yJnR B2SA0FVv1tHVujw9PCbOHKa7Si7dJDhX37oTVqy8/hERVJL6CO9YoxYilbtWh9X7PoDN Vi/jTwa7Wwk3Cuk7ZllmWJC3/ttettDJPwotnis5LYNrMlHYSvjWhXHqsYuWal+Xys/N 5SSM7jHqHJc4yDTlIOJj4NUhRKdQ6vqVu702C1mY9WESenHvaN/Lpt2eO0hZ7tXIPLXL IRb0f5f5YG7Xicvnw0de54USHo3fw6BHdpJFneiP56IFc/2NTvpmm7mHFtzWGSESag3u SC8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776074839; x=1776679639; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qz15EdajgaOwwJlVpi9rRF2MEm37YEfE9zUFEPe5XVQ=; b=hPvmLJsFwVKuMZt8GfMhvWdWwRa+RwRqgcmbgP0DdMTdhO7Agqwu0n1fJWS326CK8f tl8enBC0g8oYQU89zkW4qaHZZQM1dyGpBH1BD9eeVuS43HuOqYiov9u6iR50WQ3VNKhr dCQHHyIdQuWzbZG2PVzrUP7pdw2OUsoDUZ8f3CztITeA/cRZXm60MQNJDRF+u0G5FOP/ BTFF1Zto8+H3YEUi7f3k0nkRW+x/lMgXzhclUV9/4HhPzENeCY4moefw5/WI4hjgDZVX /S9n/m0fGzdF+6woiipsXarozZIpLD86V/4+lRw085nHk34MzwstDOGuW3+SkmKRUL+L dS6A== X-Forwarded-Encrypted: i=1; AFNElJ+5sQjyGz/PviKSBbTqTQoENgAvJrPeQkW2rB2xOfQ25LEbdOD370R3YAOI4JUh4NVz73mOqbooX4dST0M=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4jRt9wVU0OsaEeha6Ctd9JyHkReWwXgBpQ0+FSxwbMThBXaQl Apb8xWjH37Brq3eu2Ud70Ajil6UM3l/vFY8K4oZw4Ot1aikhrOMejPLpgTrqng== X-Gm-Gg: AeBDietqZhvh44uE7B44EQB5MOv/0tPiRP524XfXUhvrxttQ86ZXimGxoutg5aTiQ2g 77HDF3udvKoQK+nL75jHFMFpUm1f41zYo42Kf2cuQjX7odYpcWcHpGaZrjvw/IjNYb0MRb8LGl4 yszb6UK+Qe8PFjQBZR1VynRLv5pHBKzOa0d53hjoK7/7PM0ZBa5B7jQ4LP0J9y34XtTiNQBecli tKvWP/I9f1QcEfEPlMpAfGDl2Dabawm55RvF1SLf0REAj3zqP7L7rbaAJFtoLh/ML1bqX9ehPQc /IEVLDeJJjUf0rDV1NOQyLSytBS+iJ1aOqM2lgRxTZIZD1haTrRcipieRCtdEKrzKeHitFM3MpB kGosQa9rxGkGlQNvB1u8J1/Z3/Z1AZ15cjXwg8jvaLLIouRhXXzSHNJo5qh7psPjYD/MeZlCwxz RMS0L+BD8ecwFBtvu6ie8ig8WEtcTbCvPRsPeJO3EZDah6GmOhaFhRz9YBIA== X-Received: by 2002:a05:6a00:aa85:b0:829:8942:2c93 with SMTP id d2e1a72fcca58-82f0c1cc16emr11475540b3a.9.1776074838631; Mon, 13 Apr 2026 03:07:18 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c50a8f7sm10232140b3a.56.2026.04.13.03.07.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 03:07:18 -0700 (PDT) From: phucduc.bui@gmail.com To: kuninori.morimoto.gx@renesas.com, broonie@kernel.org Cc: lgirdwood@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, geert+renesas@glider.be, magnus.damm@gmail.com, perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 0/6] ASoC: renesas: fsi: Fix system hang by adding SPU clock Date: Mon, 13 Apr 2026 17:06:54 +0700 Message-ID: <20260413100700.30995-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Hi all, The FSI on r8a7740 requires the SPU clock to be enabled before accessing its internal registers. Without this clock, register access can lead to a system hang, even when the FSI functional clock is properly enabled. This series adds the missing clocks and aligns their names with those used in the driver. Following feedback from Morimoto-san, the driver is refactored to improve stability. Clock initialization is moved from the runtime path to the probe function to simplify the flow and avoid redundant setups. Additionally, the shutdown sequence is reordered to ensure the stream is properly stopped before the hardware is shut down. Changes in v2: - DT Bindings: Define "own" clock and add "spu", "icka/b", "diva/b", "xcka/b" to the clock tree. Use YAML anchors and "if" rules to enforce clock-names and r8a7740 requirements. Relocate allOf block and update example with full 8-clock configuration. - DTS: Rename "fsi" clock to "own" to match driver implementation. Add missing clock names: "icka", "ickb", "xcka", "xckb". - In the driver: Refactor clock initialization. Reorder shutdown: stop stream before hardware shutdown. Move SPU clock enable/disable handling to fsi_hw_startup/shutdown. v1 links : https://lore.kernel.org/all/20260403112655.167593-1-phucduc.bui@gmail.com/ Testing: - Verified on r8a7740 (Armadillo-800EVA): FSI slave / Codec master mode. - FSI master mode is currently compile-tested only. Full verification requires a dedicated HDMI driver (FSIB) or hardware modifications (resoldering board resistors) (FSIA).Full support for fsidiv requires additional DT bindings and a corresponding driver. bui duc phuc (6): ASoC: renesas: fsi: Add shared SPU clock support ASoC: renesas: fsi: Fix hang by enabling SPU clock ASoC: renesas: fsi: Fix trigger stop ordering ASoC: renesas: fsi: refactor clock initialization arm: dts: renesas: r8a7740: Add clocks for FSI ASoC: dt-bindings: renesas,fsi: add support for multiple clocks .../bindings/sound/renesas,fsi.yaml | 61 +++++- arch/arm/boot/dts/renesas/r8a7740.dtsi | 12 +- sound/soc/renesas/fsi.c | 181 ++++++++++-------- 3 files changed, 171 insertions(+), 83 deletions(-) -- 2.43.0