From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96AC63A5452 for ; Mon, 13 Apr 2026 12:39:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776083966; cv=none; b=CySIQnCFO0dOYQn7vY+C7eZwnmPUW73ccbfuBc2DhkYiDvX1agFPKVDoI8d4KRoZM7gzxfN792E5W9tHTPCCXrsquOg8lDCgBpfC+Pwsmv9+jkyUSgJKs/BavT2xx3M2U7M1zFba0fjSDMMY91SqJgQ2lBQ9yRcRNQFZBqIF5Qw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776083966; c=relaxed/simple; bh=Eltpam/vgsJqWDDmBNuLJKAQCg+4CI1hVv/dIvLONqI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rYvlUf5myuCb7hl6NSFUpwGGKEip+MnPoJOuhZIxNMmUEBPR/KjH6jfrXYUiDNmzsjqtjCrp7HxG4KsST42rKOFteoSf00YJEQUhUk1C69aRNW8K46H4xWdXgdwolEBo+JXqKDYndeSd8MSHCxFPMVwCwCvOlePso63fatKmJeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dE2huxmg; arc=none smtp.client-ip=209.85.167.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dE2huxmg" Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-5a3fcb2c718so659740e87.0 for ; Mon, 13 Apr 2026 05:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776083963; x=1776688763; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rqFxz1QFpJJAZz46pmSBmZ9ZWT6FZnXdjLeoytZTkRQ=; b=dE2huxmgsrvgeQjSjbFocoh53G8iOpb9tXjIh2gY7JQ0RG0Frm83BxuPJp5yN29h0Z oyqRsBOeFrBhgncksJeeBQmksTuHmJLrMc7xKck6iSQajEldHsrgXGjnAra0ajck62sg V1KnbdVsUgq7iv1A50dRhJEVabUmZbJ6ZyUHzmJNXBGFjXInr8gY4XbYFttuDmONGd7S Mq+B3eB+UMlHGC5A7T3W5XPzXA4YFoTMbtVauSvqBAgT3i1czHTj3Ipo0TrqPhbw2ldM ePFKEoqNA/MGfdJOsXehiAZbclL0sFsS23R2Sn8GnUgCpNoCTFPNiB2JJyV1/1VRo9wG DJSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776083963; x=1776688763; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rqFxz1QFpJJAZz46pmSBmZ9ZWT6FZnXdjLeoytZTkRQ=; b=AsiZbfQ3zBs+UQ8t/SCxvVIFZE4Dqe3nFZB6K1Yx6d8FO3qAF1+8ZeMopZKAyL9LIy v+L6xX0nxx4W4QPeMYR5XLbQcXnHizZuV4AlsOz1553YhhZi63vonyvXbF57u6BcTIFy c+Ou+IieNHxmS/Qn5Zn4pGfvC+zatb8mLOOx5CMyKXN/twhqmZnFwaVrPaFCBzyGmRWc 72Hn1IjBDTD0erH5BvmrsiCYWZtgFOZJmv8ElP+nz/s12m13+KE+C/5Kc1YQulSjk5ob mvIbPAe2q1Lpnms/pk+b2MFIccwHIdoPHOWE/vG057od6OfzldOf6tLE0nG2CLebCq+s gZ1w== X-Forwarded-Encrypted: i=1; AFNElJ8wdtcp9fAnfEi+8I09b7zEK29uAoLwyJsO4e8wm+1/NuVpQmQHdI14G5wfBLycU9A/awcpPjGyTMfOeDs=@vger.kernel.org X-Gm-Message-State: AOJu0YyTHRMoR5HA7/zvY4taAggCgVF/qKiDZqa0WKFGuH+pURdPt5x3 qwbH9qpzwYURkATC3c5ZUJPe4/pd9qgHQeGjmas92wF3LcPLyBF+QC9/ X-Gm-Gg: AeBDietbWdhFFMLeO8HpzexunQQMYsv43xtXVuTnFM0X+86QgeQRnn6WFHx8ohbMD98 wAibWSy3tH5ch42J8ubycA6IllhJX2BqmDGiQyVlQCYjJJ3770+yFc40oG0TElzYUJJZE9QWN4/ ZWglkVRpTLIpA1x4RVPbN/misvXugmO/ZwzdjNrMoaVksOr4VomC+NIu6e9XnqpLYvvh5aMjMst XJPLoETcME5AvG9mfGxSJw1LJm2+UWcvrIj+Al2tpOKUSoNtsYaefmtTtLKOEhAV4ptu5FppII+ l90BYDP5QnqqmoGOZBZZLUwzEIAUNP/RvMHk3E46NlvO1/FU+kComzKktttp0K6ntpjbAiFrObn Taw4ncW0p1CGFKyKCj5stXvmYa2tB6DHQfrb+4CnsI2qYChqBhuJCCywHB6MHhlFpPcP4sviS4H TOIW930qbRzD/1lgsD2tBPxeLqD9sflzRcnVw4ZFlbgbA9zQ== X-Received: by 2002:a05:6512:3503:b0:5a1:1496:922 with SMTP id 2adb3069b0e04-5a3efd8b5c4mr4514818e87.33.1776083962516; Mon, 13 Apr 2026 05:39:22 -0700 (PDT) Received: from wpc (host-95-152-45-178.dsl.sura.ru. [95.152.45.178]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef00327sm2532549e87.73.2026.04.13.05.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 05:39:22 -0700 (PDT) From: bigunclemax@gmail.com To: richard.genoud@bootlin.com Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, jernej.skrabec@gmail.com, joao@schimsalabim.eu, jstultz@google.com, krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org, linux-sunxi@lists.linux.dev, p.zabel@pengutronix.de, paulk@sys-base.io, robh@kernel.org, samuel@sholland.org, thomas.petazzoni@bootlin.com, u.kleine-koenig@baylibre.com, wens@csie.org Subject: [PATCH v4 2/4] pwm: sun50i: Add H616 PWM support Date: Mon, 13 Apr 2026 15:39:20 +0300 Message-ID: <20260413123920.2459916-1-bigunclemax@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260305091959.2530374-3-richard.genoud@bootlin.com> References: <20260305091959.2530374-3-richard.genoud@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Richard, > + > +/* PWM Capture Fall Lock Register */ > +#define H616_PWM_CFLR(x) (0x74 + (x) * 0x20) > + > +#define H616_PWM_PAIR_IDX(chan) ((chan) >> 2) > + It looks like there's a typo or a mistake in the PAIR_IDX calculation. It should be like ((chan) >> 1). For example, for the 5th channel the result will be 1, but it should be 2. Best regards Maksim