From: Jonathan Cameron <jonathan.cameron@huawei.com>
To: John Groves <john@jagalactic.com>
Cc: Dan Williams <djbw@kernel.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"nvdimm@lists.linux.dev" <nvdimm@lists.linux.dev>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
John Groves <John@Groves.net>
Subject: Re: [PATCH] dax/fsdev: fix uninitialized kaddr in fsdev_dax_zero_page_range()
Date: Mon, 13 Apr 2026 16:19:54 +0100 [thread overview]
Message-ID: <20260413161954.00006daf@huawei.com> (raw)
In-Reply-To: <0100019d8262cda2-9714d31c-8fc1-4ca5-b32d-4df678240d14-000000@email.amazonses.com>
On Sun, 12 Apr 2026 15:50:06 +0000
John Groves <john@jagalactic.com> wrote:
> From: John Groves <John@Groves.net>
>
> __fsdev_dax_direct_access() returns -EFAULT without setting *kaddr when
> dax_pgoff_to_phys() returns -1 (pgoff out of range). The return value
> was ignored, leaving kaddr uninitialized before being passed to
> fsdev_write_dax().
>
> Check the return value and propagate the error.
>
> Thanks to Dan Carpenter and the smatch project for reporting this.
>
> Signed-off-by: John Groves <john@groves.net>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
next prev parent reply other threads:[~2026-04-13 15:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260412154944.461748-1-john@jagalactic.com>
2026-04-12 15:50 ` [PATCH] dax/fsdev: fix uninitialized kaddr in fsdev_dax_zero_page_range() John Groves
2026-04-13 15:19 ` Jonathan Cameron [this message]
2026-04-13 16:12 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260413161954.00006daf@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=John@Groves.net \
--cc=dan.carpenter@linaro.org \
--cc=dave.jiang@intel.com \
--cc=djbw@kernel.org \
--cc=ira.weiny@intel.com \
--cc=john@jagalactic.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox