From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA92130C615 for ; Mon, 13 Apr 2026 16:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097778; cv=none; b=NhwJEm4pyBKd9lNw4CDn/pB7+VPWVVpKW/mYtFuRPYsSlauuCIS70OGFAwJiiyciuGv/mC55FZqXh+YoAUVft4s6VKkuAfRSghqaITi66Xc4hTGKEEaFiZarM3XHXnWdcUptUUe7O2B/4p7Du9z9JH4AymISm2LkS2r/bl50bpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776097778; c=relaxed/simple; bh=Q08Vuo779EJDc4qagq/btzGeGBQHw6ODXfol6WzxNIs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=dUpP+OKSNqwC/H1+GEivxlixcTQyDAo9e28hlJHw5Qk5Nkt1kUBkWM7GfnCKnAv1gohQhSGFwS88ehnVwtM1aIuliErPzzsn2v1GELgL9MfxzKjLfH5jKh4NH9oFIkaf1G5cNAOlfsSiWiYNysF+877wIcBKGEGQVfD5HgA7RKo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=In2VX5jh; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="In2VX5jh" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-c741c1a656aso203572a12.3 for ; Mon, 13 Apr 2026 09:29:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776097777; x=1776702577; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GxOI/4URINQL23ceJIk4nIIA53W3WmBZxkLhHAUmWr4=; b=In2VX5jh9kKnXcWJlg7Gf0GefMgOnDoSRTYlcAeosTSBn0abRzBJaAHhAYfwZxqrt8 u05XiPyTF2i7E1wrXdS8pbJpC16JNpDpH05tkvgtYst5jmKsKh3U0Y9saov+FxH++Ft7 WFeNvqssYL/wEyfPcFQ2Ovwt05Ev9IOXElkq0ntrCY8ugHFxHE1IE79nh7AFN0TSXjVV +v4EzkbiL5DCd1ZiGn/c5p5dVSBvK7GJi/lvX5rD81MH5QN9dbcsPpOt34HS2KpqZFV9 fKGdp2P3zkg4XRKaPToalyf9MeU0fwDQDkD3iVAFj9LUqLbURPFFCeyUg1VgmxKYkk2S Esgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776097777; x=1776702577; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GxOI/4URINQL23ceJIk4nIIA53W3WmBZxkLhHAUmWr4=; b=cFPXfzzqeDz5Wt9UwRujq9cwrVKwjZ2GKFEXUBwRfHq8i6iZak8HUemp+EN8X4Eki3 TU0RsI1EARTxVbSpZ1J6S29Dzp4XGJ21ZyOOyjilQ6svF1mDBBWVD8S4HnihoUWnJBwu sR9Rx5ymdSrPZ188YQLm8KnmsnCTsr+VJq5kByDEQQJS4uCF0HievfuJYWHv6Lk0sG83 kd/QaYdzr202X8QUpFS6qxEhaNxGzylPudtQ1dd//w66ukxm2X1slTKQGbA0Mgat4gff 7tgTg/nZpawUzFUyN3Q59LWihh0NZcMKGFl1pYmMhpigZ9AvvctR11kPS0myFpyMJqqN Cyzw== X-Forwarded-Encrypted: i=1; AFNElJ8vLrAjkCnpH1QV+OZPEmf7SqFZz6/q6I8K0W+fAz8rvsfvJrV7s9++wj1LRHc0V+Vy+1ywiE9Rtq8E2D0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw8rOg3SwSBlIF/tT089nrMguuva8IZO2ur8TAbWKY9Zq/HSWnq wCBcU33CubrtOdByljIDYH8gLm5eeX9QNazi5YG4ir0k/QhzI35OidcJ X-Gm-Gg: AeBDies0x31Lj8C8NYr7rp3G0dP3ZNPjZGHRzxFy3z2BDtZkIPtO+IOnvzkKcLCNWbA EPA2nv2WZuSsUajR43x4G18xEXFGKZyIA2wfdAwoVrr8HWCHRX2cEPkmJRZZz3hzQFCudvFyI75 Wil01TzAwHxVwKeIpttlzwuLmtUnLOS4BOgYAwq7ImDlosEKF8xi+00YnoxXZy5Cn4uDzp4LVzW 0AZwKI/0XKfoFfm2TessL8ySAe5fSdvQ0718yIX3UZ7Xq1IAyP9EG4G9l5FdSCR9BNI03755bMn HV9VGPoSzyJcl6EbeTg1XzyOPK/k7rpTSHAwGLwfsSIvMhnErq+QYylca9m29lVaojbMlk7Atl4 XPYUnkQXDs8buGQVJONSVxO849jfp6GTVr/VfUlfotl/3C+4EOnOBC92FSPZaz6vV0lg7vi1bNK cIvfiAbbgkdRgNzezstJaJs3GdaTA= X-Received: by 2002:a05:6a20:93a1:b0:343:c095:c4d6 with SMTP id adf61e73a8af0-39fe3f7747amr8600509637.3.1776097776855; Mon, 13 Apr 2026 09:29:36 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c338dafsm12905368b3a.17.2026.04.13.09.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 09:29:36 -0700 (PDT) From: DaeMyung Kang To: pasha.tatashin@soleen.com, rppt@kernel.org, akpm@linux-foundation.org Cc: pratyush@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, DaeMyung Kang Subject: [PATCH] mm: memfd_luo: fix PFN conversion in retrieve cleanup Date: Tue, 14 Apr 2026 01:29:29 +0900 Message-ID: <20260413162929.156163-1-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit memfd_luo_retrieve_folios()'s error-path cleanup loop passes the raw PFN to kho_restore_folio(), but the function expects a physical address. The two other call sites in the same file (the discard path and the main retrieve loop) correctly convert with PFN_PHYS() before calling. Without the conversion the cleanup operates on the wrong address and fails to release the folios that were preserved but not yet inserted into the address space, leaking them across the live update. Apply PFN_PHYS() to match the other call sites. Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd") Signed-off-by: DaeMyung Kang --- mm/memfd_luo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c index b8edb9f981d7..6d8aa429f553 100644 --- a/mm/memfd_luo.c +++ b/mm/memfd_luo.c @@ -467,7 +467,7 @@ static int memfd_luo_retrieve_folios(struct file *file, for (long j = i + 1; j < nr_folios; j++) { const struct memfd_luo_folio_ser *pfolio = &folios_ser[j]; - folio = kho_restore_folio(pfolio->pfn); + folio = kho_restore_folio(PFN_PHYS(pfolio->pfn)); if (folio) folio_put(folio); } -- 2.43.0