From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f46.google.com (mail-dl1-f46.google.com [74.125.82.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F5B51A275 for ; Mon, 13 Apr 2026 16:33:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098007; cv=none; b=RHYiQVWj+tHSUU7VQu9n2X72Y1GuG0I1kPPr9qEt5b983F8vNkwIiNsuL2BZ5gpBEKYwuHnIpcAiJUTu0VEe8wJKhBTjwFqbxexQqRSpEmccbUuFhrvhpL3v2lIXi0KALZP/94gJiR/zrbLP7fTrEF1KVqc7KmeZaYXt9RLWdn8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776098007; c=relaxed/simple; bh=Dlvh+0raNYC5uvkFFDSXqvk4NGVEm1w2U4OgUaTcjc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LAo4EtQuNBVMplDpqZ6qEIzDkqt9E/E5+kBB7Al3Q4fG78Xy2NeEerGMCn80vHApFG/9DmssuuiGH+3ZOp7dx33+Fz0pzjEUuIFruOpdWEqAD7t4YATzMPQzUz9sB8sR8Cqzw1BAflc1e6b3K5I1+nxJUeKUFQ+yLAXPe4DvTAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Zw4M3Xhm; arc=none smtp.client-ip=74.125.82.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Zw4M3Xhm" Received: by mail-dl1-f46.google.com with SMTP id a92af1059eb24-12732165d1eso14535153c88.1 for ; Mon, 13 Apr 2026 09:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1776098006; x=1776702806; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eJ3rUJh5CWsw1EiuhWHmgUssDs4YQJ5kj165j8Ld5Kw=; b=Zw4M3Xhmtu5s01poJooFtsR6G7pqL3H2oJXj3XIsyhKgCqSCtipvTf9RCtAx06Jirr 9BRuih2I0iRU6MUyyU+LvYTt0EEw+pS0P8N4xPSjrKaQ8czBK5SpveEjN2Ba6JrUvBWD vFA48c8t+Wn0qS3EkJTmeUbuAhsfSF4xX0qc5dwKOeccisbdwQhCGVIYkDa/PbTTdrMI o7GYJ95GQDCfWlBQpv3jfXnIMJ7Qq+Wxn4RZG/EckrmDhLkXfnLfW/fIGmgqvu3ka/1m CYXax8xnwN/WYqDG+kijJE2UN9A2bz8Qnwlt8vll0p3XCH9NCu6xZ7NRuBqlaR+FG256 NIJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776098006; x=1776702806; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eJ3rUJh5CWsw1EiuhWHmgUssDs4YQJ5kj165j8Ld5Kw=; b=nxFUnZZeSs0/rxoYu5Vew4LFm+YRxJdPrmdejkzqMwFUDTDy3ZkuHpVWEg+8fQLxYR Kze0Yp1j3+xukbRDJAmy/lb9nTS1xaFHhzXzCb+ThwZaLxd1K8h6n7/R7OhurwZIi0xY IFlABXAc0b+2zInCGtMm1W2HH+qlbcDrEacO4E3YAAbFPupH1E5X6wv876Uns1hzHIZq OQE+Sp5DC+UEHct4m7kPoBOjoG6XxgRSKUriLoSfrD7984d9KDQ/vvWGU0ufB25qG1BF ifeZWth3qdTERmZrnrNXw2cDtpw5whG0hqLezt86VVGF0Zn4wioB7Y0xoxaAS6909MDb qBbw== X-Forwarded-Encrypted: i=1; AFNElJ/87ELqxI4fA/G/qlUhQEgP4i9h8AreefdhspJ5q0RBNAi+Z23YfUZloGmSdpC7F/orcxMvt49z+6EPnBU=@vger.kernel.org X-Gm-Message-State: AOJu0YzhCmDHF6cG5pI3cCWssDLOJZqHcSAFCHuZTrk4MUrGuiz2VW5h 7pTlzGmzJuLeyYGwObfyyDST+wrasEGwJEQOjnerp9xh6+ZwpmSCzXc+MWh0j+ihCo4= X-Gm-Gg: AeBDiesUUM3q0+o2rvafV75ghwEnfvsll8ucVCze29YZGvxdDpuonevz1osnBz30txn kQZawNea9h2oOSBRuFgQUnoNElXqG5ZmFKcM6x6mLuNamvvkBtJ9/hUpMKrkJQ5KohvSHIiBJt3 kEuseZu1jNZ9nws5GsLWxqzcdyXZuDSV9DFwlrdyI6C7S7x/Ioa1EY5Jdl4pmufCuzTpZGIHCZF y4SgIxoo5ocLLFf+lf+r7lOmrIYX5lHg9hLPOmORDxN1/o9g2SrlFmCfsbMLx29qJVjcN6tPSHb AjJHCYe2kIYuZ3mKNeBT0xB67w900XJDcOmzlFJ1iZoJMdIF2FNwtUgcdW+L7YmIjpCwswh24Fj 2qqL4muqFVd5KDJ5t4v9TrawLA7NhH7WxmltJ6FMkDvFfBNuaPKYqB65oQcJ7HpSD9IGi1agUOn rkhlgHkgiU/ic+VXLAideBRN0DVML+6mqWc5Xp2S/LDqwqjNTULrOpPLA= X-Received: by 2002:a05:7022:ead3:b0:128:d1cf:8ab with SMTP id a92af1059eb24-12c34e37aeemr7404491c88.6.1776098005293; Mon, 13 Apr 2026 09:33:25 -0700 (PDT) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with UTF8SMTPSA id a92af1059eb24-12c346eb228sm15911165c88.9.2026.04.13.09.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 09:33:24 -0700 (PDT) Date: Mon, 13 Apr 2026 09:33:23 -0700 From: Mohamed Khalfella To: Randy Jennings Cc: Hannes Reinecke , Justin Tee , Naresh Gottumukkala , Paul Ely , Chaitanya Kulkarni , Jens Axboe , Keith Busch , Sagi Grimberg , James Smart , Aaron Dailey , Dhaval Giani , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 08/15] nvme: Implement cross-controller reset recovery Message-ID: <20260413163323.GI2861-mkhalfella@purestorage.com> References: <20260328004518.1729186-1-mkhalfella@purestorage.com> <20260328004518.1729186-9-mkhalfella@purestorage.com> <20260331164733.GC2861-mkhalfella@purestorage.com> <5d3fecf4-9101-4028-858d-bfbbccf3d8d3@suse.de> <20260407204653.GG2861-mkhalfella@purestorage.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon 2026-04-13 08:25:51 -0700, Randy Jennings wrote: > > /* > > * Source controller accepted CCR command but CCR operation > > * timed out or failed. Retrying another path is not likely > > * to succeed, return an error. > > */ > Please do not add "Retrying another path is not likely to succeed" > because it is not true. We would need to check the retry flag to se > the verasity of that statement, and I would expect that check to be > added later. Fair point. I will drop that part from the comment. > > Sincerely, > Randy Jennings