From: kernel test robot <lkp@intel.com>
To: Tiwei Bie <tiwei.btw@antgroup.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>
Subject: drivers/net/wireless/broadcom/b43legacy/dma.c:178 priority_to_txring() warn: inconsistent indenting
Date: Tue, 14 Apr 2026 07:02:32 +0800 [thread overview]
Message-ID: <202604140729.2mAAGWwP-lkp@intel.com> (raw)
Hi Tiwei,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 0f00132132937ca01a99feaf8985109a9087c9ff
commit: a0e2cb6a90634f3dc80f16e882a683ee5761b0b0 um: Add VFIO-based virtual PCI driver
date: 11 months ago
config: um-randconfig-r071-20260414 (https://download.01.org/0day-ci/archive/20260414/202604140729.2mAAGWwP-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
smatch: v0.5.0-9007-gcf3ea02b
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: a0e2cb6a9063 ("um: Add VFIO-based virtual PCI driver")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604140729.2mAAGWwP-lkp@intel.com/
New smatch warnings:
drivers/net/wireless/broadcom/b43legacy/dma.c:178 priority_to_txring() warn: inconsistent indenting
drivers/net/wireless/broadcom/b43legacy/dma.c:678 b43legacy_setup_dmaring() warn: check likely/unlikely parentheses
Old smatch warnings:
drivers/net/wireless/broadcom/b43legacy/dma.c:183 priority_to_txring() warn: check likely/unlikely parentheses
drivers/net/wireless/broadcom/b43legacy/dma.c:917 parse_cookie() warn: check likely/unlikely parentheses
vim +178 drivers/net/wireless/broadcom/b43legacy/dma.c
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 169
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 170 /* Mac80211-queue to b43legacy-ring mapping */
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 171 static struct b43legacy_dmaring *priority_to_txring(
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 172 struct b43legacy_wldev *dev,
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 173 int queue_priority)
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 174 {
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 175 struct b43legacy_dmaring *ring;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 176
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 177 /*FIXME: For now we always run on TX-ring-1 */
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 @178 return dev->dma.tx_ring1;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 179
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 180 /* 0 = highest priority */
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 181 switch (queue_priority) {
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 182 default:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 183 B43legacy_WARN_ON(1);
ce3b6845fc4d96 drivers/net/wireless/broadcom/b43legacy/dma.c Gustavo A. R. Silva 2020-08-21 184 fallthrough;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 185 case 0:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 186 ring = dev->dma.tx_ring3;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 187 break;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 188 case 1:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 189 ring = dev->dma.tx_ring2;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 190 break;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 191 case 2:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 192 ring = dev->dma.tx_ring1;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 193 break;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 194 case 3:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 195 ring = dev->dma.tx_ring0;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 196 break;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 197 case 4:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 198 ring = dev->dma.tx_ring4;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 199 break;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 200 case 5:
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 201 ring = dev->dma.tx_ring5;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 202 break;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 203 }
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 204
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 205 return ring;
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 206 }
75388acd0cd827 drivers/net/wireless/b43legacy/dma.c Larry Finger 2007-09-25 207
:::::: The code at line 178 was first introduced by commit
:::::: 75388acd0cd827dc1498043daa7d1c760902cd67 [B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices
:::::: TO: Larry Finger <Larry.Finger@lwfinger.net>
:::::: CC: David S. Miller <davem@sunset.davemloft.net>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2026-04-13 23:02 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604140729.2mAAGWwP-lkp@intel.com \
--to=lkp@intel.com \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tiwei.btw@antgroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox