Re: [PATCH 5/9] staging: rtl8723bs: add space before inline block comments

Andy Shevchenko
2026-04-14T12:12:50Z

On Tue, Apr 14, 2026 at 12:58:29PM +0300, Marc Finkelbaum wrote:
> Add a space between the semicolon and the opening '/*' on all
> Queue2Pipe assignment lines in _OneOutPipeMapping, _TwoOutPipeMapping,
> and _ThreeOutPipeMapping.
>
> No functional change.

...

> + pdvobjpriv->Queue2Pipe[0] = pdvobjpriv->RtOutPipe[0]; /* VO */
> + pdvobjpriv->Queue2Pipe[1] = pdvobjpriv->RtOutPipe[0]; /* VI */
> + pdvobjpriv->Queue2Pipe[2] = pdvobjpriv->RtOutPipe[0]; /* BE */
> + pdvobjpriv->Queue2Pipe[3] = pdvobjpriv->RtOutPipe[0]; /* BK */
>
> + pdvobjpriv->Queue2Pipe[4] = pdvobjpriv->RtOutPipe[0]; /* BCN */
> + pdvobjpriv->Queue2Pipe[5] = pdvobjpriv->RtOutPipe[0]; /* MGT */
> + pdvobjpriv->Queue2Pipe[6] = pdvobjpriv->RtOutPipe[0]; /* HIGH */
> + pdvobjpriv->Queue2Pipe[7] = pdvobjpriv->RtOutPipe[0]; /* TXCMD */

I would rather have something like

enum {
RTL8723BS_PIPE_VO,
RTL8723BS_PIPE_VI,
...
};

and replace indices on the left by the enum values and drop comments.

--
With Best Regards,
Andy Shevchenko