From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 318443CCFC3 for ; Tue, 14 Apr 2026 09:59:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160742; cv=none; b=DZVEW72STr0fvIqIDQVadQ2i0IKg4IR0oaixLhm7zrmkGdyySF8yb+cU+Q2yzOdLU+ZB2pyiJSENmUTmBY1ixBdp05p/lDEkw7ib6tbtD4aHH0wlqxx0H/rS1TdgHvQQWDazO+nxJER3ZHQ4qI70FanvMIuyBJBnEMkQmN5Drxs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160742; c=relaxed/simple; bh=cigqYaiI95hZ6Uh9P/wD2DmyqcOpiQzU/+0vTicsJgc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fVWet7kVmCunMQiQoz+MwrMkqql0yUohz/k5XFzz9eLdnu4KC9h673uli5Lt4lBYMOvLPx8t9HB3Uh0qYcHoXFM+O5p0Lj3n3Ulhm785kCdcuEqkBPO9cy0fJsD1izX2B9h7LI0gF7JKWii2QA0ymP2x/fLxhMyix23EeOzqk9o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YBXATnXB; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YBXATnXB" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5a3d42263e4so4822005e87.2 for ; Tue, 14 Apr 2026 02:59:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160739; x=1776765539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/pp4dkNOqmXWeG8D0HndGuYiqy4ojGPxRtQgL9sf7G0=; b=YBXATnXBXsvJ10JtHh18cIi9lxPpgCMg9RkL15O0tRw/bJAM6sqLDEYeIgmAgEIfoD agGQ4sYh41++u7nFV6D8K2paBm8BiaySBp4HCOp1iXNEIdU67Hes3H4NRd0AwFFSeeEd wWzDrUrz/YJ6prA/t5KAbXojNZwkpuV7oZlLSr80OZijc+Ccg0xnJSR6BV82ElyjAbvh iglG2Q/vbZ0+ggwrg+XQRs0jXV6wqD3mya/IBoiiNZL52vFCbKQLR4z948j4ZWGULjEN g7+vVYi1q67TtXSZbSpnDf8zr87EgjiBfRVTcF/O9pwX7levSlpu7YmVcTyltDkNKiXM DFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160739; x=1776765539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/pp4dkNOqmXWeG8D0HndGuYiqy4ojGPxRtQgL9sf7G0=; b=q0YUpa6uRhuE6Ik/YgcPVJYqq+uSq9UHv6LN8KUO+E3RgofMvTgWFz9r5O742pjisD bkVtMenxeYNk239SUzp9K3afizmJfbzx8Nvso6mTWMp+m5/KN8fztPC1zUyn6vJTjrCy E8LCY1cOAIiw4NLx1VOITJwwheeRnIIcDjT1F3aT4oGNpAOkNu4ilbj8FBebNEmoAklD yPLPj0IJUaT6HrsdSuluBKPe4heiy67QGaLW0HkaCVDF4jspMqKBRiz2frld1e5fGYra r7QC5FWbbwBn0zScZoPVUjGRgfclln2HHgXHJAsYcApdMofHaiBH3wPwj2QTsY8FMOpE E1Cg== X-Forwarded-Encrypted: i=1; AFNElJ+wkbgFmiToHCpTAD2A2uYXhhH7ol31tWHuXPWgmTR3Wn4At/gGV8+6ggsHlj1tEQciYOkclsOcBTQMY8k=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0Sa4Vx2Sr2PzNsBHHPhU9bMTjwB9fFMbW5/oUhuL54qiYlKLm /9kdCbDEyZpX415/kMbWEfryk6vAkyF7wHVHGUuECoGy1BK/zjKXGyJQ X-Gm-Gg: AeBDietdk9JZyjV6AQsMACUnBEPdHchk+6C9qD/c+kbMk+Jl06y6AR6n0KzfjAA7PX4 1eCXYpjU2QbwFGAtQghFtB2ovzCih1LDdTk7PdQ8i07aflvSlsxHkSLfbpnbKLKaw465czsjDs8 2gNQYNmfkWcmTVGYbbYX3Z68uHhzoQVjxYXFfsvD/7d158/uy5bOlILczEn67tgvEkyiz/r7LP0 6LeLD5QBPgCFpTZn563Hw69525Daa0rsUqyP1FzHjLTdVsru4JJMnAXot7e8hjepqProCe0yzL0 LwGTzAYcpW2tXpqgRxaC3tgRj7R3VUP4jVuthhQjKCQpdcLLFNtC8iw1nN+WRMTuR89Gt6urG3S UGf78+vOClS1JXS9PoDREkFY5ivM6aFFy2iP0yh5U0PdUxd6/Oz1jg2ZGhDJAX9MFzvf3mRs3Gi l5XZZbeN2LWBqpUg== X-Received: by 2002:a05:6512:3183:b0:5a4:5b5:c84c with SMTP id 2adb3069b0e04-5a405b5c98cmr552568e87.17.1776160739227; Tue, 14 Apr 2026 02:58:59 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.58.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:58:58 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 6/9] staging: rtl8723bs: fix Yoda conditions and == false comparisons Date: Tue, 14 Apr 2026 12:58:30 +0300 Message-ID: <20260414095833.76480-7-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace reversed comparisons with natural-order equivalents: - '0xFF == hw_channel_plan' -> 'hw_channel_plan == 0xFF' - 'false == pHalData->bDisableSWChannelPlan' -> '!pHalData->...' - 'is_supported_24g(...) == false' -> '!is_supported_24g(...)' The multi-line if condition around bDisableSWChannelPlan is also reformatted to standard kernel one-line style. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c index fcfcdfd079da..dc5e6a58fd9d 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -105,7 +105,7 @@ u8 hal_com_config_channel_plan( pHalData->bDisableSWChannelPlan = false; chnlPlan = def_channel_plan; - if (0xFF == hw_channel_plan) + if (hw_channel_plan == 0xFF) AutoLoadFail = true; if (!AutoLoadFail) { @@ -120,10 +120,8 @@ u8 hal_com_config_channel_plan( } } - if ( - (false == pHalData->bDisableSWChannelPlan) && - rtw_is_channel_plan_valid(sw_channel_plan) - ) + if ((!pHalData->bDisableSWChannelPlan) && + rtw_is_channel_plan_valid(sw_channel_plan)) chnlPlan = sw_channel_plan; return chnlPlan; @@ -134,7 +132,7 @@ bool HAL_IsLegalChannel(struct adapter *adapter, u32 Channel) bool bLegalChannel = true; if ((Channel <= 14) && (Channel >= 1)) { - if (is_supported_24g(adapter->registrypriv.wireless_mode) == false) + if (!is_supported_24g(adapter->registrypriv.wireless_mode)) bLegalChannel = false; } else { bLegalChannel = false; -- 2.53.0