From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0F153CE480 for ; Tue, 14 Apr 2026 09:59:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160744; cv=none; b=UuLnghWr6HuQQulbQ830ZORAtN2phDQyHHJjnOKAWqRgZkNOugERC+84f0k6OvQw2gsxNWmhyCAZY86fZKkUhIDhgN/Nb7UGbpmBtASluOqHHMzUeJXjvBFgtN/F5JuZINHD/97Fk2BXrPT0EBDmclBRPeRBudpBzZ0Jey1Nazo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776160744; c=relaxed/simple; bh=rHwXM+sex2p2dGPe48QH17nnOkpddITFHnXPlwJpycA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=dRlRwKZXqKBOgv1OERi8qiXQv4poOmB250szmbOQgtGrNYihEKmoOl560mZjJ/TLVtrM+qRGdTh4AvA8kaOlRq60cniZE1xNP1Mqxa+TUmHOWQkS8cDuFtqhOcZ1i9kdc1FDfuOT3blHNmktWys47q+Jh12HgvXEkep1mF+IriA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RivAiLAQ; arc=none smtp.client-ip=209.85.167.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RivAiLAQ" Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-59de8155501so5914355e87.3 for ; Tue, 14 Apr 2026 02:59:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776160741; x=1776765541; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z870y+WgVq6dBDNjDxbOvCEshdD3HN+G5/wMOHsX9mQ=; b=RivAiLAQbqQD1EXy98vO1JMEXDiSzyXXtqeZm2YLwonucNdEqRtHsL7qSqwn0lKn91 7Wd6ovWfxInbywdOHda6NDrfMxgDLTnustbH8tSi47O/Lm+yVSgMdqtluzCNnoTcGTbA 0CdgGgt42RNcFKuPauUz0bi5Wc52RR8sGexhkq25qA0nABkEXwPBHPREO8pg9QmSsmLD N/mZbeKuHqFxO2S477L3nXv7548ud2z07XxrmYtwcPozaLbLuyjON5Eg25qKXNtDk2da BGPZj9Oyntxu6OFG8wiZ/kvFz98x/InErcXnw0/IAKZiN2wr8bXuZfl+6PNmzjsSlYgS RqlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776160741; x=1776765541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z870y+WgVq6dBDNjDxbOvCEshdD3HN+G5/wMOHsX9mQ=; b=oHdK0oPessA/2u4DF4tQntITDxcP8NFGhBA4+hiZbg86S8lTsb0xf/mFNPtNDxiAov kAGXqrZednzhndXYqButczIts5q0wwvToW3H3Fs83qP2WSUbVograpPHF40/iGJUkOpO irGKnZ4n4QMgsEVLsfzblKJuZDrCG6xQbNFpEPTXnvbmeglSy2BgE2bcm9m4xRkZqgNh o/YxyLJoFckeAzQbFq7+szGtl5jfBnBnFEFYMZ8gnrJb4xtGWZe+zgBZWKegByQJRcQx ID3Sorf4cd/qeoDNmW5OdrhViJ7xFl2P0KpwRreXobUo0UvQexgItuMBurMtiQyy9HBE QNZQ== X-Forwarded-Encrypted: i=1; AFNElJ/svZX+39qvFbFzy9v7iDI8z4ADoBiMrR40wOoHEd0tIGQKwHfLiTCZo276tWBvaAxujwzyvSQNq/BDA5o=@vger.kernel.org X-Gm-Message-State: AOJu0YwZWEwswrRwf9lJBzRZIVfCmqBrof6UUctpjnuQwMu9g9IEdVbS UjTtEkbhL9jRGYt37nLrOOce6zAJVHuIYHw0WxvmfhK2U9Odx1qbkiGC X-Gm-Gg: AeBDievN1QN5zcJ2vLhy24ZMA/c1N9p4oAxUGMIg9s2bqJezHPMXU+Ip+OyE9nmJFbY HS7FmmtNuccb9bj04ePz7RQr+M9iTNXXRF+ryvKuhiSv5M7HcPIq8/d+TDweg/nD5C2e2cPMjek +z483b6eqdY5Mdl7z4kaDSNs1KBFET0IUP5yKw3kwu6yv13C67glaZOM1j1fQJ9an13hOKuuYfc TRskH9Gxm9FsNN70oFtWFEdMAdP0C9Vz6VBo+1gc9fEFh0g4DDBANO2EVH/Yg1zhwlE+BwpVsyz gACGxalwTBdIjMx8u5O8B5V4uhUyISaKgvRc4kSfMWuWRcXu20CBvmXCj/DUo4enYEKIVFwvNiZ 2fdSphB6p4XJTXUvLrCF2AzVWjnXUyHGreo2mUBCSKlIWFz0k07uBexukkNzGk0IIpv57VNK6FA JCA3hCrS2fJ/hqlg== X-Received: by 2002:a05:6512:1385:b0:5a3:ffd1:fbcf with SMTP id 2adb3069b0e04-5a3ffd1fbe5mr2699525e87.17.1776160740969; Tue, 14 Apr 2026 02:59:00 -0700 (PDT) Received: from arbuzik ([213.79.119.79]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a3eef071cbsm3208359e87.80.2026.04.14.02.59.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 02:59:00 -0700 (PDT) From: Marc Finkelbaum To: Greg Kroah-Hartman Cc: Michael Straube , Dan Carpenter , Ethan Tidmore , Andy Shevchenko , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Marc Finkelbaum Subject: [PATCH 8/9] staging: rtl8723bs: reformat switch-case blocks with braced bodies Date: Tue, 14 Apr 2026 12:58:32 +0300 Message-ID: <20260414095833.76480-9-regpacy@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260414095833.76480-1-regpacy@gmail.com> References: <20260414095833.76480-1-regpacy@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move the opening brace from a separate line to the end of the case label (case X: {) and combine the closing brace with break (} break;) for HW_VAR_SEC_CFG, HW_VAR_SEC_DK_CFG, HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, and HAL_ODM_STA_INFO. Also add braces to the unguarded else clause in HW_VAR_SEC_DK_CFG, reindent the moved declarations by one level, and fix over-indented bodies in HAL_ODM_P2P_STATE and HAL_ODM_WIFI_DISPLAY_STATE. No functional change. Signed-off-by: Marc Finkelbaum --- drivers/staging/rtl8723bs/hal/hal_com.c | 62 +++++++++++-------------- 1 file changed, 28 insertions(+), 34 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_com.c b/drivers/staging/rtl8723bs/hal/hal_com.c index 44bef1400947..2688355f9265 100644 --- a/drivers/staging/rtl8723bs/hal/hal_com.c +++ b/drivers/staging/rtl8723bs/hal/hal_com.c @@ -561,16 +561,13 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 *val) case HW_VAR_INIT_RTS_RATE: rtw_warn_on(1); break; - case HW_VAR_SEC_CFG: - { + case HW_VAR_SEC_CFG: { u16 reg_scr; reg_scr = rtw_read16(adapter, REG_SECCFG); rtw_write16(adapter, REG_SECCFG, reg_scr | SCR_CHK_KEYID | SCR_RxDecEnable | SCR_TxEncEnable); - } - break; - case HW_VAR_SEC_DK_CFG: - { + } break; + case HW_VAR_SEC_DK_CFG: { struct security_priv *sec = &adapter->securitypriv; u8 reg_scr = rtw_read8(adapter, REG_SECCFG); @@ -578,12 +575,12 @@ void SetHwReg(struct adapter *adapter, u8 variable, u8 *val) reg_scr |= SCR_TXBCUSEDK; if (sec->dot11AuthAlgrthm != dot11AuthAlgrthm_8021X) reg_scr |= (SCR_RxUseDK | SCR_TxUseDK); - } else /* Disable default key related setting */ + } else { /* Disable default key related setting */ reg_scr &= ~(SCR_RXBCUSEDK | SCR_TXBCUSEDK | SCR_RxUseDK | SCR_TxUseDK); + } rtw_write8(adapter, REG_SECCFG, reg_scr); - } - break; + } break; case HW_VAR_DM_FLAG: odm->SupportAbility = *((u32 *)val); break; @@ -653,19 +650,17 @@ u8 GetHalDefVar(struct adapter *adapter, enum hal_def_variable variable, u8 bResult = _SUCCESS; switch (variable) { - case HAL_DEF_UNDERCORATEDSMOOTHEDPWDB: - { - struct mlme_priv *pmlmepriv; - struct sta_priv *pstapriv; - struct sta_info *psta; + case HAL_DEF_UNDERCORATEDSMOOTHEDPWDB: { + struct mlme_priv *pmlmepriv; + struct sta_priv *pstapriv; + struct sta_info *psta; - pmlmepriv = &adapter->mlmepriv; - pstapriv = &adapter->stapriv; - psta = rtw_get_stainfo(pstapriv, pmlmepriv->cur_network.network.mac_address); - if (psta) - *((int *)value) = psta->rssi_stat.UndecoratedSmoothedPWDB; - } - break; + pmlmepriv = &adapter->mlmepriv; + pstapriv = &adapter->stapriv; + psta = rtw_get_stainfo(pstapriv, pmlmepriv->cur_network.network.mac_address); + if (psta) + *((int *)value) = psta->rssi_stat.UndecoratedSmoothedPWDB; + } break; case HAL_DEF_DBG_DM_FUNC: *((u32 *)value) = hal_data->odmpriv.SupportAbility; break; @@ -702,24 +697,23 @@ void SetHalODMVar(struct adapter *Adapter, enum hal_odm_variable eVariable, struct dm_odm_t *podmpriv = &pHalData->odmpriv; /* _irqL irqL; */ switch (eVariable) { - case HAL_ODM_STA_INFO: - { - struct sta_info *psta = pValue1; - if (bSet) { - ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id, psta); - } else { - /* spin_lock_bh(&pHalData->odm_stainfo_lock); */ - ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id, NULL); + case HAL_ODM_STA_INFO: { + struct sta_info *psta = pValue1; - /* spin_unlock_bh(&pHalData->odm_stainfo_lock); */ - } + if (bSet) { + ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id, psta); + } else { + /* spin_lock_bh(&pHalData->odm_stainfo_lock); */ + ODM_CmnInfoPtrArrayHook(podmpriv, ODM_CMNINFO_STA_STATUS, psta->mac_id, NULL); + + /* spin_unlock_bh(&pHalData->odm_stainfo_lock); */ } - break; + } break; case HAL_ODM_P2P_STATE: - ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DIRECT, bSet); + ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DIRECT, bSet); break; case HAL_ODM_WIFI_DISPLAY_STATE: - ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DISPLAY, bSet); + ODM_CmnInfoUpdate(podmpriv, ODM_CMNINFO_WIFI_DISPLAY, bSet); break; default: -- 2.53.0