From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F1070361658 for ; Tue, 14 Apr 2026 12:27:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776169668; cv=none; b=YyzeFs3CizYr1QvF5YrmptLFSs58B1hwneoiv7UOQYpiVA1IPW84PTg1FRSB5qqgB52tBSqU/KW5DYHpzdVGmm34DY4hJG03euT7kLIyIH1zn9Ta+JfAynAgJ/tcSBkkwRNvy5yrPlo3JfscjSOhVW5dHvHjVOZZ7Y5l9XwUJ1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776169668; c=relaxed/simple; bh=Pg0sFIdL9Bj7TCiBCyi37aEsqecqRvLWaskEY9ICd2Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZRJjvTTFfUzIwvMV1y7+HkVpdL0n3pNAvdPQWs/ao81IG1lgmed1RNCLU+BEwfrglU2S0DnlP5IlK44hP9f+EkvziKjSe7216pV93BfitAQG5rxrk+RjqTVg9NASt8wI0xPkaRlx/XA6zdukcDbs1HWUwSJDqBUrEbRVzUdTgwQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=InR8j2j8; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="InR8j2j8" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso57353345e9.3 for ; Tue, 14 Apr 2026 05:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776169665; x=1776774465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ySPe/fU+wa35Y49Pkv+5PnQwWcaNhvp3RPQceVFpXP0=; b=InR8j2j8IngXDUt60394D3Nvvza7VleL+BYU3QbqTyM+5G7CI4D5jQp0op/icmdBI1 trJErl/sVr8QgcHnns3VVuhT3+NBAuXJMg9ShYoO0wYYOVuXu35uoX4ts2U4X+otpW8G +pHslr74fXwRA0W0I9SL63Pcv2iTPByP3KJGCRyFa5XhmnGGLVlhUViw3vDC2W28OWq+ IcnkoZU4tAIElkqJ0NypAYK1yELSBuqvbE0nLOTnq2xPiWuMUR7mYs7ZRhtjENhKi8KZ XXMTUhQsaV1weFmKeuSCtrJbSWUjD/zeEA43bdwukBrD+vswvAA7EO+RyG8Plod64Su7 zl+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776169665; x=1776774465; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ySPe/fU+wa35Y49Pkv+5PnQwWcaNhvp3RPQceVFpXP0=; b=fEQQluEAaq2YssB36X240X50GyN8XvIaA3ODVdojEoGa7F6CvUK9DcZl1jd1+Xlm7L MNLuFHNF72SD96Rml61v5D2qwmFbmQlvT7moIKkgqu7Ws553roDh6ykod4SzozoZJjGd +plx3+Gh45k+m2HoZj0zq6EbJpbH4+Wr21zwk1yTjQ8MMmJgqo0LWzXNnkNWln9Lpg1t L6Uuqr/nQ+L24baJSe9iuW2BOfZt9tp/PV67FQoRbjkMUKa3+qjCrJJ9cCBz5wOYx56q TEe80JPPRW5WQj4jsyOuIxDO7mCqTrcEDucmMFz5kEmim0ZLnl4uu4DpmkdZeQYVYGBY 0jrw== X-Forwarded-Encrypted: i=1; AFNElJ+P1OAqavN8YAyOE0O1la0/viIT7/RICGDPLZrogZ8RQmpZlAhRKehnfoMfDqXtmujZ7TxEpkgxtG+f2c8=@vger.kernel.org X-Gm-Message-State: AOJu0YymlUBrL0x5PVpTKlCLwLPgvDlzSpbtAGWGD0wB5HMAjGVEI9v7 hAYvRV1D4/S0hknDZe27FCHYscMi8Z6FvhtYwytdAmrG9iY2ItnIDGN9+ceSyGvh X-Gm-Gg: AeBDieulYggYPEVsX/ByOOAfGIR0vF8VoB5VQpw78Bk6MadDtFczXSqshwxAm1kouWt eopfmUjF5Iq8lhmyBUL2yDJzXUj5zh/3GOBNNN7HSMXiOve4XjKEbWsiyGrvrOIWPB9MQpUBK39 TXUEOE2o0MVbgGtUyfIgjdPdRDdeXm/iDO+HH69tAeMVZ5I5QrSiAm6B20wPwo0OxEc4UW45jBm iRbTFKJFAo9XewDWEgSPnbqBEC4auXq4yL4cZ5x39xeoka3zOt1d4IN8IJ6M0trbzupyKsY7Fjs EKuWAM1wwAlkXtT+c4WXUcyIMP7kSdh+2nSqrut+ADkqY+vmlkqouLqF0EULGVLzBTDtSuIZPQu Jc7fylrjA0YEwjincBRLqrJi9LZW37sX8IVLmRlaE0KpF5DymTJGIsNdwNCMTIqhA9S+XusrZtQ zzIYtFrfttVbET/M4D5bh+89yaN7P83osoTmoWS6UBUPlyx1JYVccaJ6q8+w== X-Received: by 2002:a05:600c:4e16:b0:488:966f:70a7 with SMTP id 5b1f17b1804b1-488d67bbc7emr259055565e9.2.1776169664623; Tue, 14 Apr 2026 05:27:44 -0700 (PDT) Received: from bazzite ([102.128.175.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d67b128dsm199414755e9.2.2026.04.14.05.27.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 05:27:44 -0700 (PDT) From: Louis Kotze To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] wifi: cfg80211: fix grammar in MLO group key error message Date: Tue, 14 Apr 2026 14:27:28 +0200 Message-ID: <20260414122728.92234-1-loukot@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The error message emitted by nl80211_validate_key_link_id() when a group key install on an MLO wdev is missing the link ID reads "link ID must for MLO group key", which is missing the words "be set". This makes the error harder to grep and parse in userspace logs, and is reported verbatim by wpa_supplicant via its nl80211 extack relay, e.g.: wpa_supplicant: nl80211: kernel reports: link ID must for MLO group key The sibling error strings in the same helper already use grammatical phrasing ("link ID not allowed for pairwise key", "invalid link ID for MLO group key", "link ID not allowed for non-MLO group key"). Fix this one to match. No functional change. Fixes: e7a7b84e3317 ("wifi: cfg80211: Add link_id parameter to various key operations for MLO") Signed-off-by: Louis Kotze --- net/wireless/nl80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index f334cdef8..b0bb94f29 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -5100,7 +5100,7 @@ static int nl80211_validate_key_link_id(struct genl_info *info, if (wdev->valid_links) { if (link_id == -1) { GENL_SET_ERR_MSG(info, - "link ID must for MLO group key"); + "link ID must be set for MLO group key"); return -EINVAL; } if (!(wdev->valid_links & BIT(link_id))) { -- 2.53.0