From: Thorsten Blum <thorsten.blum@linux.dev>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: Thorsten Blum <thorsten.blum@linux.dev>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] crypto: blake2b - use memcpy_and_pad in __blake2b_init
Date: Tue, 14 Apr 2026 17:49:03 +0200 [thread overview]
Message-ID: <20260414154902.344182-3-thorsten.blum@linux.dev> (raw)
Use memcpy_and_pad() instead of memcpy() followed by memset() to
simplify __blake2b_init(). Use sizeof(ctx->buf) instead of the macro
BLAKE2B_BLOCK_SIZE.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
include/crypto/blake2b.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/crypto/blake2b.h b/include/crypto/blake2b.h
index 3bc37fd103a7..a7a6440bd784 100644
--- a/include/crypto/blake2b.h
+++ b/include/crypto/blake2b.h
@@ -66,9 +66,8 @@ static inline void __blake2b_init(struct blake2b_ctx *ctx, size_t outlen,
ctx->buflen = 0;
ctx->outlen = outlen;
if (keylen) {
- memcpy(ctx->buf, key, keylen);
- memset(&ctx->buf[keylen], 0, BLAKE2B_BLOCK_SIZE - keylen);
- ctx->buflen = BLAKE2B_BLOCK_SIZE;
+ memcpy_and_pad(ctx->buf, sizeof(ctx->buf), key, keylen, 0);
+ ctx->buflen = sizeof(ctx->buf);
}
}
next reply other threads:[~2026-04-14 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 15:49 Thorsten Blum [this message]
2026-04-14 15:49 ` [PATCH 2/2] crypto: blake2s - use memcpy_and_pad in __blake2s_init Thorsten Blum
2026-04-14 17:39 ` Eric Biggers
2026-04-15 12:56 ` Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260414154902.344182-3-thorsten.blum@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox