From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 02394318BB3 for ; Tue, 14 Apr 2026 17:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776189326; cv=none; b=ZTV+Ul6IEU15qphOsbPLjIE4QKqBjosvltumqcM8H482dlSvh1PCrgmwpGnatpllelj5RSP2MhsXTTHVC2s1abCM5kwTki/NRzF0N+Hmht6oi2ZCa+EAMUP4wW4FzFcmG5aOLZFwxsCmw9vxivw2i5CPR2dp4FB3ZTJIUeEVtMU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776189326; c=relaxed/simple; bh=Kev0zRkkyGVumrgvUExoQKyIU5Xbuk6spDcRsAkKjvA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=c+/vxUMIRWluRu748C+XmswIdzxzPJa+jJXGungQgmGj41oXPRBw+9qvmMP/jgaUtSfeEDVxHBkJ18CmCSEHaUsd7v1fdFUhpSP4fxAxug/LInn6xexu0JGUSQd4GsK1i19/63vKdYIVAt4Hski8t4wBHkp0Dek+cbMfdE/HCBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b0h0yXWZ; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b0h0yXWZ" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488a4bc360bso32815585e9.0 for ; Tue, 14 Apr 2026 10:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776189323; x=1776794123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WEPxx9A5sVf7Qa7xqxDP7r+0ORunjQzMoxjAyInlaIs=; b=b0h0yXWZVg4OXXr3nqWFkVCKrQ/TExRNllNKAXYPlwdtj27Mje4WiNHQIgYe2qyh2e McJUQQzUwsQVz/wf+4S3cMNoso6J+qPku+wduKCjQUp8XeGC+kLrJlBKM0MDUzfsdC13 bIz8CNld7HPbtnCVmjIOr5y7DDtR1mlnKbcy5zZEVf8mVugOWJ0ts06xDNxeIduS7FgH bdYFRiQXtogYyYfZWZfH8+shVVkrSdYkQJxEy22AJrGslwhve9KZb0fy+XEqpTVwzfGZ 4nMGGx+uKRl3a4+DrOzbqP9dU3aq10tLnZ8q0A23gYfVh3tTI3Sv7gOMC4Xv+eHXozhN i+lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776189323; x=1776794123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WEPxx9A5sVf7Qa7xqxDP7r+0ORunjQzMoxjAyInlaIs=; b=iZQd7+YwSDovYtPho7O4TjZu089mffR8foYksLm7WNCOKI4VpQ78dQ7qqdIKXvWmVL smWziDfygjW1YPGG+u0U6H6uE/xWODzdnTi3fkFL49s0pgzpXusS2vUx01lEXVMYoVI8 dUCwUfhKza7cnpHlPgAZEt/1LO0OHLtTjlGuWnyiiiv1Q4fa5uc96cxXlx5xFUcvv0zR bjC1M/Z3NV45NndDixuAi/Yezdk2zXeq5pVY/0YR+X7TTFKFla5qg0GblOXB5I3l9xpK ph2z4iQJV1cOVSIjJAiCh00wUF0xxJGMnLHvT/yg//jHLtZFgqkFGPs3X3oACUrdxyhb PGvg== X-Forwarded-Encrypted: i=1; AFNElJ/iq/WP2AmlpvEu1Ilgg4EDACSZxLBVJejFDRXe3q9kavMes5Q7P2EbErmC292VgOZT79dMnUJr7kessuk=@vger.kernel.org X-Gm-Message-State: AOJu0YxgCC0MpXJW0+9kqOiSoVnvQDETobjkYZNQa2aFpNi/Vrv0V9Y0 DUnVxTCmdoe2dmrlaq1N24DTtp+d9mVhxQG2su2mc57fzaYN4kmUitsI X-Gm-Gg: AeBDiesYGoEknnXeC9Q7fj5sZTFarYXP+SPPUDf8SDPNOvq+lNja5S+FkEze2KWGXJS VmgPVuzeu04HuHxzAH3O3x5rzx7FZKnrPwB46IXEAUcG8iUlWb+2prUUta5oIcQ/9RAWa6jGKTF aU/ezAuPWifYB1PESNxWF+lSZYNe1WaOcLnxNy94snQhHSUdgWr8GDLoXTyMGUqZAh4Z39yXpAS EntlKeGSenTpFzFNfl3NFCGjnLmb02qU7vX4fULhDyj7aqKNNrQH3zJ+KeLDF8JM5UsDcjq8Yc9 pqMaTxMwbbNCsFJ/KGngSOtyeyTgp0phHGxTS8kFrMEtceigXLcEXO/FNtJ2p/ud/ZWg4MFqNfK PZAbwag3cuMTfNbqkkz70sEq0CwnAu2JXOthTuRZ3AzkHWY8E8tfXl41vTZrn+aiilRXIqokxAh /HSPTyygXfI7ZUAIy/1Ht36XJx7aDZr4w35HtP+/9KzDZae5MahyDtrz1d3S4h X-Received: by 2002:a05:600c:19cd:b0:485:17a7:b9c7 with SMTP id 5b1f17b1804b1-488d67e3671mr252438805e9.10.1776189323227; Tue, 14 Apr 2026 10:55:23 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:cb49:f403:bb20:cc84]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488ede1df12sm150436425e9.4.2026.04.14.10.55.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 10:55:22 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Peter Senna Tschudin , Ian Ray , Martyn Welch , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH v2 3/3] drm/bridge: megachips: remove bridge when irq request fails Date: Tue, 14 Apr 2026 19:54:16 +0200 Message-ID: <20260414175417.144625-4-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260414175417.144625-1-osama.abdelkader@gmail.com> References: <20260414175417.144625-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If devm_request_threaded_irq() fails after drm_bridge_add(), remove the bridge before returning. Keep drm_bridge_add() rather than devm_drm_bridge_add(): registration is tied to the STDP4028 device while ge_b850v3_register() may complete from either I2C probe; devm would not unwind the bridge if the other client's probe fails. v2: IRQ failure path only (explicit drm_bridge_remove) Signed-off-by: Osama Abdelkader --- .../drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c index c9e6505cbd88..2d02cc69f237 100644 --- a/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c +++ b/drivers/gpu/drm/bridge/megachips-stdpxxxx-ge-b850v3-fw.c @@ -251,7 +251,6 @@ static void ge_b850v3_lvds_remove(void) goto out; drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); - ge_b850v3_lvds_ptr = NULL; out: mutex_unlock(&ge_b850v3_lvds_dev_mutex); @@ -261,6 +260,7 @@ static int ge_b850v3_register(void) { struct i2c_client *stdp4028_i2c = ge_b850v3_lvds_ptr->stdp4028_i2c; struct device *dev = &stdp4028_i2c->dev; + int ret; /* drm bridge initialization */ ge_b850v3_lvds_ptr->bridge.ops = DRM_BRIDGE_OP_DETECT | @@ -277,11 +277,15 @@ static int ge_b850v3_register(void) if (!stdp4028_i2c->irq) return 0; - return devm_request_threaded_irq(&stdp4028_i2c->dev, - stdp4028_i2c->irq, NULL, - ge_b850v3_lvds_irq_handler, - IRQF_TRIGGER_HIGH | IRQF_ONESHOT, - "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); + ret = devm_request_threaded_irq(&stdp4028_i2c->dev, + stdp4028_i2c->irq, NULL, + ge_b850v3_lvds_irq_handler, + IRQF_TRIGGER_HIGH | IRQF_ONESHOT, + "ge-b850v3-lvds-dp", ge_b850v3_lvds_ptr); + if (ret) + drm_bridge_remove(&ge_b850v3_lvds_ptr->bridge); + + return ret; } static int stdp4028_ge_b850v3_fw_probe(struct i2c_client *stdp4028_i2c) -- 2.43.0