From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta0.migadu.com (out-173.mta0.migadu.com [91.218.175.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BAFE275AFB for ; Tue, 14 Apr 2026 20:56:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776200165; cv=none; b=RaD1iC9XH3t0QB8EptGyL7vspDRowJwRKr/qYzOMezDI12Ezk5Y2/SGyCyoEZHGZZ0TKOSIXdSU9p/F7vmCVV1xPW4Z+YJXX0Puk2SrOmtKzb8JvKfnXCdwOLpmRxIALaN/XpSkJg/k7JqKsQWmJOaIU01PT32LLkUXfuLXqYA4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776200165; c=relaxed/simple; bh=9DFPAVujpGC2GbzOGPxwNbfZ04jWH6d6SPDB/WPoKNU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Gj2JaaumE3dqWVmAY0pgl541cl6VvLvhNcpvSqaZhOUb3eVON0Gz3hKGMBSNX1jKAml+fYjxISiM3vjiaXGLQo2dA8dHO/kJvAjbuoPVU0+d1G36T8BP/Mhf7aq3vJHHOpGPLoNzeZbLoCRj1/YaSLvaE01eZsl1smKhwmzunN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=oseNf73+; arc=none smtp.client-ip=91.218.175.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="oseNf73+" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776200151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=r6P0nneaaLMO0SWxip7riotnZ1csgytFAw0HMmy3OdA=; b=oseNf73+SKpQHNvMZ8YKgRenLVDRdLN2Oz8hqXGRhfANwfNce3TpX62R5NYaDxumesQuxQ OBB7jryuyrZmiHWJDqAhrSD2VlOeTUpShfNnpRNULCW/KykOlyQQcsdZLUj1Njfng/X1Ui WzdfU3dPRA7PSbDNbwqPPYJ1XL2Fsc0= From: luka.gejak@linux.dev To: Greg Kroah-Hartman Cc: Luka Gejak , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter , stable@vger.kernel.org Subject: [PATCH] staging: rtl8723bs: fix null pointer deref in rtw_check_bcn_info Date: Tue, 14 Apr 2026 22:55:20 +0200 Message-ID: <20260414205520.157861-1-luka.gejak@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT From: Luka Gejak When parsing beacon or probe response frames, if the ap does not provide a valid ssid ie, rtw_get_ie() returns NULL. The code then blindly performs a memcpy() using the returned NULL pointer (p + 2), resulting in a kernel oops or kernel panic due to a NULL pointer dereference. Fix this by moving the memcpy() inside the if (p) block so it is only executed when a valid ssid ie is actually found. Fixes: 370730894bec ("Staging: rtl8723bs: rtw_wlan_util: Add size check of SSID IE") Cc: stable@vger.kernel.org Signed-off-by: Luka Gejak --- drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index 6a7c09db4cd9..2a8aec37d9b0 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1204,8 +1204,8 @@ int rtw_check_bcn_info(struct adapter *Adapter, u8 *pframe, u32 packet_len) ssid_len = *(p + 1); if (ssid_len > NDIS_802_11_LENGTH_SSID) ssid_len = 0; + memcpy(bssid->ssid.ssid, (p + 2), ssid_len); } - memcpy(bssid->ssid.ssid, (p + 2), ssid_len); bssid->ssid.ssid_length = ssid_len; if (memcmp(bssid->ssid.ssid, cur_network->network.ssid.ssid, 32) || -- 2.53.0