From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4379F40DFA5 for ; Thu, 16 Apr 2026 01:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776302295; cv=none; b=b3MZHLAUE9UnqS6a1iay0lYnJRhNpJ879Z8ariXKKzp85InuF/EvxXXe+J38hblDSen/gutqo651Zr9VbXwwubJLS7aWXhoeI8tm9oLgXydhWOQoMKg8VDW8KZK8HARZfVNrXdCNiaXChq5kK0XO+CyVgwRMw+owqKrM7STgsI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776302295; c=relaxed/simple; bh=DGl72FIbDmQEmJDWy3Y/V21uUJmbGFsTrO8y9wocCkI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lJKaeJEEa1Qu3JFgGkAc5/JE2weU6ZafNMdnoy+ehiCk23H2MAFETKeU/cblSYCC9Pl472hpx7B513L5PVybadY3C05kqhcuuL1MhdRdjyrP4nHWNZfRSwwWaAEz+ojj42rMLT7Lygk6a9jhaAYlmDZM048+tu3XpKs2oJ3wRAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=FE38Or8s; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FE38Or8s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776302293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vN4LCRH2zFd+r1GpwLP5obMDV2tytrGGDaWcrG+6scA=; b=FE38Or8svUOd7qHxrDetNDcsde6PJ0gYSb/WhHdHpcVaHwLFzjv9gEyFSxoU1SgTjpIsM5 7yzRFJ9+46F/0PyNbIn9yY5TG+oKGeBflNTVLJWM3y2iJxQR52qihEF9PRgBcmdEHAWHSP Fp7uPnaqlT0cWM6ZVqSnLbhAfcicuZA= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-321-dVyUMxZuPeGT3tDqQDvQeg-1; Wed, 15 Apr 2026 21:18:07 -0400 X-MC-Unique: dVyUMxZuPeGT3tDqQDvQeg-1 X-Mimecast-MFC-AGG-ID: dVyUMxZuPeGT3tDqQDvQeg_1776302286 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1F982195608E; Thu, 16 Apr 2026 01:18:05 +0000 (UTC) Received: from rhel-developer-toolbox-latest (unknown [10.2.16.224]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id B4E43180047F; Thu, 16 Apr 2026 01:18:01 +0000 (UTC) Date: Wed, 15 Apr 2026 18:18:00 -0700 From: Chris Leech To: alistair23@gmail.com Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Alistair Francis Subject: Re: [PATCH v2] nvme-auth: Include SC_C in RVAL controller hash Message-ID: <20260415-coroner-hamlet-36ab7e08cd30@redhat.com> References: <20260415230824.2790058-1-alistair.francis@wdc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415230824.2790058-1-alistair.francis@wdc.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 On Thu, Apr 16, 2026 at 09:08:24AM +1000, alistair23@gmail.com wrote: > From: Alistair Francis > > Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is > included in the Response Value (RVAL) hash and SC_C should be included. > Currently we are hardcoding 0 instead of using the correct SC_C value. > > Update the host and target code to use the SC_C when calculating the > RVAL instead of using 0. > > Fixes: f50fff73d620 ("nvme: implement In-Band authentication") > Signed-off-by: Alistair Francis > --- > v2: > - Rebase using new nvme_auth_hmac_update() functions > > drivers/nvme/host/auth.c | 3 ++- > drivers/nvme/target/auth.c | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) Thanks, this was a good catch. Fix looks good to me. Reviewed-by: Chris Leech