From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E6A63939CD for ; Wed, 15 Apr 2026 13:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776258642; cv=none; b=gzoh8j7orQa07DCKlN9YIaUhAYeHCsj//5awzzqwAsnV2ThPp5Lca4NtjS9Ucu9xKvKdKJDpYeAFvW4F0fXCBpTeq+sQA+9Hnhc5RecRixGl+kjXM90kpTMeHh7/N2+oK9uVlqvXDxGfDacVHWqDjgEmI7d/KeFOT33SWiK20+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776258642; c=relaxed/simple; bh=7PW1lPMswvgJuRQIYg5xAY53B74djXr4QMhYyX34Qa8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PRn1LQ0vDfCPz9Ui1ANPYzxbr4eopzrOW31DNJMt6HcqlMKx6SSw8WkaTkdAapkO/uoNw817dJrOpU7W+Cqt5x5ucO7hQm5EGNTL8+Fes74PN6LO4H6IznXxh/0djZrswMdJsloZ9KZIA8hgmgORjRsMC6DQMHaqtPamCPyIkng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RQs4tvzB; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RQs4tvzB" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2ad4d639db3so35209975ad.0 for ; Wed, 15 Apr 2026 06:10:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776258640; x=1776863440; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Cgiajh9ZFC2IgUfICjc3cGv7OXm2lzFWtpGDZIIxGOc=; b=RQs4tvzBBq9XDDwJJ6HmZjcff5wU9K49rFBaRN234NK5KtU4Ap5gWw5iiTZGgqT9T2 3HtW5ZgQoHnVDrYtWYdr0fkSHp5d8tF+Leu7BaUw5ORHMTMCladbp7JYTmrLRSlPDrUm niIye753DXwM4Xqz57b1yNx7HVn8k2G+Kj8sOIWgFToKYuRg9rGFjHDXV9+6hFZBUa8q ubuo+XwEFR48mMM++hyF68BIDi0AHpxAwXdhZSWQq7C6PA+qz86KtGejZhqLs8VtvzsP aKiJxFvjbC6kZ7rRjMUhPbL8Bzjqw/DZqlPEiPGE4OO5T//x8TEB7/inOJo88mVQqf4a MR6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776258640; x=1776863440; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Cgiajh9ZFC2IgUfICjc3cGv7OXm2lzFWtpGDZIIxGOc=; b=lVxiaiDmjAQNIgV17QLFRmhjO2kacLVFnJlt/+RdFt1rIJ9re08Xd0BoMMzlPYr4tC uuGBrl39UU6C4XuLBXW55v9R+Z3y9GeeveEF2gmcNh0rzvAkjUyAXgD4/SqIWGKG8hWU 9ZBfm86aSgG8KCK6d8KW2qQLLodDoq+0L9YYMP6GA6GAENA/r57FeZwH23zTDJE2NKfz I218dLGnpt9lvjyeAry6Z2J+1mKE/WYagD76lTUpk0vSpkhREJfpsB5C75wwZCg6cslt Px9QjZRnTn9NjaNVmMabVRX3gu8Zp6IuR6/nphXqBYnKWjjxRAg0eDsOHSuLW6TDcvER Xx6g== X-Forwarded-Encrypted: i=1; AFNElJ82LLLyuMRmF9LWByJ+QnbpDaITjfDgJqseBBR6piJrvyTTLQkugJj76sfZ0XTsNJbZWcHRwAT2EGmprzk=@vger.kernel.org X-Gm-Message-State: AOJu0YxSEiccHt4Z39+7mSS73TYqayDoajwLdTaxarS4xutOMY94FlFD 1UV/3Nb7rU4aRPZ3XwQeAhoJCp4alGK/Dx4YYnEablDYlZyP+wtksPqJ X-Gm-Gg: AeBDiet8hELSpOE5VLUbkpkQ9UinCUh8NfXfaB06TE2Xp7ILLl+CefFkS4/gEUIQU/5 bys/nv1UqTojkZBT8/hxwZzPol0p0JwGJMzstdYMuLD8dK+Sami0jk2/fl6lLmrVuCHZbwtdj56 XUiE9we+gtB67+xs3XhGw+yWxyw2x6EBYX1RA1h6rqmwYnFpij8vgDV5y7aki5SRg7Tbypt1xlx +q/RsJZMcetM1/B9JQ2Qd6QwkK3iRMk8AQyZnd9cCxEfRlzJmcNbfUvAVIeW6MyWDqf8xTNuOqO fWBEW4qD75zTm8EfOPSCikcYpdmrN7jSbhwmv4j7dRR50NfmjmpNL5jq1qesxWwuvHGYWxJJD8R qq1jzO1kLDUCXikOnAcZGhwDEWplszFUZ/s1zzgilwAcSLMXebab3xI9sKRbFS9q5a3BxFRX0kr FS5E/jIN/F6zOcEvuHBWsM4KYfn4jVBLIQWJC21MwFoPJY07Ec2MaJCIQrabmmxAX3QDHfRR/cg 3+n6Eg9Kq7/8rpB5E2NE/6ZEkL8Vfc= X-Received: by 2002:a17:903:1ab0:b0:2b2:67ca:5fff with SMTP id d9443c01a7336-2b2d5a5d952mr210669185ad.28.1776258639793; Wed, 15 Apr 2026 06:10:39 -0700 (PDT) Received: from junjungu-PC.localdomain ([223.167.147.125]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b478292053sm28062555ad.56.2026.04.15.06.10.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 06:10:39 -0700 (PDT) From: Felix Gu Date: Wed, 15 Apr 2026 21:10:28 +0800 Subject: [PATCH v2 2/2] thermal/drivers/imxl:Fix runtime PM handling on early returns Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260415-imx-v2-2-aeacff9e72b2@gmail.com> References: <20260415-imx-v2-0-aeacff9e72b2@gmail.com> In-Reply-To: <20260415-imx-v2-0-aeacff9e72b2@gmail.com> To: "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Oleksij Rempel Cc: linux-pm@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1776258629; l=1767; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=7PW1lPMswvgJuRQIYg5xAY53B74djXr4QMhYyX34Qa8=; b=zc9s8r8gJYEF99ja/bK8BCYwUX6qO8U83NdS+xZl54YsmqyvJBsRpZbIBaWc4Errs/PcTw9c/ ylmRwbKMQeDBA6dJu4y5ZbMbRXZFFsIsADvFvXB22DRbNSttxxOPGeW X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= Use PM_RUNTIME_ACQUIRE() in imx_get_temp() and imx_set_trip_temp() so runtime PM references are released correctly even when the functions return early on errors. Fixes: 4cf2ddf16e17 ("thermal/drivers/imx: Implement runtime PM support") Reviewed-by: Frank Li Signed-off-by: Felix Gu --- drivers/thermal/imx_thermal.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c index 3729c3eac748..057dbab70266 100644 --- a/drivers/thermal/imx_thermal.c +++ b/drivers/thermal/imx_thermal.c @@ -274,8 +274,9 @@ static int imx_get_temp(struct thermal_zone_device *tz, int *temp) u32 val; int ret; - ret = pm_runtime_resume_and_get(data->dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE(data->dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; regmap_read(map, soc_data->temp_data, &val); @@ -316,8 +317,6 @@ static int imx_get_temp(struct thermal_zone_device *tz, int *temp) enable_irq(data->irq); } - pm_runtime_put(data->dev); - return 0; } @@ -351,8 +350,9 @@ static int imx_set_trip_temp(struct thermal_zone_device *tz, struct imx_thermal_data *data = thermal_zone_device_priv(tz); int ret; - ret = pm_runtime_resume_and_get(data->dev); - if (ret < 0) + PM_RUNTIME_ACQUIRE(data->dev, pm); + ret = PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) return ret; /* do not allow passive to be set higher than critical */ @@ -362,8 +362,6 @@ static int imx_set_trip_temp(struct thermal_zone_device *tz, imx_set_alarm_temp(data, temp); trips[IMX_TRIP_PASSIVE].temperature = temp; - pm_runtime_put(data->dev); - return 0; } -- 2.43.0