From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A5B31B4224 for ; Wed, 15 Apr 2026 05:07:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776229678; cv=none; b=NVjXinE927JiEM+W4nqICOYSvt+yXqM502X+Bap9cZeF2QoOLRkxoYlSS7MU1V9bcGvNZ6TZGr5oriMJ+KyR8xcm4NxSabpOtKRnrqK3I80gUjnMcU273cSK+EwJB6CvQoIUadTI1/RkX2x64i6YBcEbTu22JGB+OVRgV1tfX8o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776229678; c=relaxed/simple; bh=qcpGYaAjoWZMDk3gUJniK9BI9Qn5rZCkB+eQVXlu5GM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=FjXQpabiza3DWknhg4WIDNYTmp/wpGHIQhQpe77WVBoxFllRiwrw+JNeejPsbccNFgBrjnWdzGR2+iCQp7nua1iZyOiD6vryNgkk3Gv//GRxTCKQiAbOhEgknk4pNlu2vhi1INfV/w/15tSibNnqFvsANspTZ7TXk8fLc/USCXQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NyDAED4+; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NyDAED4+" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-82f5dc076ddso738318b3a.0 for ; Tue, 14 Apr 2026 22:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776229676; x=1776834476; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=NLD1BRP/gok9Ohl7X/j3O931d92BKJ1ZjnQd79EeekY=; b=NyDAED4+ZQxQmHvGHBpH7iom5e4USuo5PEMjEXB2M0nFsw/lSHhYWMZExLbXWSaMz+ WR/RHbOLjP2TkEx6sDyRa7ucNirax4hxgrkd/qvzlQca46Gpglh5PlFyw4D2nFgzbNZf U4xmjNblN5sLu1XutNEU2emOn8kqIBJJwMJbRPQpL2SR8+Ictf9lT6OuTSL3Y86YH3L4 hcgGu2JGJ7nwRb5caIvfi4E92ptzHmY9jeEFCdIG3m7JjmULyuy6brMxx9ZJhxPeJTSU LvR1F57DJrQH+Yuhhvx5EgTu2oQCMfvZU1gbym14frY3WMylan83dURoi1q5aORmEuO/ EKCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776229676; x=1776834476; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NLD1BRP/gok9Ohl7X/j3O931d92BKJ1ZjnQd79EeekY=; b=oBaWZlmpA/IR7liEGdlpjA+7RRQh6Tz5b8IUdoXwLOxBzntGLi8BQmPmWAo4rhLOge XKne3qMrdCKub5lQyevlmLmWFJmXog58e5bp++S6DuJkxs2NTZCvVRXFQQK8K04hivbe N0tZAtfwuyHCQO6Ey8lT9dD1oDYwZj2C4go04ODYbiWrZmwS/BvnhxgL4ZzuF8G+J4Es 55GDK8KliD0b8qGgMcwxVMYXghD02ZUI2CUJnBv+bfHP3o1WHMEzv960F/8UrykZRrhV ZCJ9sW8L1bkmWP9FuSqEMg6iSO1tMVZslRQMJEJ3jJHQk45dA8d37t6/EmIPF88u49oU LpuQ== X-Forwarded-Encrypted: i=1; AFNElJ+SbEAXUMsJyjJAtg7EHSoSuioyszUWutxyve4a85lD7Czd0XMXhTdDt2RO6+43E5e1+78ALBMXFia7qX4=@vger.kernel.org X-Gm-Message-State: AOJu0YxSQiQTkxVsWTP5CFZGMtR04VUDjZMVHSCR/cHe1MS2C/njGdtv 171XshcQ75KdKWDoh/JLGvSzyT0EDvERK8Yoo1eHNT2IKWagPZN5o3fu X-Gm-Gg: AeBDieulcpstCUKmiwne5QhvxSRN8h00h4DSd4lD2vQFPs5XEd43fK7Yd+UsaLFaYQs r9QaSuZcJvTC8ufjM5QNcD452hrQ1PdUdEK/sMO1dKhEXQQ5ctCT4aJhBqATYcp0Q9pohbDW0o8 QDM2PtW7/nfnbchwbAmsw36lCeRsXKGripwXzQl76Qh9tA/ySKLuN1grHqgUNPynupqAK444oan Ql+XVsOB3IrB1lpBr5y9cabsu1el3nog9YlR7oDTmziERpE3nPszrmQlQUlz3RE5yFfsKX8XLQn JNIzF0QqLuTs6RoZqC3XsleGTZm3yej5YBbkB1xuKYbm8xvM+TniURuzn88H6IZZW/00mDTZ7yh QCvMyUQD6gotR1GrJIWbFCaMyfT3en4j46HU5dJ7K5eGZtiiAuKQMKYWsJWxmHu/G+6/JO/vx5f ekfEuxFSIoDRISkWGD1JWlQo9XBQYrA35HJXl//zV91Cqvg9Cp/3fQ4Rr/Hr4= X-Received: by 2002:a05:6a00:6906:b0:82f:c9a:d335 with SMTP id d2e1a72fcca58-82f0c9adb55mr14329234b3a.40.1776229675901; Tue, 14 Apr 2026 22:07:55 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f67469dc3sm763706b3a.58.2026.04.14.22.07.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 22:07:55 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org, nabijaczleweli@nabijaczleweli.xyz, kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 0/7] iio: ssp_sensors: improve resource cleanup Date: Wed, 15 Apr 2026 10:37:42 +0530 Message-Id: <20260415050749.3858046-1-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Hi all, This patch series improves resource cleanup and error handling in the SSP IIO SPI driver by adopting the recently introduced cleanup helpers. The changes focus on making probe/remove paths more robust and easier to reason about by reducing manual unwind logic and ensuring that locks and dynamically allocated resources are released consistently across all exit paths. Key highlights of this series: - Reuse embedded rx buffer for SPI transfer instead of allocating new DMA memory in interrupt context for write transaction between AP <-> HUB. - Replace dynamic resource lifetime management with device‑managed (devm_) APIs to simplify cleanup and error paths. - Refactor common helper API, improving readability and reducing duplicatation. - Address minor codestyle warnings and use dev_err_probe in probe path. Changes in v6: - 0005: Drop remove() path using devm action with input from David - 0007: Replace dynamic memory allocation with embedded fixed size struct buffer - 0004: new: drop duplication in remove() - 0006: new: Use dev_err_probe in driver probe() Changes in v5: - Drop usage of guard() helpers to avoid mixing mutex_lock() with guard()(), based on reviewer feedback. - 0003: Refactor shared helper API, reducing duplication. - 0004: Convert resource allocation and teardown to devm_ managed APIs to simplify error handling and probe/remove paths. Changes in v4: - Update sequence and make checkpatch style fix in base change - Split WARNING and CHECK change with input of Andy as 0001 and 0002 - 0003: Use guard() instead of scoped_guard() - 0004: Use preallocated buffer to stash memory allocation No functional behavior changes are intended. Testing: - Compiled with W=1 - Build-tested on QEMU x86_64 Based on: Feedback and reviews are very welcome. Thanks, Sanjay Chitroda Sanjay Chitroda (7): iio: ssp_sensors: cleanup codestyle warning iio: ssp_sensors: cleanup codestyle check iio: ssp_sensors: factor out pending list add/remove helper(s) iio: ssp_sensors: drop duplicated wdt timer and work cleanup iio: ssp_sensors: convert probe and teardown to devm-managed resources iio: ssp_sensors: Use dev_err_probe iio: ssp_sensors: reuse embedded RX buffer for SPI transfers drivers/iio/common/ssp_sensors/ssp.h | 3 + drivers/iio/common/ssp_sensors/ssp_dev.c | 119 ++++++++++------------- drivers/iio/common/ssp_sensors/ssp_spi.c | 83 +++++++--------- 3 files changed, 88 insertions(+), 117 deletions(-) -- 2.34.1