From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp153-166.sina.com.cn (smtp153-166.sina.com.cn [61.135.153.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE29137648D for ; Wed, 15 Apr 2026 07:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=61.135.153.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776239577; cv=none; b=GfMGXr4fgoOLeQTbXipB60K8/4gGdixdM36en5YRLgkFlqzr1ahr64oWJZuyICCKJqaIMAOJPFB5DRo1jY0WcFYXXZ4J2JUJHxI3Pwa17HBi4fpYNY+VMM8mEX0kXhquhQYey15/g+BftqYjv2blw6vUtEX7+fZT4/01fA+XM4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776239577; c=relaxed/simple; bh=3u1Oz42JdA8g0tXxdJby61eR0D7GdyI7gdpOVB4WDb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b/pk/rZDGrffLtgQ4Xf8jhrttUefoUcEA11fpKgDuq165iZdfW6pvhC1MsPYd8qhXOTDkPNKwT2wP84+h71ZJUrypLjqUIuYO+NA8CDYGznsBEnrpuBdTOHKvlHMwSI0uOAJ2a1aXHHcF+fzSPkWd7vZ+qUrg9UW+u84krzfI0c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=baB6eA+F; arc=none smtp.client-ip=61.135.153.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="baB6eA+F" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1776239571; bh=lUSpSHnUiuA48qs+BdZL2mfzKiteKo4ozhYKVcPQriM=; h=From:Subject:Date:Message-ID; b=baB6eA+FS726dx+mlygKglkxIr3HcQelLC8Sgp/YdDga37L/tbomk9W5H5kP3goAi o/35Q272hWtjYRcOeTPFUJ4u2LsYLpYCPVNo5y8KfSwOY8/KADAAkhmRv7Olr+zryt SAPVmHISJbvckyfkDao5xHfdjrvLFZ0H4/FPv1B4= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.62.144]) by sina.com (10.54.253.33) with ESMTP id 69DF433E00003554; Wed, 15 Apr 2026 15:50:24 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 3029896685251 X-SMAIL-UIID: BEA155271BD242F38570A32C989614BC-20260415-155024-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [dri?] KASAN: slab-use-after-free Read in drm_gem_object_release_handle Date: Wed, 15 Apr 2026 15:50:12 +0800 Message-ID: <20260415075013.1880-1-hdanton@sina.com> In-Reply-To: <69dd24f4.a00a0220.468cb.004a.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Date: Mon, 13 Apr 2026 10:16:36 -0700 [thread overview] > Hello, > > syzbot found the following issue on: > > HEAD commit: f5459048c38a Merge tag 'i2c-for-7.0-final' of git://git.ke.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1028d106580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=6754c86e8d9e4c91 > dashboard link: https://syzkaller.appspot.com/bug?extid=b2e951687503f32f74ce > compiler: Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1428d106580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17509036580000 #syz test --- x/drivers/gpu/drm/drm_gem.c +++ y/drivers/gpu/drm/drm_gem.c @@ -404,7 +404,8 @@ drm_gem_handle_delete(struct drm_file *f spin_lock(&filp->table_lock); /* Check if we currently have a reference on the object */ - obj = idr_replace(&filp->object_idr, NULL, handle); + obj = idr_find(&filp->object_idr, handle); + idr_remove(&filp->object_idr, handle); spin_unlock(&filp->table_lock); if (IS_ERR_OR_NULL(obj)) return -EINVAL; @@ -412,11 +413,6 @@ drm_gem_handle_delete(struct drm_file *f /* Release driver's reference and decrement refcount. */ drm_gem_object_release_handle(handle, obj, filp); - /* And finally make the handle available for future allocations. */ - spin_lock(&filp->table_lock); - idr_remove(&filp->object_idr, handle); - spin_unlock(&filp->table_lock); - return 0; } EXPORT_SYMBOL(drm_gem_handle_delete); @@ -1085,9 +1081,23 @@ drm_gem_open(struct drm_device *dev, str void drm_gem_release(struct drm_device *dev, struct drm_file *file_private) { - idr_for_each(&file_private->object_idr, - &drm_gem_object_release_handle, file_private); + struct drm_gem_object *obj; + int id; + + mutex_lock(&file_private->prime.lock); + for (;;) { + id = 0; + spin_lock(&file_private->table_lock); + obj = idr_get_next(&file_private->object_idr, &id); + if (obj) + idr_remove(&file_private->object_idr, id); + spin_unlock(&file_private->table_lock); + if (!obj) + break; + drm_gem_object_release_handle(id, obj, file_private); + } idr_destroy(&file_private->object_idr); + mutex_unlock(&file_private->prime.lock); } /** --