From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1C8B03CBE62; Wed, 15 Apr 2026 08:09:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776240589; cv=none; b=iO7g9VXO2I8DoLsTNV+yanVqVVIDgOLxklUbJZQFYfAFKeGvVSpkRjORhYon+2FzvCJVnDYlZd5AOFxR+neOJiSgYD2hhQory+2TQLdl2Ali0pVPp6QJhWKTDFo5yWAj4wVOgPd1JlrjTr//sPe/9ohx3AV5ggQwasckYGjWFsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776240589; c=relaxed/simple; bh=Mij9Sxr1Qy0J990aOwIvuoxCuElTG8l/S718L9p/6t4=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EXXEOPE1FEjzJylYZdKTnydHTmQJ0j9/KV4e55oyFzQ9fnxko/2DEURKECda7McFk5WgfvAshUXoCA60qP+4gjMkahASTIVmAxck+ByEuX1A1V9U7LKWkHLNOzT991xbt21wpX8n59k23IYwOF6p0D2kMIkAsKp1Jzp6Pu/vV3Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=PJ3leQrk; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="PJ3leQrk" Received: by linux.microsoft.com (Postfix, from userid 1173) id CF35220B7129; Wed, 15 Apr 2026 01:09:46 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CF35220B7129 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1776240586; bh=SqpIT8gp/3a7HNlDMjOVhKOsjJhTqG0v0PlCBeVjbQA=; h=From:To:Subject:Date:In-Reply-To:References:From; b=PJ3leQrklGFo1jyaygGICFfb4Vsdcjsa4eNwbEsmPPkifYcjj6s7ka2wCy2HxZ9iU q8u/Qm4rmPr1Mte3GTVDf7AnxU/UXC9Wxh+tv60m2woTf9r4gYwBmfdDzt5XfnzwNi EZcjaYhI1FRrXXVClnGMmN0oOZH9T5F+0LVfA4h0= From: Erni Sri Satya Vennela To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ernis@linux.microsoft.com, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, kotaranov@microsoft.com, leon@kernel.org, shacharr@microsoft.com, stephen@networkplumber.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net v3 2/5] net: mana: Init gf_stats_work before potential error paths in probe Date: Wed, 15 Apr 2026 01:09:38 -0700 Message-ID: <20260415080944.732901-3-ernis@linux.microsoft.com> X-Mailer: git-send-email 2.43.7 In-Reply-To: <20260415080944.732901-1-ernis@linux.microsoft.com> References: <20260415080944.732901-1-ernis@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Move INIT_DELAYED_WORK(gf_stats_work) to before mana_create_eq(), while keeping schedule_delayed_work() at its original location. Previously, if any function between mana_create_eq() and the INIT_DELAYED_WORK call failed, mana_probe() would call mana_remove() which unconditionally calls cancel_delayed_work_sync(gf_stats_work) in __flush_work() or debug object warnings with CONFIG_DEBUG_OBJECTS_WORK enabled. Fixes: be4f1d67ec56 ("net: mana: Add standard counter rx_missed_errors") Signed-off-by: Erni Sri Satya Vennela --- Changes in v3: * No change Changes in v2: * Apply the patch in net instead of net-next. --- drivers/net/ethernet/microsoft/mana/mana_en.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c index e3e4b6de6668..468ed60a8a00 100644 --- a/drivers/net/ethernet/microsoft/mana/mana_en.c +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c @@ -3635,6 +3635,8 @@ int mana_probe(struct gdma_dev *gd, bool resuming) INIT_WORK(&ac->link_change_work, mana_link_state_handle); } + INIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler); + err = mana_create_eq(ac); if (err) { dev_err(dev, "Failed to create EQs: %d\n", err); @@ -3709,7 +3711,6 @@ int mana_probe(struct gdma_dev *gd, bool resuming) err = add_adev(gd, "eth"); - INIT_DELAYED_WORK(&ac->gf_stats_work, mana_gf_stats_work_handler); schedule_delayed_work(&ac->gf_stats_work, MANA_GF_STATS_PERIOD); out: -- 2.34.1