From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 67C75366814 for ; Wed, 15 Apr 2026 11:13:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776251637; cv=none; b=mZmxGxSM8dpiaK/uQuHLl7iBOb62USA+Zr++hDaqI45Nfv3po06b+yRguKIfMN//B5VOeIWqRsgaCaZPNkhAMNu2wUUZRJLTzeP0DvLlgO90GHZ6A6u7G1lIUwFjTqHpv74SpOxf0j+6qGFkoct5puR+rWQsBs1aEls+Oa9PVf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776251637; c=relaxed/simple; bh=dy4wkkhXv4bsUtA/u0OPZxF1lQyfau0EumGslG9Fl1I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=WA+lSI9COD6PDPio3soNxCSYJjhDp61Wx9BAr0+NbX3SX3heeYAJ8eavutaeyJslOu54p9dFgWZ0oS2S1k84kprMgCHoj7D2a0Ul+0XWlKs0cUG8Gmq8FN3xCmax9XGOUaxIoMQGuvKSKWqRoHLXDtfX/ayWbeok0MWFHXN73g4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oAsO7Mee; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oAsO7Mee" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-48896199cbaso70338985e9.1 for ; Wed, 15 Apr 2026 04:13:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776251635; x=1776856435; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ftwnJ4t6FsoldVazgB075ASjN9AOKQcVGQ0JpGej0m8=; b=oAsO7MeeZQZLoMitIDw/7STRqqx7fsXhcg9Qos+JZ/bA6MDQXzMzl+48CXowHAXL+Q xK5PVx9KQyrc0TeBwdWqEMZKDTz/6gfQdoj0oOq7tv66gp+m+ft8ZZBEpQeRLD3E1t01 FMpHFQFS8DMpWHJWnfuDH8GXX5UJ/9y0BU5XJUwS6/tFA2XYajJF5eX/JtDzQQk8UQHg p7SxzXriP15RD5tzpWL6xnjmEznim4+EO3GBPHUmdixS50rndXb5cdp8/PIAY5JBrNdW hvPuBFvPJL5OAZEm9hvMrUV7gFMawrInvYTn+FQfoNU6Sfb7s+LNkeDK5P7svguGpJwt 84KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776251635; x=1776856435; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ftwnJ4t6FsoldVazgB075ASjN9AOKQcVGQ0JpGej0m8=; b=bXsG8B1BkVN/fZRbDrYPYQU8WB2/BLdpXclmSIp/7RvM4Mj5MydSdyJd8Tc/NNNeKR LMgZxk27q+Wl3S1ai593ygmZipGzAngMNLYVLfsMKzdVF7R5sce1beZxpJp/EC8KtdHD 8zGLHNadG1hN7tBnrg6G4Dj4Vn6Ws0/E2ETHyC+qTD7zHuj2Z81yBVmJpdCZxvN3x/+B mCPO9QslWfQvMdC2A5DAyjqSXQzTofim5O6pNzVocXM+wj8G33x4nq96Njl57c6lOn+g tcZf6KCaphsXd6lLcsgKypUW17nUWE8Bi51QZNC2N4TAFO1jYKAMApbv7cryCnpdBOsp inxg== X-Forwarded-Encrypted: i=1; AFNElJ8ejRwMfd97eKmeEgEDR82br6LcjCkbk5gOglyt8LhwMyKonY1cFeDP501ROlL41ulBjQN7onshsHCRYzA=@vger.kernel.org X-Gm-Message-State: AOJu0YzrcUQgGZxJ7A+1ewgWzN3Mm63kO6kPIHE8UXNaF76kv+PuFxtM wZqnFnw+wsvDrjR9+mDjpKew639tLwqAyN19mlTG3uryDh5LaEFCzK83 X-Gm-Gg: AeBDiesyMFfTxfpl+HR/t4+hOMi04l8rttFT2OP0puLHL7bWexfZlM1WxktY8eRpigf LDmrUfRWmHiRLEbDwQoZ8cs2iYeA1FeLfpM6h2StD8yKzmeBqyyY/pAIlxdBsocCvGv1RtAdRkk bU6tlKpocRu8WT4AafeNdwybmvv1YErKq4zx9oQ0i4XYzMJ7O8WZUEkdzFmyjnoW5bKaw0619V0 fDpvk4i94Zzj/E8tQ8BRPMGdx+UflR1rWBeHSkEYOc30QH5gsqbBkgVj3vBiFD3cqZhOBkN6RhX qA3dCI7QiDrYwtx2kStkvrRjoNy9An9/SzgaaX/D1XOmRYNOlnYv4dasRNJsikaRkurfcG9Yjhq F54SjPtQ/mA10r8FJMUvfpmYpqSxc/HjNHjUeE1lKBv+S8gFp4PQKpT+edSD6DsDibzOKvx8AMW 99XXhdkTh4hJgBoP2RmPrwvKYmJnD7L7dvEr+dSTB+GznOUmIZm0wqBzadLIOu1XrtRQSi X-Received: by 2002:a05:600c:5249:b0:485:7f02:afd5 with SMTP id 5b1f17b1804b1-488d680079bmr282387305e9.13.1776251634708; Wed, 15 Apr 2026 04:13:54 -0700 (PDT) Received: from bazzite ([102.128.175.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0ebd0e1sm17995625e9.28.2026.04.15.04.13.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 04:13:54 -0700 (PDT) From: Louis Kotze To: Ping-Ke Shih Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, rtl8821cerfe2@gmail.com, Louis Kotze Subject: Re: [PATCH 1/2] wifi: rtw89: phy: increase RF calibration timeouts for USB transport Date: Wed, 15 Apr 2026 13:13:38 +0200 Message-ID: <20260415111339.453602-2-loukot@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: References: <20260410080017.82946-1-loukot@gmail.com> <20260410080017.82946-2-loukot@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, 14 Apr 2026 06:32:35 +0000, Ping-Ke Shih wrote: > Looks good to me. But please change comment style. > > > + /* USB transport adds latency to H2C/C2H round-trips, so RF > > + * calibrations take longer than on PCIe. Apply a 4x multiplier > > + * to avoid spurious timeouts. > > + */ > > For now, we don't apply networking specific comment style. Keep first line '/*'. Will fix in v2 — thanks for the review. Louis