From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12722368282 for ; Wed, 15 Apr 2026 11:13:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776251640; cv=none; b=mg3aQneuvpWlQ+izfJgJDR7AZkr70MPNqqzcFrTXDAbTAzI008SAf/tvCCb9ismjEF40h3XSdsJvNt7RBfzW+Iw+qCi2eqhsOh3ijDCxnY2N+qoATMoiTwnBDdvGAuZj+mfaH1q1FG/2krNaygJJro3jCa+Lt+qjlkIwESbZHjc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776251640; c=relaxed/simple; bh=Nzfye6tHH6Yocnt3whTFhpZ9gV+CeQ1OOIiEW1XvhTw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YuYf/YFhVHISp6lL+zafDzKf/HwUYBy2fIS1Xg6dbA0DPWY9wR8JRBRuqvFUKT6F24jjvcbe5367uqBBYZoItQMVtSpZIBg54bret5Ue6dWruKPVHRR9h5VmX0D3yd1UgpPN6a8zsnktXdky0fDnx580TSjV9FpwFERlKJRB9vo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jCecPgnF; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jCecPgnF" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4838c15e3cbso62575185e9.3 for ; Wed, 15 Apr 2026 04:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776251637; x=1776856437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Nzfye6tHH6Yocnt3whTFhpZ9gV+CeQ1OOIiEW1XvhTw=; b=jCecPgnFK8JzQlsvSZji2Vlgik3ba40i1kJGn2GBLSw/3sY1AthGOX5It26JEFKHYg YqjzAwE+zuEMFfI7hhq9LwsbTqV99SAzB9DpL6/7PIcw1idDxvHl2NMOyqijlqeS/9RM 6hm61C87DSzn39mVkYDiKxoYXPJJ7c95o0rRip3oX6FtOe0Mjn4VSNW90U4vgpnCwo3Z r5b0wDMmDvdDy8TDW0IcpMXRrFzQ1EvLXyTD6rbRANMG0FFYiZbsQgAdTENHZmcG3/c1 7YE1qhS3v/w8YgnBaFEHu+8ig0Nkk5GaOUNzHv9RGP5cloQZnch+7xft+ycsSYFqsKcA L3uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776251637; x=1776856437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Nzfye6tHH6Yocnt3whTFhpZ9gV+CeQ1OOIiEW1XvhTw=; b=g8Pk29IXuwyQG32IQPvfebYLFxry/Mrnlsi6bhSJksTfQcFKPUSN+0H1ZBekKRIpZw faVLTuvZ3uJ5EC249P0kiJoa271sXMyDbFt+5aTalQUEO3zSCYn30QR3PWTlcqLnMcl9 yAoZ9sUWzAgzIxGt86ZmnzqJLtkzu71iimblN9IMtZE0/udnvf7+dwsO21z5SXMPlp0f AMsxbkBLKYRhSmfnRo4VL7xqF2j+pjrYgwmDmusd6v8yCNLKwhNWNSBLddVjNRN3Z4gZ 6KcDsJAxhZSFprjz9FtPKxZcKpdv2PKQG9zm+6y2IYLmtJ7D9FBd+q19NCRSjZVz4ypM 1U4g== X-Forwarded-Encrypted: i=1; AFNElJ+6P8c1J1UJtVv4vMi+QEChb1V9ZwzGtV1FZJHpypEI0JJhdBV2UjiaOz5btnHKpIoC5d44gyW67a/8bqo=@vger.kernel.org X-Gm-Message-State: AOJu0YyneatRzloJcJC7PVZtLRFkkjN8k/tHmW3DHvJ8YEci3LffY3XA YPgVohIFRwsa0JdxDLJodUrYoTder1hBYal2/kQjz6RiiR4/Axte0cmy X-Gm-Gg: AeBDievION1r8q5wywqp00VFysQtLjzlfOfCQvVRzUl8ygPgVL1LfmusirZpfWNca62 NgABRQERAtSxCOX63NBTk9WuaK13aVv2TSX/E9wb2wrDCGZzcIGdfKs7dUWTIc2qAvkDouOWJbY wru6z/Upn7BxZOV5khdiOAN0KErI7CL5Fgj/Yvc/RgTp2bVfseNvp2HxdFQ0zHnoL9q48wHhLB8 4MqeGJ/oYtPC+hCqWURhhN+AoMy5Nzce+L3RCaz2FR5J0ffioyNF8uJjvYQ3PEoH3acdsIBc6rB JP8yOS3/hVC0H40BRBi33+gPrEpMy4+S2Fe1XoaB0PCzMOGLi4zUIYOvtQtfy+yYMGLd+YyF0iN rCYp5vmFA5VzFNtAvbuz00rhmx/0LCvsbCL4Cj1vGc3WSfzmvSbjcKGwT9KBxhww34iYbEPWsAU 1KCM9iWG3GAy7Lu1CkbmlHfHmAGk+WaxaZ7SX4797R1tTdutW2rRul1J8ju0MT8z99tWgV X-Received: by 2002:a05:600c:45c9:b0:488:bc6a:5285 with SMTP id 5b1f17b1804b1-488d689d277mr289294075e9.30.1776251637396; Wed, 15 Apr 2026 04:13:57 -0700 (PDT) Received: from bazzite ([102.128.175.252]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0ebd0e1sm17995625e9.28.2026.04.15.04.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 04:13:56 -0700 (PDT) From: Louis Kotze To: Ping-Ke Shih Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, rtl8821cerfe2@gmail.com, Louis Kotze Subject: Re: [PATCH 2/2] wifi: rtw89: phy: make RF calibration timeouts non-fatal on USB Date: Wed, 15 Apr 2026 13:13:39 +0200 Message-ID: <20260415111339.453602-3-loukot@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <9f43a228419b44b1a55ee3d8c31abcbd@realtek.com> References: <20260410080017.82946-1-loukot@gmail.com> <20260410080017.82946-3-loukot@gmail.com> <9f43a228419b44b1a55ee3d8c31abcbd@realtek.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On Tue, 14 Apr 2026 06:39 +0000, Ping-Ke Shih wrote: > If calibration timeouts, the performance might be bad. How about just > to enlarge timeout time in 1/2 patch? > [...] > It seems like we don't actually handle the return code for now. > Could you point out the path you encountered? You're right on both points — dropping this patch in v2. On the return code: it is indeed discarded by all 8922a callers of rtw89_phy_rfk_*_and_wait() (11 call sites). My original "connection failure" report was the host dropping the link after repeated "failed to wait RF DACK" kernel warnings, not a return-code cascade. The 4x multiplier in 1/2 already fixes the observable symptom. Also, on 8922d rtw8922d_rfk_tssi() does check the return and uses the failure to fall back by clearing is_tssi_mode — making the call non-fatal on USB would silently break that fallback. Not something I should ship, even for hardware I don't own. On enlarging 1/2 only: re-verified the 4x multiplier under stress-ng (CPU, memory, combined). DACK peaks at 71ms on 5GHz in every scenario, including baseline idle — the calibrations are I/O bound on the USB H2C/C2H round-trip, not CPU/memory bound, so host stress doesn't move the numbers. 4x leaves ~3.3x headroom on the worst case. Full matrix is in the v2 1/2 commit message. v2 keeps only 1/2, with the comment-style fix. Sending shortly. Louis