From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDBC31514F8 for ; Wed, 15 Apr 2026 11:59:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776254378; cv=none; b=YPAac37kZj43gR9cNENsPfOmXV+K2p7apBrJjF9akvMDqzOOTwendNznC9zy2tNjHecYEEU9dyIgxBuI4xON/B2lmZpJY4dZrHFR75UZxLmuMazG27GTmO/TWBOK7RhdgGDRYSz/IZNXAZbGslkhB+u95vDzdnzXBKpogeJuhLY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776254378; c=relaxed/simple; bh=lsIK530J9rorILTl0cQT4a796RNRQpMgSqxNlND8QLc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gWxT59c6DqkIaPerTzsrIiqCjzLCcYLEpLV436ayFmkeQDlllMBcQnDWkVyLdHbNHUMZhw/odBsI2FgiHBcY+M7p4mSDfMRVqs3NWJOBAvyTm25Lq5+KXfvYcfc5nZhxqy2N9vYDN7n4StBOhzZdXPkNKTxc0HEkRtVVaczcdoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com; spf=none smtp.mailfrom=readmodwrite.com; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b=tyKfAcKs; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=readmodwrite.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=readmodwrite-com.20251104.gappssmtp.com header.i=@readmodwrite-com.20251104.gappssmtp.com header.b="tyKfAcKs" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43d7a5e77b1so1954732f8f.1 for ; Wed, 15 Apr 2026 04:59:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=readmodwrite-com.20251104.gappssmtp.com; s=20251104; t=1776254375; x=1776859175; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=byoxSE8eLNhPgNMdLhg0WIr8vPNq3K1YFYQrkyVGxmc=; b=tyKfAcKsDY9uywwLZkADWM8nd8UK+iRpfh08vvkFa1P3/Z2Ug2LpABH3fAWYdWdOVa v1cxNR9DDPkh8azeBX5RZsTUClDk/tGbwo1549/FDrZC92fKlpinTeNxvPWpOs51IYhF IGAkmn20GLMZHe5SaVvhGtuTuJcV67VxvVR9l8M7HfzY1CpRdGkFUgd5RGeaChsInEBp fwqX34ALOvvsFCXaKtKh1aw9VZ9VYP/6UtGmcMnwPuXYgK97bKRZLBesr5a/ss4b2bTb obDy/baCLXDLf/50j7qvQlJL2tazu/YMshnMVAe2bC3rdNMu+3xS7PUcRlgpdJTw0Lvr VBhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776254375; x=1776859175; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=byoxSE8eLNhPgNMdLhg0WIr8vPNq3K1YFYQrkyVGxmc=; b=Qj1nhjLehJdm33S79ofCXE668RMualW51VrxakcpYwQgoZtB8Wj+Cw80RSnce21iQ0 WXeW319bboSP7bVSPUAovtbL8nmK5IbzfH08g8Y7K14AppU/64Jkuh4np7ACMVKdoip+ d2xGhejwzvSqWrhRbmpSTcI50VWSOqBPKZ5exjCPrownTc2anjEDI2phplTabQnVE1+r vylIFEQUHmXH/1Gu9Lb+dpnx6UUUgIly7/akr6CyO9MtXJ2CI/hkHZoUJa/S97DAxrOW gkUPLpnnl5wnK/H/OltP/uBBX5EOtPkqId751L69YFnrbPvogEWUbgb9p5Snk4yIhMDM U09g== X-Forwarded-Encrypted: i=1; AFNElJ8D/zowDEKolQIQfA44wCoc+53i17fuCSL4HZpoJgm9fVpNttBCtWNVapEs6x+bM6wXWdP7TnFM/1IHt54=@vger.kernel.org X-Gm-Message-State: AOJu0YwxHs+eKPj7dyIH8BiatEpnr24Z1Tw2uPILt/XR66jCqjfLe40G I+Q8gg3tk+Q/00A14gFIpo6CN1+h/+lI17jeXOkQCu7EI7krKMvwLNIqZmrOHMj6WSs= X-Gm-Gg: AeBDiet+gU5vSwBo2Tt7D+xvmm96DMeDc8CBIgTG+15ZabXIsC4w/EFse5r6WR3GxTS wK0yAprPCs+oCH3bLM43HWKlyf+p5eEBQ3Qh9NsGJUdErZ5ZREu/C1SnQYY0SUeqPcxWYBzR/4y DedParxLtByfJUosajBKuRwVk3faCTII8EyPAYWudyZqME2XH6D15qTbkC51ZpjQiPRQfJ+rRwJ 8VUVlRmF0BP9C9QJz4+ZINtHtlSGjJujrSw2T/C9pF0YdUb3/F4+5spXv19JI5X0sq+QSb6lBV6 IDaPUCYhtcRwJYKB9sqISYrRX4fQQJfTtEna7GxqHNOqGfj58jUgCOu6uOrAzH4FEAnEMJ18jJN Yk3fWbeMeiuStlRacVSg7Ez2EQfqbAZy8k1YUlB563a2qY4OaCwd3BDlyjTimOVYKJMJo4wiUVw ygqTE9/I1rPj5eMyYt6WZ8C5+eKcgyiHL8RCPH X-Received: by 2002:a05:6000:178b:b0:43d:78ae:b785 with SMTP id ffacd0b85a97d-43d78aeba0emr18559916f8f.21.1776254374554; Wed, 15 Apr 2026 04:59:34 -0700 (PDT) Received: from matt-Precision-5490.. ([2a09:bac6:37a8:ec8::179:23a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead402ee8sm4757070f8f.37.2026.04.15.04.59.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 04:59:33 -0700 (PDT) From: Matt Fleming To: Corey Minyard Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, kernel-team@cloudflare.com, Matt Fleming , Matt Fleming Subject: [PATCH] ipmi: Add timeout to unconditional wait in __get_device_id() Date: Wed, 15 Apr 2026 12:59:30 +0100 Message-ID: <20260415115930.3428942-1-matt@readmodwrite.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Matt Fleming When the BMC does not respond to a "Get Device ID" command, the wait_event() in __get_device_id() blocks forever in TASK_UNINTERRUPTIBLE while holding bmc->dyn_mutex. Every subsequent sysfs reader then piles up in D state. Replace with wait_event_timeout() to return -EIO after 1 second. Signed-off-by: Matt Fleming --- drivers/char/ipmi/ipmi_msghandler.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c index c41f51c82edd..efa9588e8210 100644 --- a/drivers/char/ipmi/ipmi_msghandler.c +++ b/drivers/char/ipmi/ipmi_msghandler.c @@ -2599,7 +2599,13 @@ static int __get_device_id(struct ipmi_smi *intf, struct bmc_device *bmc) if (rv) goto out_reset_handler; - wait_event(intf->waitq, bmc->dyn_id_set != 2); + if (!wait_event_timeout(intf->waitq, bmc->dyn_id_set != 2, + msecs_to_jiffies(1000))) { + dev_warn(intf->si_dev, + "Timed out waiting for get bmc device id response\n"); + rv = -EIO; + goto out_reset_handler; + } if (!bmc->dyn_id_set) { if (bmc->cc != IPMI_CC_NO_ERROR && -- 2.43.0