From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDCCF3A63FE for ; Wed, 15 Apr 2026 13:32:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776259958; cv=none; b=pwsyrpZxOBJYdDw0e2Rmiw4NLgUNQn/xJ0Mjv+i4m08VfVNnhvPNSJSaEbivrKTfDCOijFBNANQ86ZSghh/9DMohlbZ8+fvOBph70/TaTJtZR/KF1EKnSQ4g/sKIYm/eJWe35m1ACB+aF7YNC22MltbYMbsqQ6KmiYPuOMdZTvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776259958; c=relaxed/simple; bh=xrCNSwVjVDKXltckPzvEePqEXPwg9HbwfWSN/2JSW5A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UlPYYLBz4M1DHszD23e34tjI6vQMasCsHnIaOYrC7SdOTN5o+LkLagg7UdQiv5lnAsr98lhit6xW9F6qXwaDzicLyIVsZiniyX/DTSq63S9lpaQRrphzeWV28n5DC1srZ6OfPZ1hwhGgInAmtnZnudI7oLArFim3R+c2LU2r2MA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=neGjvQtV; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="neGjvQtV" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488a041eae5so50631485e9.1 for ; Wed, 15 Apr 2026 06:32:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776259954; x=1776864754; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2NmEA2H9yT1v8ldkiYgSp6xfvZWcRV5dr3KBw163IUM=; b=neGjvQtVtz/Y71A37YW0mObltfYioU9buiruoeaqosnEA40fwoy9nNOFKcYzJPlRW6 OLNzoxAwK9qliBEhZ/pDjiOQG4S7UQFSAqxz6GdI4PzKdhdYTWYXX9ZNsYHNjZerdnRN T7+oEDqx6y8RJUKto/LkqR8TLYEz3OWpJe+v4kYfneKMw21yYr2qtattLfH0o2YbbSU3 tRyVP6j7XaeSaK6TF87ufnilueQmFEASOtXB/jqb4yYWpcdpHu2SiMA2zL+MSflLFztm JIIjG7cHhjdxNIEbxsf0BzxhMaO+cSkPAzQhcD7OKf9MZK8UcWG1OO1hLMdDTEEi7ZX4 lyCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776259954; x=1776864754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2NmEA2H9yT1v8ldkiYgSp6xfvZWcRV5dr3KBw163IUM=; b=g1XMBAcIToPnseGy4UU0TKefEf/LojHeKHeuIhXovO1SG+xR+tOz/teitFCsuj2Mx7 SnOhsjFGSXgiVRkP8fLFYfK1MqoyB7pcDPLn3sHWEHabb5DzH6T4eJmWQDLVSTryi/uP 1Mnje55mh3lftjMB44JIy1FHjRjmBaCeUteOQOACejD+4Tm9mUQ9rzZLwxzHwQ2W0caz CQ7QrdBKndoqjigeYSNmFt0ZO/Ex/EQsGxmIoz0NNGMaf8qBN9J+cFP2CIUIVzahy0fv vOFJcXMrPNqsuok88Z6ZtPeNBwFJwVxJW11pIJGGSFqIbG2PB0XYOFM5AP8PgFP/UZYP njRg== X-Forwarded-Encrypted: i=1; AFNElJ+XJE9uVyuZCcByMdEj2MAY5Mq/yYXDr5A4OKZx2xAZtmvtNVtkxCFkCj7hzG2UzXI+I4DQ1t7Hel09qo8=@vger.kernel.org X-Gm-Message-State: AOJu0YxYDvv5q3HhSJyKjeQiG5/xYEf3zXtisDEiVBNMZ8LgbD8tKCvl cB2Bh9HKP9YNHJp6WdNkYnVuOtMllI6/Ck3wuUvd/CNmP91f9GdzNn4= X-Gm-Gg: AeBDiet1GPCsU8pei8QFRl+Bazqgek0zgX6pBHcJilww76wZe2Y/P2skOY6yYj43KQR KDwVsZo9yMwXzOi1zJVgzUVbxgAU/pX1vLdk25D78JBrkxuOlOhxHh5cdtENBFsRPr4wzfXtVBb qxquJe9daAbksQBN2maBN8pb/elwpYlg8G0KZqyIouWlHBxnufeb/K8bi72S9gYdOlCBZ+cXHcW bz6qXv99kkTHk6tZwKDwRMW8L8e3bqSBkjdYgyS9N0Q+QAEpMKbmKydp49OH9a+EX42wBZlyZWz pApCQ29it6/MGCRfhNvKZiEKpk2B2XcZeL36xxLuS6em1CzfiH4b5XYRQS71Hmu7YJTOUeKK7P+ 9eO2Lk8IFSlhw3PTIujPVtAEi0JKMGqfdlBXS4383NuhmR/kP4Uj5HmoAWJE7jZHTqZ9TMIpTrR SZqDrBW4Ty3c2508SnVyAerqkD3dXGrDFXwYRst6ygKSa0aS0+Q9Z7vpuSyvWNsmzoIgBX7uuMy DYJCIyNWx+ivPylldZAZ9rBCDbmh4P41qxxDNxJSwyJT+WUKwh2dA== X-Received: by 2002:a05:600c:45cf:b0:483:8062:b2f with SMTP id 5b1f17b1804b1-488d67b8dddmr283813955e9.6.1776259954109; Wed, 15 Apr 2026 06:32:34 -0700 (PDT) Received: from archtop.localdomain (92-242-248-33.broadband.mtnet.hr. [92.242.248.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0eb43f6sm20604755e9.25.2026.04.15.06.32.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 06:32:33 -0700 (PDT) From: Jakov Novak To: johannes@sipsolutions.net Cc: dcbw@redhat.com, jakovnovak30@gmail.com, kees@kernel.org, libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, linville@tuxdriver.com, mingo@kernel.org, skhan@linuxfoundation.org, swilczek.lx@gmail.com, syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com, tglx@kernel.org Subject: [PATCH v2 1/1] wifi: libertas: add wake_up() call to properly notify fw_wq during disconnect Date: Wed, 15 Apr 2026 15:31:35 +0200 Message-ID: <20260415133134.167783-3-jakovnovak30@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415133134.167783-2-jakovnovak30@gmail.com> References: <57275e905a67e789ea438bf637be0aeb442fc880.camel@sipsolutions.net> <20260415133134.167783-2-jakovnovak30@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is necessary because the thread would be stuck if the firmware is not fully loaded before the if_usb_disconnect function is called. In that case if_usb_prog_firmware would be stuck in wait_event_interruptible and lbs_remove_card would also be stuck waiting for firmware loading to be done which was the original bug reported. Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence") Reported-and-tested-by: syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c99d17aa44dbdba16ad2 Signed-off-by: Jakov Novak --- drivers/net/wireless/marvell/libertas/if_usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c index 245c902a7e42..8a6bf1365cfa 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -310,7 +310,6 @@ static void if_usb_disconnect(struct usb_interface *intf) struct lbs_private *priv = cardp->priv; cardp->surprise_removed = 1; - wake_up(&cardp->fw_wq); if (priv) { lbs_stop_card(priv); -- 2.53.0