From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 247C03B52EB for ; Wed, 15 Apr 2026 13:37:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776260233; cv=none; b=ANo6fJoDsfLgJSu0EzVsA5rfzUdb9gYV3zb13F9P71D0e48ivE76hGHd4nkUf25ABN+uCB1nwc6BHxAkjh0vZtHAeIkzSLf4MbWjTQRPJkvUq4gqQm49fgNoV+3g77ea5yNv+6O6s0+doeTwiTKMv9iIR/X7ep6qsTuErmhztnQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776260233; c=relaxed/simple; bh=ta2G6HPvMX2EUOZiP3aeStQb4RpUJwXLhxgghgaZQow=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=tUD6+fhHlz8zI3G1mP1pm54gfiUexMwiYhp0CwBlYOH2CGhXAu+cEo6VaZfqF5cnO7tzpgiU42Epj/fUz0W7+l6TYmP0z8whUZIm7Rdw723nTGtzG+SDtIc9PbQOj45ZnmRMHkB4D9mB6fe8jGZZjVwxQpNIomNkftlNxgQ/c0E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FMQcFnnv; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FMQcFnnv" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-488ba840146so67207375e9.1 for ; Wed, 15 Apr 2026 06:37:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776260230; x=1776865030; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PkSpTw5qSJfQU5L2GxzQhg4hcVT9aLbhMz1Ha6rNX4s=; b=FMQcFnnv2Beg7jZ5Y4GF+NcOJfPAqp0X1y1S01pFHVbCftwWbh1l0QtSdpQgW+7WbW eTwWecAibePE5GpmtHq7oboM1yfkSjOo3kZLI/KMQqySowXnBLIjjC9lUBB5m92PN6tw KWv93K+uP6evC/JFPMEKlteEMJWtq2rJqJsEmmyRPttHSw5SLwHTX8YmjztPiLe7QmKV OOyrQRkt3Ajh15NAgvf7HzJd7mGqygeF9GldCb36MBRzGaq6he54EItm8VxJBYWDJDKz TLkzV/N/CNemKe2FzexL31RO168UrPYmfZaGGW/uLxKkoDzv1C4PqohdnpU1off9hg5I cX+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776260230; x=1776865030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PkSpTw5qSJfQU5L2GxzQhg4hcVT9aLbhMz1Ha6rNX4s=; b=iiOpX/dRAmxjVo9uGHHOCbkNQh0PDBMta4f2yLhzupKVO9vzHG+VSmjYnZ0x9lXl7e 0/6M/t+d2IxF6BsJNcxgM4ywhxduPHeiTxkkgof8HpIuL0jdTdOnjfQzJJ3th5et6DH6 1aGoV/7myk4EDIJGHEmxZvFCwhoNEdoDEXRR/dAIX98m3GcVYR/EKuOTkwGwHth1DMoI SwPhvBEyslNOidsDKEtjq6h1P2JQ5HrC+YrfJeMZWgic0XfWN8pILqWARaDKrAPlO6bL YX5M0JK+xUawE1oHLS4O1dtOwQkywKk6DTAtc0GDrai1ti4h7dEwL327Vb3jLS+SLB0S CWog== X-Forwarded-Encrypted: i=1; AFNElJ/ABFdmIxOj4lxcW3oEmy9DkpWU8bEeWbh+PZceCzj+PO7R3K4dK+1RlOYfbQ9XBDSU9t8Cso7wmQiQc3Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyoAr122ch/xmeBUb0slLmvkB7mr/8FZakle6zxX/vHhqQiARVm arWiZ/VcBLD1Mtd9je/YnwRQ9duPLnxYJ4I5LuOfuefP2CRya4jsyGY= X-Gm-Gg: AeBDievVWxImrG+Th/eeUphF6lBo/8chVvhhmQ8sBVYFLDRir2G1d0FlwNHM1IWhcfW 1bM5QzN6cRedRteJxeMP/ynXzAfsnWJdJ8WQl4CzBEl/8wKQ+lh/heNGF0OWS8kcGLOcWtjCVbZ FuyTqjOuhMuQ+vtcxdNGTRg8Qe0uvIekIJme1As2OmmEH69H7hzeYoPY7+GujQx2HbNexsHAmh2 CRiUNnplYK4C2rmKKFzPym6jyHlFKEt5NY2RfvRvIHhGqOQqwb8mFqQkVzwj+dzrVptLIpt8YwJ Kn8TiAfn3A65K/devWZMbfPdwO6qgNW6nOmQw5OsZXlo6vBR9jD3RwIrQruaiqgmpAO6+DxL/lv /qMLwoi+Qt+9YAA2v9dv4hg3/iTpssugiozRGG3Q6NEDFyeiP7eH1MgdB1y4LxW3pWmqZw27icP cotOEYnbqS46nZc0fNIS8vAzB5Un8TieoXiGOwA1xjqXRYVJ5HlZJy4I7TUF/P8hTwmTwy5Gqfo XWmQx2MUq5WBf4OHZPEItKccKgnyxcMXf1NsBE4+zBUPRHxxOjs8w== X-Received: by 2002:a05:600c:a109:b0:488:af7f:7751 with SMTP id 5b1f17b1804b1-488d6836508mr210704565e9.15.1776260230110; Wed, 15 Apr 2026 06:37:10 -0700 (PDT) Received: from archtop.localdomain (92-242-248-33.broadband.mtnet.hr. [92.242.248.33]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f1d60ec2sm58105435e9.0.2026.04.15.06.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 06:37:09 -0700 (PDT) From: Jakov Novak To: linux-wireless@vger.kernel.org Cc: Kees Cook , Szymon Wilczek , Ingo Molnar , Johannes Berg , Thomas Gleixner , "John W . Linville" , Dan Williams , libertas-dev@lists.infradead.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, Jakov Novak , syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com Subject: [PATCH v2 1/1] wifi: libertas: add wake_up() call to properly notify fw_wq during disconnect Date: Wed, 15 Apr 2026 15:36:28 +0200 Message-ID: <20260415133626.172702-4-jakovnovak30@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260415133626.172702-2-jakovnovak30@gmail.com> References: <20260415133626.172702-2-jakovnovak30@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is necessary because the thread would be stuck if the firmware is not fully loaded before the if_usb_disconnect function is called. In that case if_usb_prog_firmware would be stuck in wait_event_interruptible and lbs_remove_card would also be stuck waiting for firmware loading to be done which was the original bug reported. Fixes: 954ee164f4f4 ("[PATCH] libertas: reorganize and simplify init sequence") Reported-and-tested-by: syzbot+c99d17aa44dbdba16ad2@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c99d17aa44dbdba16ad2 Signed-off-by: Jakov Novak --- drivers/net/wireless/marvell/libertas/if_usb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/marvell/libertas/if_usb.c b/drivers/net/wireless/marvell/libertas/if_usb.c index 245c902a7e42..8a6bf1365cfa 100644 --- a/drivers/net/wireless/marvell/libertas/if_usb.c +++ b/drivers/net/wireless/marvell/libertas/if_usb.c @@ -310,7 +310,6 @@ static void if_usb_disconnect(struct usb_interface *intf) struct lbs_private *priv = cardp->priv; cardp->surprise_removed = 1; + wake_up(&cardp->fw_wq); if (priv) { lbs_stop_card(priv); -- 2.53.0