From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f178.google.com (mail-vk1-f178.google.com [209.85.221.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8020B3264C0 for ; Wed, 15 Apr 2026 18:55:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776279343; cv=none; b=j4WQJwYFS3+04TNa2sKBf4UktA2eFMdOJHux3L6a7vDX1yaLNo/F3ojfvw6hmMAOOgsreiDswK0dMNvSVLHVJOvwnlBHI6T8qQppdKOkI/BOl9scD7ad02HGYu0r60vC426CLCPuMVgrFWzrSgVE1UDWczNK5CwTROpSseG90P0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776279343; c=relaxed/simple; bh=kee6pbbq1bKjVuBAwdRzjCmNWCqmGfS5nrlDM8rV3Cc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fSeH/pZNapH7Z0PjWoHC7ea2uZTkOYESvPxMh7eyuql7fgKKWcGVALNENn60QFhfrVy6HiStZ7TNwhB7s3poPgSUvGqR+lipAl5XBfqzDa+pbR2dG0ykv+dukk8hMU89fZUJELGW8nye0o1I0h5dqgxBbAMgCDFsH3vWKuHYVGk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nMBNwEmg; arc=none smtp.client-ip=209.85.221.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nMBNwEmg" Received: by mail-vk1-f178.google.com with SMTP id 71dfb90a1353d-56d93355337so4850701e0c.0 for ; Wed, 15 Apr 2026 11:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776279341; x=1776884141; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T+PR/aM2xSbHpLOL6UFAg/lfaAMBhnbURgd6cWiN+HY=; b=nMBNwEmgX+B6iIhJYr0vsyE/CoMMNMHVYwtdDzq3fDO+RvXJjs2+D2tJcv2nDag7RB WzZTuB3PeD6+nQYND6IhnxPQr5ewSapbLdSOI4akB1CThGbLv1yZ+aygixnHec4/0occ 9bva7s91+Pnaimy/omRLBZUH2CiBvh5KUehB41+SnYDA0yFX63gNuA4vfwrRhit1p+rO WQUHVD/twYspFjnAa2vBVq3SN76bjVFz14Mi6r8C0IR5IlMgjVKhnX6O1JG0DoSfAV5K /tJKvvRCJ5S53HV8wO5EphPB3hUoz95dh+4pZ9GD/Shd+GBV+7QKLOFkgGAg9fkH9ILC 1Pcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776279341; x=1776884141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=T+PR/aM2xSbHpLOL6UFAg/lfaAMBhnbURgd6cWiN+HY=; b=XSfUO0h3efsGC+jRLRunOwEdQrd5C/ebqw5AFb7kaSzYOt20NCQutc3Qq2gvoXTam0 nkfvBvI34wJuASi2l26TLKZKsWuntG1gxIzpIUD3k8gmrJLMMzseeCt1Rwzr7XGBmfLL qE/c/lFDHfDHkMZRlsPL6/rIUxwYMyRcrVMwfZx+mvr1UX6YalNR8+YMummB5ezzsH/U W6U/m+DSjQDLcR9MbPBH4+FN22zO0nuTR2wOegXSwp+tlVB6OP2O31NTfFl8QTsxuTku YBo4H8jsXwfhcda43hOujsYZ6UgwaO8taEvEfZOmRulVMFiASkNMb1gijJwSfeX8OzJC KcMA== X-Forwarded-Encrypted: i=1; AFNElJ84G1c3a7rTEhea+KnhxHZ8ojRSYeWxwbEpBBkr4X2hik9bccnO39kzUNJ1evsMVWTVQNRoAKTlvXyKp/4=@vger.kernel.org X-Gm-Message-State: AOJu0YzqUHmVwfRD9xBRWAbVOSB2/ksCaffGTT+3F2CH37Mb58Ezv6JR Yw+9Chj+5qXNMZ/6JPDxmoO3DDAG5ACH4SIRyQSJHPM9+tyoeyCOmBEs X-Gm-Gg: AeBDietfy3x2lE1aXQVtZm9uhz/Po7N/bABENlO1mVPQ0m49SU7LCa6rsVNDpUgIrqR 4C7fv9krPyQQqXFH0o1KJokFN70wDou8a+oByO558E/qXQu+rujXq0IAYrcMVXFy3chyBZH/W6+ dTxwoktbTEwbeiJPPTXms0ZIlVPhLUirG9KMDzraq4ET1y9XjcFzDKB38vYpakcCMg240xGi+fq YhgfrYN19TkRtTnfTuuXHtHv7PE2XFcfv0vUsYWBnldUONJRmsazgdu/xUgsDnAIpRzJubly6TS vzhlna+Uo+1VhMLNUitIEY4VylL75Kv1m5MzKKV55HLlNv31WFPxz87qTxfKh1FVw1MXMsxyimV 0ZCLKkBHywkMLPnS7Bf3/ElLGWgWRNj67znS3iRiwo0y+oeHX+p58QUJaopHdcqk5cVv8U5ONak FB1E8Hal/4Polr67XlS5HpeqXojdgQQ6xPxhYxSLjHCOWDqejztfO4 X-Received: by 2002:a05:6122:1b8c:b0:56f:1f3a:a7c8 with SMTP id 71dfb90a1353d-56f3b9eac7dmr11469912e0c.0.1776279341518; Wed, 15 Apr 2026 11:55:41 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.233]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56f89feb56esm1647484e0c.15.2026.04.15.11.55.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:55:41 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, error27@gmail.com, luka.gejak@linux.dev, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Delene Tchio Romuald Subject: [PATCH v4 2/5] staging: rtl8723bs: fix integer underflow in TKIP MIC verification Date: Wed, 15 Apr 2026 19:54:58 +0100 Message-ID: <20260415185501.440492-3-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260415185501.440492-1-delenetchior1@gmail.com> References: <20260415185501.440492-1-delenetchior1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In recvframe_chkmic(), the payload length is computed as: datalen = precvframe->u.hdr.len - prxattrib->hdrlen - prxattrib->iv_len - prxattrib->icv_len - 8; All operands are unsigned. If the receive frame is shorter than the sum of the header, IV, ICV and MIC sizes, this subtraction wraps around and datalen becomes a huge unsigned value. That value is then passed to rtw_secmicappend(), which reads past the end of the receive buffer and can leak kernel memory or trigger a crash. An attacker within WiFi radio range can exploit this by sending a crafted short TKIP-encrypted frame. No authentication is required. Validate that the frame is large enough for the TKIP MIC computation before the subtraction. Found by reviewing length arithmetic in the TKIP receive path. Not tested on hardware. Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Reviewed-by: Luka Gejak Signed-off-by: Delene Tchio Romuald --- v4: add Fixes: tag and Cc: stable (Dan Carpenter); carry Luka Gejak's Reviewed-by. v3: rebased on staging-next; sent as numbered series with proper Cc from get_maintainer.pl. v2: rebased on staging-next (v1 was based on v7.0-rc6 and did not apply). drivers/staging/rtl8723bs/core/rtw_recv.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c index a739c2bada2a1..00b69571bbb83 100644 --- a/drivers/staging/rtl8723bs/core/rtw_recv.c +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c @@ -390,6 +390,13 @@ static signed int recvframe_chkmic(struct adapter *adapter, union recv_frame *p mickey = &stainfo->dot11tkiprxmickey.skey[0]; } + /* Ensure the frame is large enough for TKIP MIC verification */ + if (precvframe->u.hdr.len <= prxattrib->hdrlen + + prxattrib->iv_len + prxattrib->icv_len + 8) { + res = _FAIL; + goto exit; + } + datalen = precvframe->u.hdr.len - prxattrib->hdrlen - prxattrib->iv_len - prxattrib->icv_len - 8;/* icv_len included the mic code */ pframe = precvframe->u.hdr.rx_data; payload = pframe + prxattrib->hdrlen + prxattrib->iv_len; -- 2.43.0