From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DE0421CC4F for ; Wed, 15 Apr 2026 18:56:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776279362; cv=none; b=sGBDD83llADaCzjecNDKEI2+uP+ZYdyjI7tNMgHmw7dHOeKoJjqDGe1wQS6867Ra2aqgcQ1wGvpejX8hl0awYzIyRqzS4uNRYivThWr9mMq358X9hzbOMGoTmd4zAJLXLsrXcLCfOI+959XgaGA2Nb5YJ3YfuUoWtmGFN1RYsJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776279362; c=relaxed/simple; bh=qDgAnsBoeU7H8hWJYwfJld1PdWPKZ6IzYlZmakmFvzo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hRRKMjXTzxT1mSRz96JaeIL0IxstQdarJHUk9AxOcAkv2BhslUkeiXHdWPmP/k8AzShiWV/p/+M9mqb9UuaeU+J6lK/KaIheDFtgYMthYhZb4iTmSjobsRU+j4MKO+wjLLAudtGxBxwVUimx8DAlRlDcCZI1gD5c/RygWKlgr/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pLlFVF+S; arc=none smtp.client-ip=209.85.221.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pLlFVF+S" Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-56adf76631cso2977890e0c.1 for ; Wed, 15 Apr 2026 11:56:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776279360; x=1776884160; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=terxqci1pBdDnjeH/sF4SrPTjsWluedBaTM7xGqnc9A=; b=pLlFVF+Sw/y4YDyLOcXP2eUxw4oOGcO6vRhjfsSquWIepcewlPV0caMqrm7Zj3DYTs Vru9q2OvUyNT/hhpytMr0gvA2JIv0EawBDftd6IslCyUMMdpuRuds7d6ApQzF2kWZ1zI MygZ4n+pCP+jM+EOzuPfsKqyrQWF3AYu5J0f3OK4UDY6AeLZD3XfVZDLrxj63/VMJIUW IIuIF4IVVoM/zTDDE0nKDq/5LBmSYGyE9E5w+hFh5sKdcjYllAZj9gugl9XD3+i1vV2Y Sv1+MANIj6wgQMJLXrfC83s35Q4Qrj6Rg45cnacurVYO6ysNSS91NOShi6Wr2+9gSHHz abgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776279360; x=1776884160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=terxqci1pBdDnjeH/sF4SrPTjsWluedBaTM7xGqnc9A=; b=laAxyNsKjFBdj7tyy0v4IaXoVUm/YaN00QGPRN0onsIoIHYsG4lnmFYQTfUHU0pt99 Tzh6PZzBago8JThKSFbSV4s1I3nXcttQINt1rB9ckGFkO8wh3xXu2TQeRmVN/uqNv3U5 KY1yoKYCsNctNRg3yFyGYxKrHDtebIBAx5o9lg0+Tqg1c+i4q0+tV8yXBd0qy1559o2r uJjRrI9vFPwQO7CE9qzStfzzNUOBZ06S9IsXv5zGRyjQYpiDdyHX6f7/XPdO+hMQ+0ct CRnkUV9BMzPnd/6PDFYbP2HUpdnk3ho8A9mKxgra3hKsVxl62sdJEN6N4PvC1HaKkXv7 m/fw== X-Forwarded-Encrypted: i=1; AFNElJ9DkXgR1DN3WpMW4oxoqW0iIM1dBtwxaCl2aRjx2iv6WBy/39OxCR157e9pu37KRP9/ZqUrXef+FRzarKI=@vger.kernel.org X-Gm-Message-State: AOJu0Yyb8iFNTxH7Gyep5t2LfUbGqQtHFOXVi8tgTpTW3d6XvlLAczw9 K3lVTqG64JBmuF9Iamj8U3IaSMZass3b/RSkLbQyWcVt4HZ9gkZoSiul X-Gm-Gg: AeBDieu0zNGhwDwi2ylH6ujWr9xfrbd1wTmRJB62+ETHwX5FyxB//zFeBY2sZ/1nSgo fAqGmOzfxsprEGE14LYlCn5WpJSpsZgkvuKTMOZPG0dl4Eg4JbZ9bs5j6ug68xbHPayEH0dbT9k 38EUbPc1JyE3M25rZowQHbcv5v1Ux2H4miB8VPBVStXIqDYZv47qEa1JNQ+6RkQJyVSk4LEaVW9 GRvoi8axGLfwjBTxdryBN7QKMYqFJt0bcpWwYv3MHJBmG34H134ysyYuxCwwIbiW+s5/LkG/gEa qNWvZ5W78eZu4VX1CPVw3JxlDweM7UYCRRBcgFvdePMLWLOnN49cIBS17N3P0r+WV/EM3t1UgTn O7U59/wFOOo/RjhM+lMIkVvDJe8Mx6u3HkO89U0mxtu3OPGtrvOjKMNAIb4iDYMl6c6FJaeMTPq QzrZ7KnDJZwWw1aujCud2gXBJNZbREDQnq5Ma3oGixqc0Ukx3hwyY1 X-Received: by 2002:a05:6122:65a1:b0:56c:d1b0:3626 with SMTP id 71dfb90a1353d-56f3bd1af66mr12017282e0c.15.1776279360273; Wed, 15 Apr 2026 11:56:00 -0700 (PDT) Received: from localhost.localdomain ([102.244.98.233]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-56f89feb56esm1647484e0c.15.2026.04.15.11.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 11:55:59 -0700 (PDT) From: Delene Tchio Romuald To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, error27@gmail.com, luka.gejak@linux.dev, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Delene Tchio Romuald Subject: [PATCH v4 5/5] staging: rtl8723bs: fix negative length in WEP decryption Date: Wed, 15 Apr 2026 19:55:01 +0100 Message-ID: <20260415185501.440492-6-delenetchior1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260415185501.440492-1-delenetchior1@gmail.com> References: <20260415185501.440492-1-delenetchior1@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In rtw_wep_decrypt(), the payload length is computed as: length = frame->len - prxattrib->hdrlen - prxattrib->iv_len; All operands are unsigned. If the frame is shorter than the sum of the header length and the IV length, this subtraction wraps around and length becomes a huge unsigned value. That value is then used to drive an arc4_crypt() call that reads and writes past the end of the receive buffer. An attacker within WiFi radio range can exploit this by sending a crafted short WEP-encrypted frame. No authentication is required. Validate that the frame is large enough to contain a WEP payload before computing length. Found by reviewing length arithmetic in the WEP decrypt path. Not tested on hardware. Fixes: 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver") Cc: stable@vger.kernel.org Reviewed-by: Luka Gejak Signed-off-by: Delene Tchio Romuald --- v4: add Fixes: tag and Cc: stable (Dan Carpenter); carry Luka Gejak's Reviewed-by. v3: rebased on staging-next; sent as numbered series with proper Cc from get_maintainer.pl. v2: rebased on staging-next (v1 was based on v7.0-rc6 and did not apply). drivers/staging/rtl8723bs/core/rtw_security.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/rtl8723bs/core/rtw_security.c b/drivers/staging/rtl8723bs/core/rtw_security.c index a00504ff29109..f3bc2240749a4 100644 --- a/drivers/staging/rtl8723bs/core/rtw_security.c +++ b/drivers/staging/rtl8723bs/core/rtw_security.c @@ -113,6 +113,12 @@ void rtw_wep_decrypt(struct adapter *padapter, u8 *precvframe) memcpy(&wepkey[0], iv, 3); /* memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[psecuritypriv->dot11PrivacyKeyIndex].skey[0], keylength); */ memcpy(&wepkey[3], &psecuritypriv->dot11DefKey[keyindex].skey[0], keylength); + + /* Ensure the frame is long enough for WEP decryption */ + if (((union recv_frame *)precvframe)->u.hdr.len <= + prxattrib->hdrlen + prxattrib->iv_len) + return; + length = ((union recv_frame *)precvframe)->u.hdr.len - prxattrib->hdrlen - prxattrib->iv_len; payload = pframe + prxattrib->iv_len + prxattrib->hdrlen; -- 2.43.0