Re: linux-next: build failure after merge of the block tree

Christoph Hellwig
2015-12-03T07:35:26Z

On Wed, Dec 02, 2015 at 02:27:40PM -0700, Jens Axboe wrote:
> On 12/02/2015 02:14 PM, Keith Busch wrote:
>> On Wed, Dec 02, 2015 at 02:07:34PM -0700, Jens Axboe wrote:
>>> Christoph, for-4.5/nvme also fails if integrity isn't enabled:
>>
>> I forgot about this since I've merged this in my repo to fix:
>>
>> https://lkml.org/lkml/2015/10/26/546
>>
>> That ok, or should we handle this differently?
>
> I think that should make it compile, but the behavior will be a bit odd. If
> you pass in meta and integrity isn't enabled, you'll get an ENOMEM error.
> That seems a bit nonsensical.
>
> We could make bio_integrity_alloc() return an error pointer. That way we
> could retain the ifdefs in the bip code, and not let it spread to drivers.

This looks reasonable to me.