From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA02E392C5F for ; Wed, 15 Apr 2026 22:23:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291816; cv=none; b=D3C87NsZ1eT5eVuRo3OtbpSGUr4WigyzTG+qP7rwuppJM5cva0Wbv0Bix+qSLKNAnB1MM//qEIMhR2Ul4b3nBcKR/ALBlZXd0cej3MunkgnqTAZv6eovsbXtLe2wMAaG7U5WJzYdJZbW1rl46Crs35lEsFX7jPdVjKrtTK0FFZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291816; c=relaxed/simple; bh=tZjNaZEXvnSFPEDZzHmrMt9aRXiBa+bJDj1WSm7wEDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DuXWtwPk8Xwcf2uUIEs1m8G4BnF9PpdiSl4lpv4K9V8kCeFrPioTbO7cFy4je9N4q+tV2y00aRWNBfTYP5DWy4oDlttCp1gLUJU+1xV1lW0tW0yCAqmEODtj1NyJhx6n0tCtZg+rqzsiOuiVtbPR7cwn0JAtef6jjyJl09K9+k8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=a0hnPQzP; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a0hnPQzP" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-488aa77a06eso119919355e9.0 for ; Wed, 15 Apr 2026 15:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291811; x=1776896611; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=58lzRs6nO9P0m/wYeIkyHuOnKofA9zauhmvpRE3UfRM=; b=a0hnPQzPtL+eQmh0IZxap92h8szglN7k2WJCGKLF+IgSPcOpSa017yE7c7CGMkdRnG +2uLMlVzZ0Ei3k1YqpGmoxEqdi+uUXSaGxrN/EKTBTGaJ+cOzMU7RJ/we6Bhordewoi9 6Tu5c8VFaLVgp4l0HuOgqEVRPptiK0R6m3Xtn089LPp5bnkFUQMsgJOdP3bIFqSp+OUK GVojr6Ug9I3YHhTdWyPfaFsNAxf814b/vpgco/fEGK0SS9xgLU5WZ5PyMEQ36FB3RKYZ V7elHzb5+hdWAy3ygt7ad1DsYd2XGQCvG/ZW06XD0Dr0uHVgHNrCeleBYQEyvs9lrxDL 01iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291811; x=1776896611; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=58lzRs6nO9P0m/wYeIkyHuOnKofA9zauhmvpRE3UfRM=; b=L9G55ND3Jtkoj+7mZnTtGPG6IArV3tT52rJ2BS36K/+qtsXq6UjhCusOgREO8FHVv9 6nXLde5LDCdiN8QtcCIBNffnBrzXJ3URIVC2v+Kz0YfqN9BHJrMpFv5uozzhLi+81/Kb zM8fViujtKxkGlU5/FN/KcP6GSLMZ/+IHUPPbOnh1Twtqkh3X2NELh0vcr5n0y9RUH5O XVCwjrVZJ8tJ7heQWO281zPi/Ad/LY+ipLwGYSe5kPqDJ2Jm/hkvunbvB2vMmDS9L4sK fepkOyhVct5jya3nxDNNoXEuUcRGBilYHsbVepjll3VYvY1A2QibgHpEpBKZyj3M8v2h OKxA== X-Forwarded-Encrypted: i=1; AFNElJ990RrVZmGd1dK5IbkiVC12IFY6gFqgmzmV6lH5oDAdZ3CzWrd6vDGxDordO5UogVTWSjWlTqFsS3AVguU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8Cs7/2dQ4PIjCXmF2givqtP6hVcqmbaZ5Mv+QfQxlxin51JZk 6PMogJOwsDapeJGMOmAYpq+Wq9Ziqe4EdZsG/Fz60N9v7NrdgyRf5Ro= X-Gm-Gg: AeBDieuC9Gs9ICCn68ZpnYinXSaMbfHdEfDzDpfl/LTpDtyERjwMiTazqJ2WRGY73Hp 3fcTZ1DMv6QSyHm7b3thiXAzUhtR3kX2Sh4Ne1FgHspKcKbCuApxmFWTpXNTCASklD3gai9ErTz N+dls0MaCOXOVq52kud+OVxxXS0uY6GOI6Cr4urrxyTThAhgY7xVMA+s6TXUMbEfJNJekhJ8Olo pXNgdnxm+wLuOaHQmBRvMC1UdZKVuK5ytk7mWKYwqjoC4xQ7Fds/GKpbyMCOwldK+L4cpkYemHo XD9MT8Sd+BC1z67FBntP+y3jbUd479fF5brRK8+6/rq3R2ephszb1CF4E2SBr2frUGYqKG8sQqd i3TUgvExzdY1proZM0UoPJidfuHB39s07sXKuh++KeAOqTvi0Oz/nzuAbXLvBybJRDNFqaSQy3c jHPE0= X-Received: by 2002:a05:600c:c117:b0:487:4eb:d125 with SMTP id 5b1f17b1804b1-488d67e370bmr223489645e9.9.1776291810987; Wed, 15 Apr 2026 15:23:30 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0eb3842sm30160995e9.24.2026.04.15.15.23.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:30 -0700 (PDT) From: Tristan Madani To: Brian Norris Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/6] wifi: mwifiex: fix OOB write from firmware queue_index in WMM status response Date: Wed, 15 Apr 2026 22:23:22 +0000 Message-ID: <20260415222327.1539269-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222327.1539269-1-tristmd@gmail.com> References: <20260415222327.1539269-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The firmware-controlled queue_index (u8) from the WMM queue status TLV is used to index the 4-entry ac_status[] array without validation. An out-of-range value causes out-of-bounds writes of three firmware- controlled bytes into adjacent struct fields. Add a bounds check before using queue_index as an array index. Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Signed-off-by: Tristan Madani --- drivers/net/wireless/marvell/mwifiex/wmm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/wmm.c b/drivers/net/wireless/marvell/mwifiex/wmm.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/marvell/mwifiex/wmm.c +++ b/drivers/net/wireless/marvell/mwifiex/wmm.c @@ -945,6 +945,11 @@ int mwifiex_ret_wmm_get_status(struct mwifiex_private *priv, tlv_wmm_qstatus->disabled); + if (tlv_wmm_qstatus->queue_index >= + IEEE80211_NUM_ACS) { + break; + } + ac_status = &priv->wmm.ac_status[tlv_wmm_qstatus-> queue_index]; ac_status->disabled = tlv_wmm_qstatus->disabled;