From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BCE3939B5 for ; Wed, 15 Apr 2026 22:23:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291815; cv=none; b=aQ24LoNarxKzL44B1FNPzWhKwSbfhR+AVX7p3fFo1txzlzXIVoxzSt7vLa80SINpsvL+kvMtq4yxvoFzY99raGq1+MYDzcH5LkpPZl1DdtDAWuQrGDmWWkjs4ZErzb5H1S3WEwba2KXuZNdXHJGxftjBqGiS7XgBPklbt8He8Yc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291815; c=relaxed/simple; bh=i+gs3uxAM4NrcK8GQGaRCurIvld3B3rpD0H0OzamVK4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EHo3APSVnEFO7BDAMS47Sn76A+KsqFhlfgUwLHq4dLgYeAJ5EaRpZT59je0ur4koLKxgA4J7dnG4mocDwERphVg+YV9tH/nlJnlPvhpA3QKFC2ut6Qx1+BO2MkALsOnzv0L9MON1WPF+tfll3UGqhFsQD0vS1l2NARuVQppcRGQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Sl97ZQUV; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Sl97ZQUV" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-488a29e6110so77759905e9.3 for ; Wed, 15 Apr 2026 15:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291812; x=1776896612; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iAMfpcCYFU/GIrIHMML7LkZ0mvmQIzFEut8whP1Vado=; b=Sl97ZQUVq0PGmZyrQAWguapjyvPt5aiNEUKP6uxg6CAr9++BNDgfBopzou/SerKqap GOMXhLf/fTTmDWqohonnh7Ci/3R80vC+MBvC9Z+MYVb8OvZjPCZT305/xD8V0I2nZWqo F+bRu7pbydJVC/1ciTbjXUq12JkqvWJVP//sciaDtNi71EpPYaPx0SSsu1h+U3cklwMH mFKcepwCciPOKYpHONrrfo6LaOlmoyKAkoOmYi0wSZS5HC6LLUFt3M1vPhDDgEFzLj4P rtZJYsQg29mLdhkj4NxHZV034eFi/r6RXD6I8px7ibxBCTOZNckWbHVOPWRG3RqjG7Ed fFdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291812; x=1776896612; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=iAMfpcCYFU/GIrIHMML7LkZ0mvmQIzFEut8whP1Vado=; b=SbFigcnzkiBi7asUo008GOu/cz+1i/14Dcit5j28CABW9FsNK9WDRTyfXw71fd+FYd 90j0Ggy0bJwk7WsM0YK+R93jwID3zgjHe1vgAkgplWo5HpxdUH1VloxYm10Cu4jE9s8U IzBt+hL0rvEB2ijHOwJ53Ihn3uvP+PUK7DDZYziXES3TWggQNEPjUCDyfNw4p2PlMVtj e/U3n5K3fShputQn5sXaemKKuy6l7eQNV3+FIFiX9bQ0q8GvGXxv/fJ3T4XqodPbDuRp wF6kTcmIwdiB05wMqwBTd5+fOs2N+fe1Rhah0k3tQTvBJxkSw8hKQsKaiuLjYGnK0uoo V5Kw== X-Forwarded-Encrypted: i=1; AFNElJ/CMWrGpA5qWGL71Q8AB/DGun1XPNhYUpMvIfWMV+DuFA2L3Yd4RehsJUx68hMRg7Vygs0223P+ck0mRvo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywjh1d378umwi/FBizVMZlghcMuNdmxnk7pm1FDMN6Ow8jdH3IX +cBvJVcuLFya4lpqK4QShJBpEF9T3BrryLsTPnub9sKnEaPI4uI3d34= X-Gm-Gg: AeBDietOXBBQk2yrMm6Wa1cRuKTBQT0P/yeVAV+fT6UCYDcD9G7sSyH+dpgmfY8ItPy ukGiLJKzTmXQ/CkDm0NO3xcLF36jQS6Zwc867ucuVHoviglU65hhl3JUbZCPsnKFTHkd6dFQNOz m3x5NMq+Lo8mGsXuX1aefRdrKRC40Dr29jlBzCUoZfOtSNv9HEXpOWNezEjnedsuiEXSL3UPbNs xLEbWurAHHIUtoP1fm0yLNNW7/NISfKoaIUe2ri3bSvq0mqDuASU9QpUVsCQGH6Y/CvsscNcXni dqS4RDR42a+vvlPfHdx+/24AsNvlNKrclBi8jDNXALtPTe1bDKwmbFeUXPPW7RKVeoCPZJHOCve T3hxyxQgH5IqKxf6q6fuAPiWXxqk9TMsGFg9prOb0HSApkfYS4DUePNH39D8iRjP28trM6AX7uf Rpezo= X-Received: by 2002:a05:600c:35c7:b0:483:64b4:79da with SMTP id 5b1f17b1804b1-488d68b27d6mr354703085e9.26.1776291811790; Wed, 15 Apr 2026 15:23:31 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0eb3842sm30160995e9.24.2026.04.15.15.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:31 -0700 (PDT) From: Tristan Madani To: Brian Norris Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/6] wifi: mwifiex: fix OOB write from firmware TID in ADDBA response handler Date: Wed, 15 Apr 2026 22:23:23 +0000 Message-ID: <20260415222327.1539269-3-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222327.1539269-1-tristmd@gmail.com> References: <20260415222327.1539269-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The TID value extracted from the Block Ack parameter set is a 4-bit field (0-15), but aggr_prio_tbl[] has only 8 entries. A TID >= 8 causes an out-of-bounds write to adjacent struct mwifiex_private fields. Add a bounds check after extracting the TID. Fixes: 5e6e3a92b9a4 ("wireless: mwifiex: initial commit for Marvell mwifiex driver") Signed-off-by: Tristan Madani --- drivers/net/wireless/marvell/mwifiex/11n.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/11n.c b/drivers/net/wireless/marvell/mwifiex/11n.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/marvell/mwifiex/11n.c +++ b/drivers/net/wireless/marvell/mwifiex/11n.c @@ -155,6 +155,11 @@ int mwifiex_ret_11n_addba_req(struct mwifiex_private *priv, tid = (block_ack_param_set & IEEE80211_ADDBA_PARAM_TID_MASK) >> BLOCKACKPARAM_TID_POS; + if (tid >= MAX_NUM_TID) { + mwifiex_dbg(priv->adapter, ERROR, + "ADDBA RSP: invalid tid %d\n", tid); + return -EINVAL; + } tid_down = mwifiex_wmm_downgrade_tid(priv, tid); ra_list = mwifiex_wmm_get_ralist_node(priv, tid_down, add_ba_rsp-> peer_mac_addr);