From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6C61364EB0 for ; Wed, 15 Apr 2026 22:23:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291822; cv=none; b=BnKaLeaOrw9zSFldPqZoaRIHLOwpS6hY70d5Eoj/bOWMc9/tagQbW/3XOfH6r6dAM65QiatNdSV2XUViMH/DMxwGk/6/S/WCoZcX6VvsoX/+bXYbOtC5i2H+AbFDarYnusCHBQSdPjZrLdKyuuOSpBeTrUwWAW4CG9hfmjbyxV4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291822; c=relaxed/simple; bh=MavtfL3xiOSiEDuui2n8xegyyd/QvogrGBdkqZOpWic=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lJI+R2B4+rWChITE1gCVrnK3l7SRNglCSjVmQkQl3G2OtjuYNwIH0l0ZaZ4XkgtycGDtZVMvIcw5ArQk819sfUT2+R9Jldow/qUPnQ0Yu6Lebq06thhWHSi19sJPSz02jCIedVU6mvqH9HFa6+WGBP/rO2nN9onSxFY7PRMxuAQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=itmYAfFv; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="itmYAfFv" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488b00ed86fso74538495e9.3 for ; Wed, 15 Apr 2026 15:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291819; x=1776896619; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sFwd+xRU79WqFGCbQieg8NXuV9zuceNYi5AxTmvFP/Y=; b=itmYAfFv6eML2Mr8Ldk3LlhaV4WDVbddf8sNUZ8e45slIgSEYtmvxPV0tN7KDbfAKk F2uhCgnb96CagjnfwMhLoINk/mcWiPnX7gqOVdFPIwi0xIGPB0QMIJhR2kSWFELUdVs/ tUh+EYHZtuVBamWZZvs1hrb08ve28nIpNs1j1iSjIeKux+M6F0GCu2VDjVWrtfBdeuib fiMkc22qJ1GPdNnZqMZwYyBb98MvlCB5wYXuGriAze3ON8K9bqaByFQycYmDfCPIbkiD +6HX9oRXuQyPKYS5Uks3TnqWY/FaOV/xVtFCEsT6s14dEb79FqcpRk9t0p5oRqeEj42d Xymg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291819; x=1776896619; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=sFwd+xRU79WqFGCbQieg8NXuV9zuceNYi5AxTmvFP/Y=; b=h3gP5lIqa1+NFFF8IDet74XG2SkKg7RAgtfcM+As0w+VbgBfyP5fLs4p51QfE67fwB WKdVONDYgp9b9X7btIKFK4tqb3qh56+PPY8arnzeBRmSpq+QpLc29y1j67fmjpTU5cf0 BdX+AaoiDONFEkx1s3IWLgIxjBS2//BzJPYP/lHRa6274HcsYKFFeaihixWcCMgLb2tr lh8TE3hQ4SXj95Ohr/jiolhPBymu1PfZDRCXsl7Ik40zWWnXWRaatxeeJfpoYhRZyq/i J/Hc13xVT5WxXJ8mwK7Y+bocdLppPpR1C8lyZcnZ401mbSvZMM2hZbKRPDvQF+1nVS8y 5lRA== X-Forwarded-Encrypted: i=1; AFNElJ+trcShj/A48iNxvdNLkQnhxLRsqfvkNNB+SiFVno1seOfTiRPCYG0kuXsiJYCmfSONadIKm07kx8LglKk=@vger.kernel.org X-Gm-Message-State: AOJu0YxXAr8YMus0aJmbTQdvbJkbcPZH6uTeES+ZMg5I8ER1W+Z4iALY PHtMvmodCsZJeHbXCGnaFlcZynmTK0aM70izLtumUjp12SG/ugyAzNY= X-Gm-Gg: AeBDievkae/8+ECjVPJmZcRGhE13uAhLzwWCRqCyW8yychMdJteL4Agt7J0j/+ybD6m P0LVU4x6Ze0MHp1wzVwM+uw/GLuNEH6/iYDXT76dlNkQxnSdlujzxeUfjpPHwAnrpR2WLSIPZRP 8H1QvrQEo7FjLLoBglzqFpnPugSElv1KDPxYqQJ2EyVRUbmWhq+aawdWsnyanj9cnaoUIdnNnNv 2lOWwu1CQ8/zl3U47jZmkC0bVUV/uQOn02UfSkqr9ApZbBtMkXApqrfl1dcBXXnUSWkxwSmH2hO bv2t3+Nu7v8hFNKmGZZXZF0vEu2Ak0ea9B6nT1zz0NaaiNPryQz1CQAiq5YXR8t1xN2OaSSXjlJ FO1zuvmD2D2uTdK4WnRNRz92nQ/mO6VJENaUEO8A05C0GiO0Bo5tPuHylQOj+VnpWrRFnD8Rfxu W22Nc= X-Received: by 2002:a05:600c:4e16:b0:488:966f:70a7 with SMTP id 5b1f17b1804b1-488d67bbc7emr340553555e9.2.1776291815250; Wed, 15 Apr 2026 15:23:35 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0eb3842sm30160995e9.24.2026.04.15.15.23.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:34 -0700 (PDT) From: Tristan Madani To: Brian Norris Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 5/6] wifi: mwifiex: fix OOB read from firmware intf_num in multichannel event Date: Wed, 15 Apr 2026 22:23:26 +0000 Message-ID: <20260415222327.1539269-6-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222327.1539269-1-tristmd@gmail.com> References: <20260415222327.1539269-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The firmware-controlled intf_num is used to iterate the flexible array bss_type_numlist[] without checking it against the TLV data length. An inflated value causes out-of-bounds reads past the TLV data. Clamp intf_num to the available TLV data. Fixes: 8d6b538a5eac ("mwifiex: handle multichannel event") Signed-off-by: Tristan Madani --- drivers/net/wireless/marvell/mwifiex/sta_event.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c @@ -450,7 +450,15 @@ void mwifiex_process_multi_chan_event(struct mwifiex_private *priv, grp_info = (struct mwifiex_ie_types_mc_group_info *)tlv; intf_num = grp_info->intf_num; + { + u16 fixed_len = sizeof(*grp_info) - + sizeof(grp_info->header); + if (tlv_len < fixed_len || + intf_num > tlv_len - fixed_len) + intf_num = 0; + } + for (i = 0; i < intf_num; i++) { bss_type = grp_info->bss_type_numlist[i] >> 4;