From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A9E2D391E74 for ; Wed, 15 Apr 2026 22:23:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291821; cv=none; b=stkjNzzkF3P1I8fB5zQnakxWZpFRurgazQg1ioLSSTKFKahnaN8aJcN1UFCoWDaCgwTRDzIo9Av6jk2r1iHDnKXmBfrN6H6kfzTSiellJoVMt45lRJ5OUogy9CzMe21MR9/deI82wQ6uiMtKBB+o30g2Lz1E4nzPTxsl+OW4Xmg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291821; c=relaxed/simple; bh=ZlZT0JJb5fcHHM0QCTIPf9Bbr5YK0JxpJ/C6fjexs+A=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kY6kcyCNsCEGK7fxF01TLscA2TiUv6BdhiIlkPkg7eoumWu9vxVBWH3MRy9Ij877Go08Dm72e9tHgBjVdXxlKlUDQFKbI7g+Z92FPKZRNKTG2M6EcfUU8dnzhZduL7C1ylxX9pjsBV783KyCYzBk+RhvOBjtfcKJJ7VgsNaeLlI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Xc0WheVI; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Xc0WheVI" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-488b8efed61so420725e9.1 for ; Wed, 15 Apr 2026 15:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291818; x=1776896618; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qDiHJtKHAA+Rixyk1EF2BIEgn7PGOoGfU+wLTucg4VI=; b=Xc0WheVIer1DxXO5yi8FT8p0uLe58wrvOIiyUhWPlxBLsIpZ3a59Ybrz9zESzGcTdH ODYA9imcpLF1fMfpa2ifeIPg65NFiAKNpnAEEDBGGhBcBf1yy7iP7fAzYTnCqhr7AnB9 BbP1Yr/xidqNpd4ZBW1pOZcZuSTYZkI5Met6LHSEYh4fbyaHWcr8Mrkmej/NIKIJU0uJ SnpaqeVbzOzS74PThGCUfyupvAk+JlLkT2avd1goMNfRJtz6b649ntKTC9s7BDHD4QcH 86a0hxiccrp4P2IeldAiwCmeazB6zOdBT2j1p8k2MRFrvSaYqxAolezYvO0XaMm2meWg TSOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291818; x=1776896618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=qDiHJtKHAA+Rixyk1EF2BIEgn7PGOoGfU+wLTucg4VI=; b=sQ278YhxLBFkDjYJGiYw5FbPcnvHPAt78IPSjZscENJOPn/yaiVR2qGWOwTC48FdY+ 8qpuGGkwpTFVFg5Qoxa82Km3XlqT/lxGl9WDoONacMOuchR1qAC36W6vrGnQcwbDHmxC fNQ46g/cxxNto/bS4szMOzv3id46siQznDD1P9jvcL4rRAebO45TU2vAB83RQ88daELZ E1V+Ta0KR9cnz76p/IXVbs2jwwsEDs2X2U6akI2QxbK5DM4awjPI9NUNyAHQaBHje4vc VqR77VbhYiuN+m3S/EHr2yxo86MXaiL1xgqsEiXK89d4Esw1/q0bFvPh7rcxqdKrmakA V1Vw== X-Forwarded-Encrypted: i=1; AFNElJ9+WyUSHCJJ8E8LXT2qwf6y3AT+tw+W8i87TWqxEdnU9nqDD1Yxat3YPVhMAhLE42KE8MzSWH2eMdB5cxY=@vger.kernel.org X-Gm-Message-State: AOJu0YwGUj4ZtARJUGRgI4EmJ8N+2JRI1bPRjvbV9Fq7L3hECrpLPwLG cqC4N9l/56qO5/2sPp29fSRvsXjDNsNE+WfWN7m+L5gMM/W1I4Ys4Ls= X-Gm-Gg: AeBDiev91sPXgp57RgMxU/LzBv5Ojxh+y7FZyEg6r0ykiz0EB129RW8e6RznQL7pCAI 5t9Y70f1nwuOcvZsdauBEEOeuP5XOcWC0xcBjKmJOrM//UFh6K6e90aipe54qw59nukyw//0yZF fYT3OzZL6LSk6tO4613tKo/a4l75IF5vDu4xIpqRQoYz0HkHCerJGnb256jNjtT3kU/u/Uaktmx FNiSPdKugJajvWSmTEuUag2xvzAV/wa6Brh8PN4TgJoLXsSvTdqvAsV9ZNnQ308A9XrW0s4j+P2 YynajTdMa1RckJFQ7TKNCfiskF1Nb6eQDmzmzOd+oVb7KjbTukbTY22IkPj15bODyymM0AJvM7o 3Nb3TykkRBihGl2rrywQQ+81RUc34WydgZO2X/nAme9YQXORh5hW9bpNX+k3ELl/sNB8RToRon6 jZ1t0= X-Received: by 2002:a05:600c:6296:b0:485:3e00:944a with SMTP id 5b1f17b1804b1-488f47f2935mr15580615e9.9.1776291818101; Wed, 15 Apr 2026 15:23:38 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f0eb3842sm30160995e9.24.2026.04.15.15.23.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:23:35 -0700 (PDT) From: Tristan Madani To: Brian Norris Cc: Johannes Berg , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 6/6] wifi: mwifiex: fix OOB read from inflated TLV length in IBSS peer event Date: Wed, 15 Apr 2026 22:23:27 +0000 Message-ID: <20260415222327.1539269-7-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222327.1539269-1-tristmd@gmail.com> References: <20260415222327.1539269-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The IBSS connected handler replaces the buffer-bounded evt_len with the firmware-controlled TLV header length. An inflated value drives the IE parsing loop past the event buffer into adjacent kernel heap memory. Cap the TLV-derived length at the remaining event data size. Fixes: 432da7d243da ("mwifiex: add HT aggregation support for adhoc mode") Signed-off-by: Tristan Madani --- drivers/net/wireless/marvell/mwifiex/sta_event.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/marvell/mwifiex/sta_event.c b/drivers/net/wireless/marvell/mwifiex/sta_event.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/marvell/mwifiex/sta_event.c +++ b/drivers/net/wireless/marvell/mwifiex/sta_event.c @@ -46,6 +46,10 @@ static int mwifiex_check_ibss_peer_capabilties(struct mwifiex_private *priv, evt_len = le16_to_cpu(tlv_mgmt_frame->header.len); curr += (sizeof(*tlv_mgmt_frame) + 12); + if (evt_len > event->len - + (curr - event->data)) + evt_len = event->len - + (curr - event->data); } else { mwifiex_dbg(priv->adapter, MSG,