From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8D5C395D9D for ; Wed, 15 Apr 2026 22:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291856; cv=none; b=i/hbL7Ck4P6UFfHDcq5vAEUCtmhp2bsuMnbUXiZw37/17Ll0lP9wQOwEz74PtTKBSZy7H8xdTWCUCxzmdnhsxq/XZzABwLHvIxhKYUDXU5DUKm0G++zF8NsPr3bkmA7Tb4nJ8Q6jOCvIEPhsoDzWie9VlwToVA1bjYDfbNFrmE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291856; c=relaxed/simple; bh=FG4ynTXsoV92GU20iHTgPOQKBDGoeebi289r44xzP20=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IpkSRq2Vzzi3NGkWnXWRxlBR5wKqiWvF3lpBGzcKf0WdQDftnL80gALTuAJZ6bTrmGpLZdZaTdn9SamO88oWrYyP4KTKQN810Bap7wh25DdUYDDyCDspKkPcxDOMfk7mlZfzaY6iKEDso5lWAD4kWMxjBUvPgvNl1R+OItYbqSc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Pjm15ymv; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pjm15ymv" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4852a9c6309so68314375e9.0 for ; Wed, 15 Apr 2026 15:24:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291852; x=1776896652; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DyhVpWUhRmCqE8V12/aslzLb+WVCcpoPPQA9jie/7lQ=; b=Pjm15ymv9vomF+TpSe6QJgz4sZ4QHWVPkSItXX95uAngoIxsHF7IT1/b11hvbsv0YC 8RDERqD06UGszFTKJCcEF58BOjzTHOItlVtoXsojHbX9NKFtSeoSY7jMuYzTvG/9ng6A svZZqiY4ZT5kPnk2EXqo7QPgvZSsHaFtIbk7ih6ChKcag7uG+8B4aQ3GOymEa3F3X20k dNAW8cDqepevQ6KbTkcYWuoM0ptwzFkpkAChrzpyJXsEWHwS5eleEz7rsxMeZfkx5tRb ZjHR/1eWTjSzWKF5gpZQQdtlWhSJY/UTXQcGXYOhbqLp+v9ZgzBz7X9zBOKfBUdwsj6a bgBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291852; x=1776896652; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DyhVpWUhRmCqE8V12/aslzLb+WVCcpoPPQA9jie/7lQ=; b=SWiEpzRdeVxsgBaM1TlgEMnCYSMhHXfYRJM5HzYjokjJYrs1XN0XaffS2MfzXm6Tod lx3qXbiLdb11qKMc7JCqsCCqRSzxN4dMxxJfVhvu2HwmoNrrQyJ189bllraCTtWTNUx6 nMtDLRP2UGiNAo559lpoHevkDGeUKm3mjrEf68F1cTF7NW5gmz4i+ZTCEhSDLhZloux1 KRRcvL+7tZtYpym+o5D1h9XgmVe65r6ZygZYCSqm4NhiULilt1Imyf+zEY4ccv8Y8sem G1ZknVOLOGooJVyyS4KqkwWhdrqZpG/vl/V+jO0NoPAs39nd70lMPRO1Y3RQA15ZJ6pZ jdtg== X-Forwarded-Encrypted: i=1; AFNElJ+wNFOy6xJirZ3ZVBm1OciAnW3ELqS5Y0neGpt68a8IB+RU6yeTXEQC8Ccx/njA7MJd+o399Dvr6YoqZ0o=@vger.kernel.org X-Gm-Message-State: AOJu0YxJmABjwru/1RvhpzhLkL2fMt9aPifbYtm/fQiSeGdoGuVR3X4J 14vg9df04hinPtSgtxBb19l+FbPnAogtAZWSJ7uTiglJ+gILTuJkIPg= X-Gm-Gg: AeBDietCtPw7U4/xU+GHBRH+ngnbXhGVi5/SVH/evh/+LxKNQA2x4pGhxTU0/Ei7a7O +7DubdP5Y92TKiT7DVedQcFB2OJNiXz23IHliYYnoCX+WPyToPkI4B6J/ZOjtvK4/jUFLGRuVs7 EIcFxSp2zrOY15Qu83fseytT9cJANICwNhWJUVzGRy7o/VATR+m1bZp98SqbTd3qt2Edrh0itxX PZopHKw+G1OfvFXjqU1sZCxXUsjFtlHD301BhwOVjHf9iGUga+aEP1n5EtwBmZrs2Fqlesv0lbm V1/NWyNo5XfHvpshjhbx8ULmi2bvcXnkMmoOIcLnOMY0FmWG1jPqrNX5KvJHkvMRiYxEfm1n6+2 DnAauHbIqu87FZHjo48yywCIK3tagFdZTOivJRzIdN5by3EGfNbe+nr4zhuhL0EUFaII/akG4eL ZdG0c= X-Received: by 2002:a05:600c:3f19:b0:485:3ff1:d5ed with SMTP id 5b1f17b1804b1-488d67bbc2amr303603745e9.1.1776291851991; Wed, 15 Apr 2026 15:24:11 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5818da1sm1932785e9.6.2026.04.15.15.24.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:24:11 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] wifi: wlcore: fix OOB read from firmware max_buff_size in logger handler Date: Wed, 15 Apr 2026 22:24:08 +0000 Message-ID: <20260415222409.1542989-3-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222409.1542989-1-tristmd@gmail.com> References: <20260415222409.1542989-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani The firmware-controlled max_buff_size field is used to compute buffer offsets in wlcore_event_fw_logger() without validation against the 4128-byte kernel allocation. An inflated value causes out-of-bounds reads from kernel heap, with the data written to the debugfs-accessible fwlog ring buffer. Cap max_buff_size at the allocation size minus the header offset. Fixes: 3719c17e1816 ("wlcore/wl18xx: fw logger over sdio") Signed-off-by: Tristan Madani --- drivers/net/wireless/ti/wlcore/event.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ti/wlcore/event.c b/drivers/net/wireless/ti/wlcore/event.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/ti/wlcore/event.c +++ b/drivers/net/wireless/ti/wlcore/event.c @@ -62,6 +62,13 @@ void wlcore_event_fw_logger(struct wl1271 *wl) if (actual_len == 0) goto free_out; + if (le32_to_cpu(fw_log.max_buff_size) > + WL18XX_LOGGER_SDIO_BUFF_MAX - WL18XX_LOGGER_BUFF_OFFSET) { + wl1271_error("fw logger: max_buff_size %u exceeds buffer\n", + le32_to_cpu(fw_log.max_buff_size)); + goto free_out; + } + /* Calculate the internal pointer to the fwlog structure */ addr_ptr = internal_fw_addrbase + addr;