From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DA7839151D for ; Wed, 15 Apr 2026 22:24:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291870; cv=none; b=TkxeYbKcCUenqvsCxJaVZHpqYdjzrSl6bV8SBWTXkCIymUepvj0GR/LUZf4xi0bpoyTzp2YQfVeEUGjiqJeBqxw6xYRwigxN+s1S30I1SHJc86Vei9MS0jQIKepBwVyX6LpvvQxr22JyUpAcyfVuQ5KI/HbevnvtL7pWvofEp/o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776291870; c=relaxed/simple; bh=OIIquYNsbpPzXIEVc0fh/EZXP+sHbiVPU7wTKYd39cE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=thUKuuS8pII9OXu6BHM62jBOlnhsdl5o1ni/UUwAekfQSsfMstAJ0qq9dLrMQ78/FSzC9piqA4M3QDz+1dNGAggW4UIaA0OdQdtWJHI9FoCclQhI9J6eZ0unV7siWLGfK2lbx57IEZD61gSba1wYmejxh87PkdYQi1mOnzuBeE8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=J9mjYANX; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="J9mjYANX" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-488a8ca4aadso86972065e9.3 for ; Wed, 15 Apr 2026 15:24:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776291868; x=1776896668; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3UvqfCfAgGuJWO3zcP6mrlM40Xh9+MbBRmx0d87Lp0E=; b=J9mjYANXC9yrDbsJxz2CrlVqx5mSCX1OdiOlq6gFk7aIYahozSw0c4ISzdaOB4fuRz WQQ4FKaZylZutNajk8XK44crqvHvExpMBqhHn42JdmM22Rndmn7HAZr9iZEf/pzcnUiy ei/7X6vlOKNbDAdw15YbI0es5Uz2YBaavhyTDyuolj3spEXl+5F70HP1xbDl87R22wIZ FjrJT0G2zaqexqPQl3tGFY4ilmSVgW2TVeoLuCDUmnYVqIGQ4y4RUbdB4CWx8SElQDV1 90EwuvEKuKLnekmcc/BZSKCBkN4Ea+QZeR0nfecPwFH+YeqJxxn6cfnm0liddyPV1fzr luIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776291868; x=1776896668; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=3UvqfCfAgGuJWO3zcP6mrlM40Xh9+MbBRmx0d87Lp0E=; b=a7JEeWlgf096tPRZRjNBy5miES689KE0QP1t+k1IDr0F/AAUTM3ryajXZDPij9VXIV Ufy4HJ0PPrlE+gtlwvk2TexUrHfOLPdXpG+psJggLodsmFgZZ/n+yaR4xZf54fjClfuV TcC2/Nbc9t6UADV+jYgOuHb8dEHBCBVuHVnfDDSbNpi9lwMeNXeQhV1v665Jcpw5cVfu AwgDhM4m5E/PIGRTelqefosL0YvvZspxUH3ICXXlL+Ebv9b0GfzbRUM0pCQLGyVKAmj5 /jsQLCp+92ekMtIgmwrvF7j5ubmnVae3NRf+FRtrBO053ZlCnVYQyivLUcNfWKECmRhy k1Cg== X-Forwarded-Encrypted: i=1; AFNElJ9tW/u07zNiSsG8fW2K3ZzFYJFY7qvN6xP0HfWbrcNcMGNXZGp1Y7RqmqnBaUeVKXpdm+ezT/SbDrSTbOQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwLSeggKYeGGqrniFYHiktI+IlX3rob9CedYFqvOr50Wd6qS2RY 0cGgW+sYqAvRjoJt0H2Quv+fx2WDbJt9SAd08d5HrS37zkflgB3BjEgVa8gm0rSACg== X-Gm-Gg: AeBDiesdhzCIu0aAZ/GLAdbI2CNAmOVozKGi874EertQWl4BRuHKJ950wIFRITPYnPo ftNapWdaBOCN0h4N8iBSF4Jg2+y/rVljtk4AhKOIycbcYDgHQzte0O3Gg26KS8cheHE598losvW 9xvTrwF0GblQNk6hl2rUp8QgUQzuTxcJsIdFu9yVFpdpYLlH8GPSEpsUAOI5KhA4wzql5jbz2wU mpfZ5CCB0ICLNGPGtP/G7LlxE8IL0XCsCLzlwma8n9PCUTZCoOxYzU9MsMM3VBeW22PrZgad0Xb Kb5JSY1tunS3O0yCV5ja7f4rkbnlhRKt6RlWuX4dL8Y5h5wzLZ/CWSP/b90Kd4opTp/MQcv3hxO aLVCbQXqTnE53RHBLMCUTIo0lo6Ia6GZQ/tTJKUxYNoNe42M5uBwfjVFAE9qrBAYYsgCtx1Y2sD 5K3+s= X-Received: by 2002:a05:600c:4504:b0:488:9db9:5235 with SMTP id 5b1f17b1804b1-488d6867c23mr319790915e9.22.1776291867682; Wed, 15 Apr 2026 15:24:27 -0700 (PDT) Received: from debian.. ([2001:41d0:303:db6b::]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f5813954sm1896615e9.3.2026.04.15.15.24.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 15:24:27 -0700 (PDT) From: Tristan Madani To: Johannes Berg Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] wifi: b43: fix infinite loop from invalid hardware DMA RX slot Date: Wed, 15 Apr 2026 22:24:24 +0000 Message-ID: <20260415222425.1544638-2-tristmd@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260415222425.1544638-1-tristmd@gmail.com> References: <20260415222425.1544638-1-tristmd@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tristan Madani b43_dma_rx() reads current_slot from hardware via get_current_rxslot(). If the value is >= ring->nr_slots, the B43_WARN_ON only warns but continues. The for loop then never terminates because next_slot() wraps modulo nr_slots and can never reach the out-of-range current_slot. Replace the B43_WARN_ON with an explicit bounds check that returns early when the hardware reports an invalid slot index. Fixes: e4d6b7951812 ("[B43]: add mac80211-based driver for modern BCM43xx devices") Signed-off-by: Tristan Madani --- drivers/net/wireless/broadcom/b43/dma.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/broadcom/b43/dma.c b/drivers/net/wireless/broadcom/b43/dma.c index XXXXXXX..XXXXXXX 100644 --- a/drivers/net/wireless/broadcom/b43/dma.c +++ b/drivers/net/wireless/broadcom/b43/dma.c @@ -1693,7 +1693,10 @@ void b43_dma_rx(struct b43_dmaring *ring) B43_WARN_ON(ring->tx); current_slot = ops->get_current_rxslot(ring); - B43_WARN_ON(!(current_slot >= 0 && current_slot < ring->nr_slots)); + if (!(current_slot >= 0 && current_slot < ring->nr_slots)) { + B43_WARN_ON(1); + return; + } slot = ring->current_slot; for (; slot != current_slot; slot = next_slot(ring, slot)) { -- 2.43.0