public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Aniket Gattani <aniketgattani@google.com>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	 "Paul E . McKenney" <paulmck@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,  Ben Segall <bsegall@google.com>,
	Josh Don <joshdon@google.com>,
	linux-kernel@vger.kernel.org,  linux-kselftest@vger.kernel.org,
	Aniket Gattani <aniketgattani@google.com>
Subject: [PATCH v2 0/2] sched/membarrier: Use per-CPU mutexes for targeted commands
Date: Wed, 15 Apr 2026 23:21:04 +0000	[thread overview]
Message-ID: <20260415232106.2803644-1-aniketgattani@google.com> (raw)

This series mitigates a severe contention issue in the membarrier system
call by replacing the global membarrier_ipi_mutex with per-CPU mutexes
for targeted expedited commands.

Problem:
Currently, MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ relies on a single
global mutex to serialize IPIs. On large systems with heavy concurrent
usage, this creates significant contention. The issue cascades into
hard lockups when combined with CFS bandwidth throttling, during which
target CPUs may have interrupts disabled for extended periods.
If membarrier is waiting on such a CPU, it holds the global mutex,
stalling all other membarrier callers system-wide.

Solution:
Patch 1 introduces membarrier_cpu_mutexes to serialize expedited commands
specifically when a target CPU is provided, isolating the lock contention
to the targeted CPU. Broadcast commands continue to use the global mutex.

Patch 2 introduces a dedicated kselftest reproducer
(membarrier_rseq_stress) to permanently test this interaction. It
aggressively hammers targeted membarrier commands within a deep,
aggressively throttled cgroup hierarchy to prove the lockup scenario
and validate the fix.

Results:
As measured by the stress test introduced in Patch 2, testing on an
AMD Turin machine with 384 CPUs (2 NUMA nodes, SMT=2) shows:

Throughput: ~200x increase in successful membarrier calls.

---
Changes in v2:
v1: https://lore.kernel.org/lkml/20260409212223.2072418-1-aniketgattani@google.com
- Use different mutex macros for global vs targeted cpu membarrier (Mathieu).
- Use (unsigned int) cpu_id >= nr_cpu_id (Peter).
- Removed #warning on unsupported architectures that causes build
failures with W=1 reported by the kernel test robot.

Aniket Gattani (2):
  sched/membarrier: Use per-CPU mutexes for targeted commands
  selftests/membarrier: Add rseq stress test for CFS throttle
    interactions

 kernel/sched/membarrier.c                     |  36 +-
 tools/testing/selftests/membarrier/Makefile   |   5 +-
 .../membarrier/membarrier_rseq_stress.c       | 951 ++++++++++++++++++
 3 files changed, 979 insertions(+), 13 deletions(-)
 create mode 100644
 tools/testing/selftests/membarrier/membarrier_rseq_stress.c

-- 
2.54.0.rc1.513.gad8abe7a5a-goog


             reply	other threads:[~2026-04-15 23:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 23:21 Aniket Gattani [this message]
2026-04-15 23:21 ` [PATCH v2 1/2] sched/membarrier: Use per-CPU mutexes for targeted commands Aniket Gattani
2026-04-28 12:48   ` Peter Zijlstra
2026-04-30  0:12     ` Aniket Gattani
2026-04-15 23:21 ` [PATCH v2 2/2] selftests/membarrier: Add rseq stress test for CFS throttle interactions Aniket Gattani
2026-04-27 20:07 ` [PATCH v2] sched/membarrier: Use per-CPU mutexes for targeted commands Aniket Gattani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260415232106.2803644-1-aniketgattani@google.com \
    --to=aniketgattani@google.com \
    --cc=bsegall@google.com \
    --cc=joshdon@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=mingo@redhat.com \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox