From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7239271464 for ; Wed, 15 Apr 2026 23:56:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776297414; cv=none; b=oEuGvl7lFeoiq5lAlRx5yIZMe+23eZ1p4q3R0uWPxcmVkL3A9bvSONJ2HlYDw4rFmp1n8xXX47XB3bOz/fEQvBFJIOc92Q6IviM2oet8JY1xd7twTMGKr6+ppzGqGiVqquwMEtpamOJ4SZeNp4E+NgroqfjDDG8+9ZzuHAE938U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776297414; c=relaxed/simple; bh=d7GQ1WjH8nSTsVz/of3VF8B6OhafBSZLrdnmdAv5ZfA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aBn7tiRNed9Fj/FSgtoQohmF56Cw6safY6gef7zieELUoHImuYPdI6zvLCWNfYuRLVCd+T3QqSM/sBTJgbaRg19ikS9pZnG+rYMZZFyIRYRdb31R7ubmnkIaJoee8u0yWGwvWy16Qq7vJb4/Gw7RcZmMiVcxuzrNlUI0J9Hl3+M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ttj/rkai; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ttj/rkai" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-35d9923eec5so4289652a91.2 for ; Wed, 15 Apr 2026 16:56:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776297413; x=1776902213; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xp8GECdo6fkmF6RF7s24GmXpqHFvjp00U23IEvlZ/4w=; b=Ttj/rkai9TzdehgkayAxhYRqkT61naWcpAyAkFtWWG1mgUhKbV0+dmAXI+WRJ2P1HI WeQ8It4Trr4gdP8lWrBsXT1ScmG4OhRfwqCKdyfcpOCz64I03us2GAfT1R2m51aIdDTr XcjM2xzNc4hq4ry4qIv8Xsu9KZyD8FYCrtxtOhHWtSZ2Z56IBoTyiVzuqo3nZjc/XKAD H0svuzwALN4yo+e/BJhR25+Ba7xSS8KNFS9qjPGfATAfqoZ44kGRrW620bOeeaLGwXQc 6mVZbx6S9B2cdQChzm1e33gKLHePSLCe3y4POK3eEJnhwilt1vGOHOQycUfgsGxmfcf9 lR9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776297413; x=1776902213; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xp8GECdo6fkmF6RF7s24GmXpqHFvjp00U23IEvlZ/4w=; b=KEwQWN04hrSOc5HQBZo/TNihvvRQObsA0l4Ih5zNm5dk8Au1KRr139GPUzGsXsEHiG ZSvh2eGJOo55QtMBSN/lJ+ubiWT+rK16gxvreQaRP9mRaeRpMc4zwBj5u3/W1tBa6lFb +O/hN/SanBSep832Q89T0KSEvycguPk7nS9p9OxgKsYg9firRBe/Qr+Stl/PLcvV1Rwm dngenb9JKQdNWFwQFi7afh4CxUm8avYwpNglfvZ43QQbxYEA8n+zbQXkAIddcCsHl8K/ rdL2nA03xHyjEob0oLmuGMewBOZyTrEnHRHi3QCe6tK8XtjQEPCvt2MJuUxPIKWu0aas Skww== X-Forwarded-Encrypted: i=1; AFNElJ97iLY+BYWII33GSo4dZG9De510O7QbKO2J4jyOio5wvWcMdBwvaqPUYvN+T0G9JfD2M7BKCa1y4dBS06E=@vger.kernel.org X-Gm-Message-State: AOJu0YzW6ly+6V8Rlun41LCWhy+98J2Bkd9H9W9y8DmliAEZHve+RYEs 9TxLB4tnrGAZzkABdpTz0sEoWlQZb1MrPx+VgV3g7qVeg50dfZAMWsTs X-Gm-Gg: AeBDievA2VLAenShjm0LPm7bsxyWM1kfkjotYi8skqlbhyRO0lbvJ5yRXButwKWD9je jZATbAwSm1hDUl1fPKvF7WFgD/fDKVEoNiGeoNIWzobmhboRPoh3CJKm+I2goHlk/2c8tmM6ZMc rzuiMnKwc1Jm5vUqTY0EzMWkLquNZtQSAnfa3ePZUdSFXOy6N0p+GYkNRFddvZrZOIiIRyb8vWw J0UDUDYf9l1ZYrWZGF9sbF3rZNlZKScYX1LLyXbLKH+xMrRZrSDU1zXFyjGEk0BS+a6QCmgy40L HBfBO3tLxlZNktb5GyBUoT2k70IGrgC5zI6Ek3xRcEt06i1QhGJfPZ/GY4dN+6M960bD2k1jvMf jx+Gs844rq3bfwq9eiSojELI7ng/1XnBO6XZb1UeJZpk15po98Wv2116AOvt9m1fREuYa9o6+d2 8G/OcfijrvIHvBg7w8Z6AwbP8rlRbAijmO4Vj2FyTjDRcWiujmOEzmAAz2DIj828Pi674vNwHE8 PiIAgRLC553RWIrmk6EEhcecL7qGKFvzff0+c7/Qnafg1imw/FJ4zD7xBWj X-Received: by 2002:a17:90b:3bcc:b0:35f:b64f:bf99 with SMTP id 98e67ed59e1d1-35fb64fc0eemr13681551a91.29.1776297412829; Wed, 15 Apr 2026 16:56:52 -0700 (PDT) Received: from cmpatel-home.hsd1.or.comcast.net ([2601:1c0:5780:9200:39c1:ccbd:b65d:ad33]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79581c3f7fsm2994678a12.26.2026.04.15.16.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 16:56:52 -0700 (PDT) From: Chintan Patel To: sumit.semwal@linaro.org, neil.armstrong@linaro.org Cc: dianders@chromium.org, jesszhan0024@gmail.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Chintan Patel Subject: [PATCH] drm/panel: novatek-nt36672a: Inline command sequences Date: Wed, 15 Apr 2026 16:56:08 -0700 Message-ID: <20260415235608.8138-1-chintanlike@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Inline the command sequences and remove the nt36672a_send_cmds() helper. Small wrapper helpers around mipi_dsi_dcs_write_buffer_multi() are discouraged as they add indirection without improving readability and can increase code size. Signed-off-by: Chintan Patel --- .../gpu/drm/panel/panel-novatek-nt36672a.c | 36 +++++++++---------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c index 7e8b5e059575..2f75200806dd 100644 --- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c +++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c @@ -79,19 +79,6 @@ static inline struct nt36672a_panel *to_nt36672a_panel(struct drm_panel *panel) return container_of(panel, struct nt36672a_panel, base); } -static void nt36672a_send_cmds(struct mipi_dsi_multi_context *dsi_ctx, - const struct nt36672a_panel_cmd *cmds, int num) -{ - unsigned int i; - - for (i = 0; i < num; i++) { - const struct nt36672a_panel_cmd *cmd = &cmds[i]; - - /* cmd->data[0] is the DCS command, cmd->data[1] is the parameter */ - mipi_dsi_dcs_write_buffer_multi(dsi_ctx, cmd->data, sizeof(cmd->data)); - } -} - static void nt36672a_panel_power_off(struct drm_panel *panel) { struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); @@ -108,10 +95,14 @@ static int nt36672a_panel_unprepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); struct mipi_dsi_multi_context dsi_ctx = { .dsi = pinfo->link }; + unsigned int i; /* send off cmds */ - nt36672a_send_cmds(&dsi_ctx, pinfo->desc->off_cmds, - pinfo->desc->num_off_cmds); + for (i = 0; i < pinfo->desc->num_off_cmds; i++) { + const struct nt36672a_panel_cmd *cmd = &pinfo->desc->off_cmds[i]; + + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, (const u8 *)cmd->data, sizeof(cmd->data)); + } /* Reset error to continue with display off even if send_cmds failed */ dsi_ctx.accum_err = 0; @@ -158,12 +149,16 @@ static int nt36672a_panel_prepare(struct drm_panel *panel) { struct nt36672a_panel *pinfo = to_nt36672a_panel(panel); struct mipi_dsi_multi_context dsi_ctx = { .dsi = pinfo->link }; + unsigned int i; dsi_ctx.accum_err = nt36672a_panel_power_on(pinfo); /* send first part of init cmds */ - nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_1, - pinfo->desc->num_on_cmds_1); + for (i = 0; i < pinfo->desc->num_on_cmds_1; i++) { + const struct nt36672a_panel_cmd *cmd = &pinfo->desc->on_cmds_1[i]; + + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, (const u8 *)cmd->data, sizeof(cmd->data)); + } mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); @@ -173,8 +168,11 @@ static int nt36672a_panel_prepare(struct drm_panel *panel) mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); /* Send rest of the init cmds */ - nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_2, - pinfo->desc->num_on_cmds_2); + for (i = 0; i < pinfo->desc->num_on_cmds_2; i++) { + const struct nt36672a_panel_cmd *cmd = &pinfo->desc->on_cmds_2[i]; + + mipi_dsi_dcs_write_buffer_multi(&dsi_ctx, (const u8 *)cmd->data, sizeof(cmd->data)); + } mipi_dsi_msleep(&dsi_ctx, 120); -- 2.43.0