From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f74.google.com (mail-ed1-f74.google.com [209.85.208.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929CF383C71 for ; Thu, 16 Apr 2026 13:11:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776345065; cv=none; b=f5L4whOb8hO5bIg8GOsbWo4wPJPodxxhJYUoTsEA5kBRxXkgLZlBEKyqEgF9fJVgRmS4V2DXzfcx/I46+NjMPQtfsryusDofBuBx2S5f371cUIEvaV6znHxwj6E6YnYBMgpBzquLK4oX+V83gio8/loMimeG6k9uAqDhIISqwN4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776345065; c=relaxed/simple; bh=+dm7UyoEuSxHlCr4Mbc3ZnFCws67YLpeI9cD1NZKHqk=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=gvodplrefwvvQLTT1Fg6NMFmf9FzeN+0hntZ1FzLXfm0F6MF4wk8kC3ulLCr4hRAUhDyuNC7PMNRjmqHN3jXO1r/CuiQnBG79bYhfhc7NWD0BRZqFDZ+pSDTD6JZxkc16edIN89BudH0l8k5QjNbTkjVjKNnhocsaSELXlvvCrc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=nEuIFkmD; arc=none smtp.client-ip=209.85.208.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nEuIFkmD" Received: by mail-ed1-f74.google.com with SMTP id 4fb4d7f45d1cf-6729caff479so310265a12.2 for ; Thu, 16 Apr 2026 06:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1776345062; x=1776949862; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=D7qXRwsXJvN8ufnn9njyPtO9j+lMCL1yKcL7xg6ZmLM=; b=nEuIFkmDUKPgfNt/odXS3CINMqI+uqJUcNqD0q7BD3RNtLqOiLOHRCtFuFkdRPTFd9 wbT4uIll3ImafDF0BBPEGK1UPH71QGkMFyP9f3Ipri4hB0bB8+VmleOBNFweadMWWp3T m2dQta7nT4FYtvwgvV+2zsfIwsfEjrtDjevyBGCt5jEvfva5hTUvUzbTh6Fr1ytAz5zc qq9A5tGxkJy9YYt7iApkeYK9uyTCAHUa8eTwTBqSddT0yDfpokqj9JZFSjcsz9W/MMNi jHjrvtUrEIwON+xJZUKBgbaJE8QDBFL6pKPttwv/dUtgcEz3IarKbzbUsU17Y04ej6t8 R9Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776345062; x=1776949862; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=D7qXRwsXJvN8ufnn9njyPtO9j+lMCL1yKcL7xg6ZmLM=; b=Pb61CJ033FeOKznf7+wRr/wKe8ifxwGSeNrY9HQNJ+5Fnk5Mbt8CVjcC3x5Cf6zJ46 KknO3ei7bszwsZRqJe+riOH1R4XZlNljb4mQPLse+VDmeA4yHGkoeVNvfngGPAbCZH5W jdf7W1jvbImANULP7VuypE/CngnKB6OJO2HvOKrrZm9DFESf/QUoInNaO5iHiaDRcYwB DYH5PiUd2xlz3l5NOlxR9cp76UzHHsOe6CzuHhLduj9FerGW2G2SnOOo83z0NFa+PzDg iJ2PIMB5J29w0FN7LzzU3hAK8crT0ZH5qSR6Vb9ISFWIpz4KN5mmV8uVeT7wl2g9hYni CCXQ== X-Forwarded-Encrypted: i=1; AFNElJ+F1weEV8mxNODzhaa4qr28sjnzePxiHa5+LNIHmeVhbtfzebgifXvTCbILzK1DbBFD0rfoJg5Hy+V8F9M=@vger.kernel.org X-Gm-Message-State: AOJu0YxpLjpEIeXjZ1ziPkmF5pvnHMfuBJsG4HTVi4ikcxvjC8moXpSp VS4S2ukwb1Wa4vyMU83cORolhcFnloFg4BPG1tRELW6i/RIJxjzOcTOos//stRNY/pOxkrEx+9a wrMatBqC1yUz8vJ+gOA== X-Received: from edt22.prod.google.com ([2002:a05:6402:4556:b0:671:8f2d:68d]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:4510:b0:672:4262:3cdd with SMTP id 4fb4d7f45d1cf-67242623df1mr3231133a12.12.1776345061359; Thu, 16 Apr 2026 06:11:01 -0700 (PDT) Date: Thu, 16 Apr 2026 13:10:54 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAN3f4GkC/x2MywqAIBAAf0X23II9yX4lOpRutodKtCSQ/j3pM Ic5zCQI5JkCDCKBp8iBzyNLWQjQ23xYQjbZoZJVJ5uyQ+vuuKPxGYpo6cLWkOmVrtWy1JA752n l53+O0/t+B3D3v2MAAAA= X-Change-Id: 20260416-gpuvm-drm-dev-get-5ded89c39bb3 X-Developer-Key: i=aliceryhl@google.com; a=openpgp; fpr=49F6C1FAA74960F43A5B86A1EE7A392FDE96209F X-Developer-Signature: v=1; a=openpgp-sha256; l=1535; i=aliceryhl@google.com; h=from:subject:message-id; bh=+dm7UyoEuSxHlCr4Mbc3ZnFCws67YLpeI9cD1NZKHqk=; b=owEBbQKS/ZANAwAKAQRYvu5YxjlGAcsmYgBp4N/fbYNbhw/XMUDetKMqTT1tjMYbJ1AH8eui/ A5xEHBy5nCJAjMEAAEKAB0WIQSDkqKUTWQHCvFIvbIEWL7uWMY5RgUCaeDf3wAKCRAEWL7uWMY5 Rhj1EACGEo+zGQ8Yg6kj1/JEI1PrXF0W/R54VbbHRzBUPHtfQ8idvnLilchvFlSP81seiSXasnl UiPzfmvMBQ2bkrFoHBupqI6SGFnHXJAf3wbRu2NolrzAt+GWDo5y/4a7cFzgEz1/PuzsWY+mDrC JWbdecJMBwGciemxRuP/7MEo1ZXeZzd9Z2WfpbJ4dsWx/jsVTdsqdRG7TZ0nQLrrdcSdAa7vdhG hEEi0iPZm8/7I1bmcKY0uGtGKWs4u/XiToOAgHkQm0WfFtERK7GQ8KGRBz2bXG5zkx9UUAezGOD 00jE66lSEp25xmpHvULZAMsG+sBF7DK2r7lLOQvjFWIe5nhGszO+kAQAT5wCwDqmfNiQmQqWmSw +qfvtRDjfjXzEutCfgxfjAZ/uONNGovkXrlfYsOzYZ0KDdEx+HPEYewaZ4W5MC0o9SedC/uAUM1 ozqHRpMcCLyOZ21aXPbpwaX0LgyP1PHWOWqE08IHWxBstGVTzZXfx3b/a0SDKzE+uS2LED3EmGL OncNyIW18VPeeW5hKYDOCVsc3M6VcGVPbW5mZQF4MllcC7bZTH9+kj67vWY3Knpu5Z5K2JVc1OI cFGJzFnIIV53ynQbhdBbShar/rFob4V0DDWWD5Tz6sd6pJfSq4jxRvMh8XkbGAjcR/XZe+F9Yqc a1n6UaW8qScGcyA== X-Mailer: b4 0.14.3 Message-ID: <20260416-gpuvm-drm-dev-get-v1-1-f3bc06571e73@google.com> Subject: [PATCH] drm/gpuvm: take refcount on DRM device From: Alice Ryhl To: Danilo Krummrich , Matthew Brost , "=?utf-8?q?Thomas_Hellstr=C3=B6m?=" Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alice Ryhl Content-Type: text/plain; charset="utf-8" Currently GPUVM relies on the owner implicitly holding a refcount to the drm device, and it does not implicitly take a refcount on the drm device. This design is error-prone, so take a refcount on the device. Suggested-by: Danilo Krummrich Signed-off-by: Alice Ryhl --- drivers/gpu/drm/drm_gpuvm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_gpuvm.c b/drivers/gpu/drm/drm_gpuvm.c index 44acfe4120d2..000e7910a899 100644 --- a/drivers/gpu/drm/drm_gpuvm.c +++ b/drivers/gpu/drm/drm_gpuvm.c @@ -25,6 +25,7 @@ * */ +#include #include #include @@ -1117,6 +1118,7 @@ drm_gpuvm_init(struct drm_gpuvm *gpuvm, const char *name, gpuvm->drm = drm; gpuvm->r_obj = r_obj; + drm_dev_get(drm); drm_gem_object_get(r_obj); drm_gpuvm_warn_check_overflow(gpuvm, start_offset, range); @@ -1160,13 +1162,15 @@ static void drm_gpuvm_free(struct kref *kref) { struct drm_gpuvm *gpuvm = container_of(kref, struct drm_gpuvm, kref); + struct drm_device *drm = gpuvm->drm; drm_gpuvm_fini(gpuvm); - if (drm_WARN_ON(gpuvm->drm, !gpuvm->ops->vm_free)) + if (drm_WARN_ON(drm, !gpuvm->ops->vm_free)) return; gpuvm->ops->vm_free(gpuvm); + drm_dev_put(drm); } /** --- base-commit: 126c50bc2fb6ddfe5b7718de67bbd7592a1062bb change-id: 20260416-gpuvm-drm-dev-get-5ded89c39bb3 Best regards, -- Alice Ryhl