From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C89BC8EB for ; Thu, 16 Apr 2026 00:11:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776298286; cv=none; b=gKaT402gOywTbovu8tN0rStb7qqL76mppn0HfZLSp4KgZem6Yq9HEPBcgxKG5bIFZRGbams1I5aLiHVvKVeqntO8f2zHFqrCpy49dHs3uvG3zS9PSLSem3Y/cn3KsEblKiZMeEIJoNl9pn0hS6j86sFx1GFa4APmomXjPP5k6fY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776298286; c=relaxed/simple; bh=feXCvwpsEEjpTwhvns9yVw6ARPELKAJq+J9FkdOVR+U=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qgbjtDzuj4Msv3W3vsNLLeBhK0zRbRq7mhZu6MxkNKG5/Y3gpxWjol5kMXOMRR2g/4DejRfl4BOEW6GB9qsTCTlx7+EaNkXvCkXLppNW44sjtfx7S0H+NVHekTZKoJfSYESHIpO+NCuZe7Q7REbCwnv+nwAFKdRxoYW0wzRKpQ0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=DZwDNlzO; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="DZwDNlzO" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-8d6d5e45c43so896000985a.3 for ; Wed, 15 Apr 2026 17:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1776298283; x=1776903083; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7yw2kAdSjJZX4ssR5Exz+4kJYfDN2ANXckXMlNb6VVo=; b=DZwDNlzOBCIZxo76y+pz54HnEuG41tgrg3g/tbHaZt5D6eKP9Oy/6l1/xjWJEB+QfX hCwmq5N03ylnnTY20wUFEf/9OUj7HIWAZwkxtr/W9Q+Sbj+i0//Sw/tBywi08nkdCH9E 3FnH1S/f9cKRcNlvmmAjEbDS6+SwOhqemoStJ6j+73UtO7gQPksC5pAFafavAX/PfWL0 m04W4eWteb3arpuflBTVnQ8NgtNFXtDa90/CiivoCHqxy3+qoLyOMd7ul6DyrxFNSi3l avDPY3AXwJYPOdamLZRwVld/vZiz7nePDdxsGRwB3cMoB0g41zK4zxbLpbOPC9/+NiBi hpvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776298283; x=1776903083; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7yw2kAdSjJZX4ssR5Exz+4kJYfDN2ANXckXMlNb6VVo=; b=JA1fHLdioM++sGbdmIlddk5f19+AXrikQrxsyI/VK8uDnNm3j2E2zBzMEQPefAvby9 wYHTqRuHUZrp7RTcIt18iTw8VfIIfafyz7R5t2z5y8060k2Pe9CqefJoZS8H2AAy3Bxn ZaL0xLZghFn083Ol43ilWS0hBFOchCeEFkh286swnxK4x9adRxu0mP3S4Rey3fthco9b qL7T3SlbhU6pmykP+bVH06ZMnC01EGj752R2Ef4r13HfOz2A6DqyQl/+ubBkrmxOrWEo +jyIH1WuJUPgmnIUFn/KEWO9SKNQg5lRxIICFd2sYot0UJSbi09JQkaQVRf8JzHwaHb/ 8wIw== X-Forwarded-Encrypted: i=1; AFNElJ/Wq2/If1I3hqRVQA2whoxMYyAGnmQ2B/AtjmR+HyfvTXg0Oxl2VL/c8ROpjtTSBrOR9e5MxTHqh8sh27s=@vger.kernel.org X-Gm-Message-State: AOJu0Yye39BE1H/8NLpfGsBbyig4MHVmGlaBS5xRBJBupclLOcSoFC2z E3KTsSozdwPO4kVwGVGDiMBxwyAdxt4bVqZrJRa38gVkuG91MyXrQXI41hzGl1qUpGw= X-Gm-Gg: AeBDiesf8QYaukZZXeT4YBE2uKOdAWFAfyuozdsDLB5a0+U/aI3zCnI//1M6hWjXFkp D1Z5UhyEk1vnWOShItYtOIO1GM3aBuoHlW8pIr702qsS3J1QzNcvNAYhx38DTITz6PBFIpepuzJ xhuLP2XEot4TCH5j3SLFmhk51P3GvNjsKzILscX3WWnKR9eVRbCL1MKGrvOMQdhaH5Cut+pZDl4 zL6SkWgM+bcXaGDV3wZrzaxp3h6S7qrhsXOzr7FM9gMgc22eAp3ffXB61DkKwGGosdem26DIXmE zjZufopcIv3q05xCsFlmHDSpy3hnZDxvbsef+cBBAFfqREJOZlTd1LzlnOqvCggFfMJwIDNOCN6 kZip2P5hagW0ACOiCfca/8onLdQbe1z4l6Yo2fh7M2+w8CDe5eoZSapjofEqc4adnJoENpLKEnR RDo8mkyGbsr890Wn0QeN0CUbsyO/tVZHx5q/ifnZtKWChwmGSFIVzZwo3uViNF4wU7od1OW2qtN 3nKvw== X-Received: by 2002:a05:620a:298e:b0:8cd:8f18:d1c0 with SMTP id af79cd13be357-8ddce2c8436mr3332825985a.27.1776298283348; Wed, 15 Apr 2026 17:11:23 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8e4f2345c2esm244820785a.26.2026.04.15.17.11.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 17:11:22 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wDAKI-00000003CNF-06a5; Wed, 15 Apr 2026 21:11:22 -0300 Date: Wed, 15 Apr 2026 21:11:22 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org, robin.murphy@arm.com, m.szyprowski@samsung.com, will@kernel.org, maz@kernel.org, suzuki.poulose@arm.com, catalin.marinas@arm.com, jiri@resnulli.us, aneesh.kumar@kernel.org Subject: Re: [RFC PATCH v3 2/5] dma-mapping: Move encryption in __dma_direct_free_pages() Message-ID: <20260416001122.GI2577880@ziepe.ca> References: <20260408194750.2280873-1-smostafa@google.com> <20260408194750.2280873-3-smostafa@google.com> <20260410174553.GD2551565@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Apr 15, 2026 at 08:49:08PM +0000, Mostafa Saleh wrote: > On Fri, Apr 10, 2026 at 02:45:53PM -0300, Jason Gunthorpe wrote: > > On Wed, Apr 08, 2026 at 07:47:39PM +0000, Mostafa Saleh wrote: > > > In the next patches, we will need to avoid encrypting memory allocated > > > from SWIOTLB, so instead of calling dma_set_encrypted() before > > > __dma_direct_free_pages(), call it inside, conditional on the memory > > > state passed to the function. > > > > > > Signed-off-by: Mostafa Saleh > > > --- > > > kernel/dma/direct.c | 22 +++++++++++----------- > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c > > > index 6efb5973fbd3..ce74f213ec40 100644 > > > --- a/kernel/dma/direct.c > > > +++ b/kernel/dma/direct.c > > > @@ -97,8 +97,11 @@ static int dma_set_encrypted(struct device *dev, void *vaddr, size_t size) > > > } > > > > > > static void __dma_direct_free_pages(struct device *dev, struct page *page, > > > - size_t size) > > > + size_t size, bool encrypt) > > > { > > > > This feels like it would be nicer if it could be the > > swiotlb_page_state instead of a bool, maybe the enum needs a different > > name. > > I am not sure I get this, at this point the swiotlb stuff is not > introduced yet, Just that using bool as a function argument for a flag is often frowned on, and you already have an enum encoding the same flag state. Jason