Re: [PATCHES 0/5 v2] More perf.data header validation

Arnaldo Carvalho de Melo
2026-04-16T15:28:31Z

On Thu, Apr 16, 2026 at 02:17:37PM +0100, James Clark wrote:
> On 16/04/2026 01:14, Arnaldo Carvalho de Melo wrote:
> > Hi,
> >
> > This is picking up from what was reported in the previous
> > series, pre-existing lack of perf.data file validation, processing files
> > and buffers in header.c in a similar fashion.
> >
> > There is more to process in the trace data, but that is a
> > different can of worms that needs to be dealt with in a similar,
> > upcoming patch series,
> >
> > This is probably 7.2 material, but if feeling this can still
> > sneak into 7.1, feel free to do it :-)
> >
> > Now lets see what Sashiko discovers while I still don't have it
> > running locally right after Claude, before submitting it publicly, which
> > will soon happen :-)
> >
> > - Arnaldo
> >
> > v2: Addressed sashiko comments, adding a patch to the series.
> >
> > Arnaldo Carvalho de Melo (5):
> > perf header: Add section bounds checking to the fd read path
> > perf header: Validate string length before allocating in do_read_string()
> > perf header: Sanity check HEADER_EVENT_DESC
> > perf header: Validate bitmap size before allocating in do_read_bitmap()
> > perf header: Fix 32-bit incompatibility in bitmap serialization
> >
> > tools/perf/util/header.c | 57 +++++++++++++++++++++++++++++++++-------
> > 1 file changed, 48 insertions(+), 9 deletions(-)
> >
>
> Reviewed-by: James Clark <james.clark@linaro.org>

Thanks! I'm replying with a few new fixes and will tentatively keep your
Reviewed-by, please check when it get to the mailing list.

I also made sure it ran checkpatch and fixed the two minor issues it
noticed: order of tags and replacing a Link: after a Reported-by with a
Closes:, also reduced the length of a subject line.

- Arnaldo