From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from r3-11.sinamail.sina.com.cn (r3-11.sinamail.sina.com.cn [202.108.3.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 934FD1397 for ; Thu, 16 Apr 2026 00:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.108.3.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776300299; cv=none; b=hgirWOUzqxziZjkT4ZEr51PXa7sSX1XdPVpoXrw8Ft/BUHnsJ8N6Y5abns0widzJ+9kw0G4J1Ja6Ar6aj2fyEP1HA/kpd79OLRyyi8RQhKbnXIZ+KTBLRYiEKC2IcrTsVYk2cxkm2TR4O0Gkk/Aq41s4EA3silAfoxPrFhQ00uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776300299; c=relaxed/simple; bh=gtImGbd6kB2UpPMj8I6ENlX6IHGH1FrRG4fudAxUjPg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f8C6kzWv2qNjUc0E1DlNgd8pK9YHJwWFmZYBqUv6N38bby0Y6F+kNZS9FGr86/HJCbkiKcbJrnj+jGLFEaApZz9TA1OMsJOWOmvUhI4jO2qLpXIJ2PJRmPhXiXC9xMHiBLBcsdXJPMIJbcHc5zpxf4rW3+1LMdx8hDiDQhOaDxc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com; spf=pass smtp.mailfrom=sina.com; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b=PiouZ9+U; arc=none smtp.client-ip=202.108.3.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sina.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=sina.com header.i=@sina.com header.b="PiouZ9+U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sina.com; s=201208; t=1776300294; bh=E1txIZr58zzYgNoWvZKuuN875UTz5eOAkiVU63Qkxc8=; h=From:Subject:Date:Message-ID; b=PiouZ9+UZIUNGWY0Us27Q/YbqbUjidLmMZtgdti9jlOP2wnjCbFCB06jg/cpgMLu/ b/sGSqX3a1QGz7S6LzoRvYlpdSj5S2870fcFZmp8ELlG2jdil4PAXYOrHrfmgISm6k gdkvE9WNh8zJrD48Gco6AhKDRGSpVmAT4GN1tcdo= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([114.249.62.144]) by sina.com (10.54.253.34) with ESMTP id 69E030FA000028E9; Thu, 16 Apr 2026 08:44:45 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com Authentication-Results: sina.com; spf=none smtp.mailfrom=hdanton@sina.com; dkim=none header.i=none; dmarc=none action=none header.from=hdanton@sina.com X-SMAIL-MID: 1623376291984 X-SMAIL-UIID: 6F961DE8BF964A2FB03635CE3046311F-20260416-084445-1 From: Hillf Danton To: syzbot Cc: linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [dri?] KASAN: slab-use-after-free Read in drm_gem_object_release_handle Date: Thu, 16 Apr 2026 08:44:15 +0800 Message-ID: <20260416004433.1922-1-hdanton@sina.com> In-Reply-To: <69dd24f4.a00a0220.468cb.004a.GAE@google.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit > Date: Mon, 13 Apr 2026 10:16:36 -0700 [thread overview] > Hello, > > syzbot found the following issue on: > > HEAD commit: f5459048c38a Merge tag 'i2c-for-7.0-final' of git://git.ke.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1028d106580000 > kernel config: https://syzkaller.appspot.com/x/.config?x=6754c86e8d9e4c91 > dashboard link: https://syzkaller.appspot.com/bug?extid=b2e951687503f32f74ce > compiler: Debian clang version 21.1.8 (++20251221033036+2078da43e25a-1~exp1~20251221153213.50), Debian LLD 21.1.8 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=1428d106580000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=17509036580000 #syz test --- x/drivers/gpu/drm/drm_gem.c +++ y/drivers/gpu/drm/drm_gem.c @@ -401,22 +401,20 @@ drm_gem_handle_delete(struct drm_file *f { struct drm_gem_object *obj; + mutex_lock(&filp->prime.lock); spin_lock(&filp->table_lock); /* Check if we currently have a reference on the object */ - obj = idr_replace(&filp->object_idr, NULL, handle); + obj = idr_find(&filp->object_idr, handle); + idr_remove(&filp->object_idr, handle); spin_unlock(&filp->table_lock); + mutex_unlock(&filp->prime.lock); + if (IS_ERR_OR_NULL(obj)) return -EINVAL; - /* Release driver's reference and decrement refcount. */ drm_gem_object_release_handle(handle, obj, filp); - /* And finally make the handle available for future allocations. */ - spin_lock(&filp->table_lock); - idr_remove(&filp->object_idr, handle); - spin_unlock(&filp->table_lock); - return 0; } EXPORT_SYMBOL(drm_gem_handle_delete); @@ -1085,8 +1083,22 @@ drm_gem_open(struct drm_device *dev, str void drm_gem_release(struct drm_device *dev, struct drm_file *file_private) { - idr_for_each(&file_private->object_idr, - &drm_gem_object_release_handle, file_private); + struct drm_gem_object *obj; + int id; + + for (;;) { + id = 0; + mutex_lock(&file_private->prime.lock); + spin_lock(&file_private->table_lock); + obj = idr_get_next(&file_private->object_idr, &id); + if (obj) + idr_remove(&file_private->object_idr, id); + spin_unlock(&file_private->table_lock); + mutex_unlock(&file_private->prime.lock); + if (!obj) + break; + drm_gem_object_release_handle(id, obj, file_private); + } idr_destroy(&file_private->object_idr); } --