From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEF9C1EEA3C for ; Thu, 16 Apr 2026 02:23:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776306237; cv=none; b=IqETSn0268pAxZw2rUppj5olUojyUYViPFitSF21hX3aE52cTxVCqLHMpsRd5QhgrG+76KVrmdlNyqi4a+I1Pw2ydqgGDXU2/7j599FK2DCJYeK3Rqj617mkOvP2LCfyAkvD5ZEZIw1HS7kQdbTadUtJ6o3U9NRkCa7+nRF5AuY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776306237; c=relaxed/simple; bh=9gjM/1PdyD2cJUKDV35iEuRTE7w6fs0AZ6UNWgYMj6g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DNs4TynnaoltmZx1HNQ118EdHNc55OR3EYEL6zTfOLQ4BGhCoYOQTeymZcH+VBYkfB0jyfxoFgULzPubinKOqiSPNaiLn/qRTJ8BNrHgZDAg/NF1OvkhFu4ynsfCpgrkaXSMyG+3StaYfM1rPDwxDYOJSBJg/jyyB6EGyYHjURQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FulK3Pa8; arc=none smtp.client-ip=209.85.218.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FulK3Pa8" Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-b936331786dso881388066b.3 for ; Wed, 15 Apr 2026 19:23:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776306234; x=1776911034; darn=vger.kernel.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=3EZO+AlyFvDQ+L9T+ECdGiRnOG/Ep4JVC8TTiPB3/Ng=; b=FulK3Pa8bxiUqgQ4j2+pg7zDiUeTn1A9987U3f0Y4EK8D4AiHPKMpFKTw6nI/Omm+H VORHQ1dRvftU8cNTkrRlC4CmXqFErLpD0ubLSpMZSEkRlaDHdpB44OlbASoHic6nFSgR IwI1S7Fabr0FYAO+EQrXON7XvVMzHyk5gGwX2qRfYVZtnFT1vqF7g6fsAlbrjSp2eVId PO96Si1k5Au//Ku5Y+SvMZQ1bo0UuBjvsdRCbQsua5HLWAfRI1DFAgr+zzc8NuPAF5NY h8ejT+BOEIr530ASJGXKV7dRi0PAfftMmW0U+VQpTi1eNBOyQT4VeeZzeqSdYjOXv8W0 i+tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776306234; x=1776911034; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3EZO+AlyFvDQ+L9T+ECdGiRnOG/Ep4JVC8TTiPB3/Ng=; b=ixAil29T2W1Hq6ZSp7u/2l+T1FVWcVlN3NHNK7DYqvyjRMMAk7jFU/6ZkQHmrMa9Qb orsQNP2d/RdcYADqEYuuD0/H73jZJadxHTEGl4tuHYdHV1Tkg4y1S4gIn3Ik62c8CPsv iZAjtVRkzmsTPptgjcLHswWSJdB9ebX3b2514GLhWN2YaBaUkNxz9g0r9y/k5octyjou NobWxHLikKg3gMh2no3CY8TtFk28VAWwM0dX9DzH9OnvIPHR+gTo5eD9NDlUINQaouuw CfOUf8JqXS9iujSmDAEny01yA8Od32Q/P5GrPl6BWtQTGguryQxRuALUwgvMYNDm+GYd 4OtQ== X-Forwarded-Encrypted: i=1; AFNElJ/s6vrubqJlW6OreXP6MQCzXtDbu84VxV8HZYU77Sl21SuX9+AcJawezJZrPif0A0EQYVEi0bOYdzCHISQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxv6VnJyBDdlO2RBkLoz6n7CAGFSKq/jt6mTv1GPiV2hztnC+d GZ8X8uC1ckmGmQjtQka8oHIRqttvP6+sQybRsXw00nc31PZYlaZvJZZb X-Gm-Gg: AeBDievaJ8WMzR1C3QfrbyVFddVgfHOXD3FjeL4KrB1xX/iVxRhxhCu0M8nM9yF5U+f EtMCDf40BGeFA5HP60pM5C11K5qMLuCq14/ksNQ0DKziEu+cekYT8ibw2quZl+XJYPY/OD0HALs AWk3uNTekjHH0jP1zPOMuP8xEFKnAvwcNtC2pGHNeLWnfSA1ODp4ERHEfznfrEYfNq/ppubpCAV 4ARMWWbt5gjs9Ic6+61OIhIEqbTSBI9IG48meqnSHMU0Ccy+DECGCVATf3AwlRj5ZXEjkp4ERGg wT6q8VYtwQHD5tHHqxTMT+ZvKGbopDmgU8rTX+XvyZamRS6EHbW++CL+HRYLuX/CdtOn3gbu6Ju jn5nYs1xNur0WT7k0sxPXaMbe9nof3AlSfELv3jynv0a6NSvhwbzZoOx+vJQM58b9zMwc4VxFqB fWlbs+5eHdLoHH+YEzLeNYSTqc2zBICmc6 X-Received: by 2002:a17:907:d0d:b0:b9c:f69:598c with SMTP id a640c23a62f3a-b9d725ebe50mr1351344066b.22.1776306233925; Wed, 15 Apr 2026 19:23:53 -0700 (PDT) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba17341bdf6sm110494366b.1.2026.04.15.19.23.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2026 19:23:52 -0700 (PDT) Date: Thu, 16 Apr 2026 02:23:51 +0000 From: Wei Yang To: Yuan Liu Cc: David Hildenbrand , Oscar Salvador , Mike Rapoport , Wei Yang , linux-mm@kvack.org, Yong Hu , Nanhai Zou , Tim Chen , Qiuxu Zhuo , Yu C Chen , Pan Deng , Tianyou Li , Chen Zhang , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] mm/memory hotplug/unplug: Optimize zone contiguous check when changing pfn range Message-ID: <20260416022351.llek76h5cik3nese@master> Reply-To: Wei Yang References: <20260408031615.1831922-1-yuan1.liu@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408031615.1831922-1-yuan1.liu@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) On Tue, Apr 07, 2026 at 11:16:15PM -0400, Yuan Liu wrote: [...] > > /* >@@ -956,9 +957,22 @@ static void __init memmap_init_zone_range(struct zone *zone, > memmap_init_range(end_pfn - start_pfn, nid, zone_id, start_pfn, > zone_end_pfn, MEMINIT_EARLY, NULL, MIGRATE_MOVABLE, > false); >+ zone->pages_with_online_memmap += end_pfn - start_pfn; > >- if (*hole_pfn < start_pfn) >- init_unavailable_range(*hole_pfn, start_pfn, zone_id, nid); >+ if (*hole_pfn < start_pfn) { >+ unsigned long pgcnt; >+ >+ if (*hole_pfn < zone_start_pfn) { >+ init_unavailable_range(*hole_pfn, zone_start_pfn, >+ zone_id, nid); One question here: init_unavailable_range(zone_id) __init_single_page(zone_id) set_page_links(zone_id) set_page_zone(page, zone_id) [hole_pfn, zone_start_pfn) doesn't belong to this zone. Would this be a problem? But it seems we have already done this for a long time. >+ pgcnt = init_unavailable_range(zone_start_pfn, >+ start_pfn, zone_id, nid); >+ } else { >+ pgcnt = init_unavailable_range(*hole_pfn, start_pfn, >+ zone_id, nid); >+ } >+ zone->pages_with_online_memmap += pgcnt; >+ } > > *hole_pfn = end_pfn; > } -- Wei Yang Help you, Help me