From: Udit Kumar <u-kumar1@ti.com>
To: <andrzej.hajda@intel.com>, <vigneshr@ti.com>, <b-padhi@ti.com>,
<devarsht@ti.com>, <y-d@ti.com>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <yamonkar@cadence.com>,
<sjakhade@cadence.com>
Cc: <Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>,
<jernej.skrabec@gmail.com>, <maarten.lankhorst@linux.intel.com>,
<mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>,
<simona@ffwll.ch>, <dri-devel@lists.freedesktop.org>,
<linux-kernel@vger.kernel.org>, Udit Kumar <u-kumar1@ti.com>,
<stable@vger.kernel.org>
Subject: [PATCH] drm/bridge/cdns-mhdp8546: Fix incorrect register clear in j721e disable
Date: Thu, 16 Apr 2026 09:39:33 +0530 [thread overview]
Message-ID: <20260416040933.3052831-1-u-kumar1@ti.com> (raw)
Fix the cdns_mhdp_j721e_disable() function to clear the correct register.
The function should clear DPTX_SRC_CFG (video source configuration) instead
of DPTX_DSC_CFG (DSC configuration) when disabling the display interface.
Clearing DPTX_SRC_CFG properly resets all video source settings (VIF enable
bits and DPI selections) to their default state.
Cc: stable@vger.kernel.org
Fixes: afba7e6c5fc19 ("drm: bridge: cdns-mhdp8546: Add TI J721E wrapper")
Signed-off-by: Udit Kumar <u-kumar1@ti.com>
---
drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c
index 12d04be4e242..5f92436ffa0a 100644
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-j721e.c
@@ -62,7 +62,7 @@ static void cdns_mhdp_j721e_enable(struct cdns_mhdp_device *mhdp)
static void cdns_mhdp_j721e_disable(struct cdns_mhdp_device *mhdp)
{
/* Put everything to defaults */
- writel(0, mhdp->j721e_regs + DPTX_DSC_CFG);
+ writel(0, mhdp->j721e_regs + DPTX_SRC_CFG);
}
const struct mhdp_platform_ops mhdp_ti_j721e_ops = {
--
2.34.1
reply other threads:[~2026-04-16 4:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416040933.3052831-1-u-kumar1@ti.com \
--to=u-kumar1@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=b-padhi@ti.com \
--cc=devarsht@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=sjakhade@cadence.com \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
--cc=vigneshr@ti.com \
--cc=y-d@ti.com \
--cc=yamonkar@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox