From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2786712CDBE
	for <linux-kernel@vger.kernel.org>; Thu, 16 Apr 2026 05:16:29 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1776316591; cv=none; b=QuMKhshXOZORaecUximv9PBVFMgbLvmbyomnqa5EqgSEyxfBxseWib7y2SCyZyWA62a3V8359nw6ren32b5+49PGAuNgCYnY/GRi8HyttIouB8ZwD1fXfr+/9/ZkCzan23KhHma5fFzvrDbnCJDr308Gfjn4HAxVpoykHis3Ih8=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1776316591; c=relaxed/simple;
	bh=wJqtn6aqYu3Li8xe/dbLRBZsdUw+sdOLjuqBZ2Gaxmk=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=UW01L7eaSAeBsfj2a49QCzIHp0VPKItA8hl1keWoD2jj6bMVQDklnY55c4qDiBI1OzL+tcEr/gXKXH5rXENWLaBpXhCfQF8V2L3jtkKZYt0jD/xDpNKRXpZ7uaJ8tiLzhQYdBfsMuW9SbMTfNCrvuY5tFpQuxgfnu/zgN/vuZ7w=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 7115B6732A; Thu, 16 Apr 2026 07:16:27 +0200 (CEST)
Date: Thu, 16 Apr 2026 07:16:27 +0200
From: Christoph Hellwig <hch@lst.de>
To: alistair23@gmail.com
Cc: hare@suse.de, kbusch@kernel.org, axboe@kernel.dk, hch@lst.de,
	sagi@grimberg.me, kch@nvidia.com, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2] nvme-auth: Include SC_C in RVAL controller hash
Message-ID: <20260416051627.GC14802@lst.de>
References: <20260415230824.2790058-1-alistair.francis@wdc.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260415230824.2790058-1-alistair.francis@wdc.com>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Apr 16, 2026 at 09:08:24AM +1000, alistair23@gmail.com wrote:
> From: Alistair Francis <alistair.francis@wdc.com>
> 
> Section 8.3.4.5.5 of the NVMe Base Specification 2.1 describes what is
> included in the Response Value (RVAL) hash and SC_C should be included.
> Currently we are hardcoding 0 instead of using the correct SC_C value.
> 
> Update the host and target code to use the SC_C when calculating the
> RVAL instead of using 0.

This looks correct.  But I guess this breaks existing implementations
in the wild now?