From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E609340298 for ; Thu, 16 Apr 2026 05:16:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776316612; cv=none; b=X/Jgd6bghXt0hIvoa3BQUd4QOcrnoE4YZLCL//FH+qtlcTsaW4JI4/kfwoxb1Sta9MM6Fx8LKGhpBf58jb8H90b14uHKJ1Xn1JBjrvau3vG70Y0crGJE6hsX5+UVVbWApgT/c3hMO6MlCYveorLtyVdtGagihnqYnROkV1T3W1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776316612; c=relaxed/simple; bh=UKSSe1/e50TTEiAHIlvcerCNjjv2hXqo6dnk/WjKCyY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=s7+Imt3CLEfsPWFkiUyvJbf171Vi8vDpX/p/PbXQFZCxr2+5CstYRaYZ3O+Bv+sCe9VKDzcCjNrsdpT7EzNCorR91n3zscoAuS64fLzhERFWTrWaTQvEYCtQBU9gSqA9/RWegrVLyrMyJt6eQs7CeUZI+gMzWv+aAaKKlqVkqwg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g0ZuuIvX; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g0ZuuIvX" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-82f7c7ee9b8so97344b3a.0 for ; Wed, 15 Apr 2026 22:16:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776316608; x=1776921408; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PLshPt1Skm2DtadDEq1VBxK5b4P4BIol5EeO2Icx+Go=; b=g0ZuuIvXnZRcD36TLusRPE2mzh/nwAeHzAJL8Z0IwiSDh7FaG6doSXRrHAPRm3vuFS IB0i+O1H1VotuodVigrFCiTR5rgfBe4rq+laqf1qcGe2/Ly6MfcCiryf2ZWo9JXoxeJ0 mgkDWI5/o9Z3Qv8xOGidnevNMWhEfv6cw7NhKRzjTCoMHd5e6YWVc3h7ggBDacasBH8I Rc6ktNY/yZ4u4Lni6WdWBqSMxiY0w02mOOfyWDVVzhNQF++zzoHY7/nGnH3bSM2Bdl2J f7rv0Y/17bLYiMHLEZ8o9tQyQLPRybihCpMs/MhZ4Hg+uB/Jk2Pk67PkmjJPdnSkElO/ J6vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776316608; x=1776921408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PLshPt1Skm2DtadDEq1VBxK5b4P4BIol5EeO2Icx+Go=; b=Z6XTMm2LnY6VixLQCwQfulS0w4K1F7cH0s21goxpu1/U+UhpFGrxmil1sFMJpEV1Se W8tYedVpDWhWfAHN9BCoZQwROxVVDiYjr3jwhoMR+05fJdC1g98JduNjp4yAYfJzuagZ 0FIFR/nlaYGZuoOlR1WikuP4B12DbvLPkkAtRrVswojVQbHs+Tvv2Vi5kwd7dQskj3DF KJdZkpNjuCEEFbrdG3coQx2mfgwsDmuV9kKszpl/weoqrJv3pB95TVAaBXXuo0I6Mu0D i9jK0dEcla2Yz2cM60wGJ7pIc4Eq8cr3UJ2NkDpwPKId/D9Usum141h5i1VtV8woi+DC QTCQ== X-Forwarded-Encrypted: i=1; AFNElJ9YMnLgK5KcjDUkQzrlnP37yOSy6E381/1DhqllK807Svt8y8vnrEIVaKjY4c90GN3MroZvLNLzTDhFuas=@vger.kernel.org X-Gm-Message-State: AOJu0YzaNpsXcijei98En6qml7vB9L60VZ5KaBTvtwJyv+i1E9jlGywI ife7QyZBa6joqC1geuawxoDSvxpCdEBl9b0kFR+88Zf7Atfcld3hRUcx X-Gm-Gg: AeBDiet7JMuhvJlIlg6Fu+6as3QJFFFtZLLlywheKmiZVjy7s9vrZKshgE1sBgu8gmq 0xtyv/eIWdp0fH9wwb9l7juki5H4gxrSSGxYfGWGLotCnj1RiQFqkE+E+4xTP+AicNkb2yJLZq6 UQNDQMhWyMNc9PBC8Ma/Xt+vczRZFV/yvtW+GR8HnAp0XavY6VIlI7xxaGT6oi3sZbiakj/au5f WlmU4C9KEh32Lba5NPI/K19S73eCZMcB+cotEMbB4zBhGaO8z/qyC7EmNnigCHyzn1DjcTmCfEr 7X647OxGMJH621OiJ2yPDeuGRZq72kRXrExEHPc5ZRDEba3niUxXwjKORQ550I3lwCf8M2CYS2X jIjuyzxT+N6vQcQbCIjmpF0aRxUlsGQjZyymc7mfDTyKaZlRrs4fI/KGouks1bCTvKqrWCaYq8h e9CmIXNRsOcibbQvqSa/YaRfK9gcsSeDI8ne33p6nS2H/NwcQ4IeNvgFooWn4= X-Received: by 2002:a05:6a00:2791:b0:82a:e3de:27c2 with SMTP id d2e1a72fcca58-82f0c253663mr25800207b3a.41.1776316608014; Wed, 15 Apr 2026 22:16:48 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f67476a5fsm3948364b3a.60.2026.04.15.22.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2026 22:16:47 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: lucas.p.stankus@gmail.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] iio: accel: adxl313: Use dev_err_probe Date: Thu, 16 Apr 2026 10:46:31 +0530 Message-Id: <20260416051631.551250-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260416051631.551250-1-sanjayembedded@gmail.com> References: <20260416051631.551250-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda dev_err_probe() makes error code handling simpler and handle deferred probe nicely (avoid spamming logs). Signed-off-by: Sanjay Chitroda --- drivers/iio/accel/adxl313_core.c | 6 ++---- drivers/iio/accel/adxl313_i2c.c | 8 +++----- drivers/iio/accel/adxl313_spi.c | 8 +++----- 3 files changed, 8 insertions(+), 14 deletions(-) diff --git a/drivers/iio/accel/adxl313_core.c b/drivers/iio/accel/adxl313_core.c index 339570701083..1e9df5702de4 100644 --- a/drivers/iio/accel/adxl313_core.c +++ b/drivers/iio/accel/adxl313_core.c @@ -1251,10 +1251,8 @@ int adxl313_core_probe(struct device *dev, indio_dev->available_scan_masks = adxl313_scan_masks; ret = adxl313_setup(dev, data, setup); - if (ret) { - dev_err(dev, "ADXL313 setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "ADXL313 setup failed\n"); int_line = adxl313_get_int_type(dev, &irq); if (int_line == ADXL313_INT_NONE) { diff --git a/drivers/iio/accel/adxl313_i2c.c b/drivers/iio/accel/adxl313_i2c.c index b67ff0b4dc54..896d6ee8a3ef 100644 --- a/drivers/iio/accel/adxl313_i2c.c +++ b/drivers/iio/accel/adxl313_i2c.c @@ -75,11 +75,9 @@ static int adxl313_i2c_probe(struct i2c_client *client) regmap = devm_regmap_init_i2c(client, &adxl31x_i2c_regmap_config[chip_data->type]); - if (IS_ERR(regmap)) { - dev_err(&client->dev, "Error initializing i2c regmap: %ld\n", - PTR_ERR(regmap)); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(&client->dev, PTR_ERR(regmap), + "Error initializing i2c regmap\n"); return adxl313_core_probe(&client->dev, regmap, chip_data, NULL); } diff --git a/drivers/iio/accel/adxl313_spi.c b/drivers/iio/accel/adxl313_spi.c index dedb0885c277..6a0deea2209f 100644 --- a/drivers/iio/accel/adxl313_spi.c +++ b/drivers/iio/accel/adxl313_spi.c @@ -83,11 +83,9 @@ static int adxl313_spi_probe(struct spi_device *spi) regmap = devm_regmap_init_spi(spi, &adxl31x_spi_regmap_config[chip_data->type]); - if (IS_ERR(regmap)) { - dev_err(&spi->dev, "Error initializing spi regmap: %ld\n", - PTR_ERR(regmap)); - return PTR_ERR(regmap); - } + if (IS_ERR(regmap)) + return dev_err_probe(&spi->dev, PTR_ERR(regmap), + "Error initializing spi regmap\n"); return adxl313_core_probe(&spi->dev, regmap, chip_data, &adxl313_spi_setup); -- 2.34.1