From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06D1B382F3B for ; Thu, 16 Apr 2026 09:04:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776330288; cv=none; b=sv6ffx+2VgW4Hc8/mvaDtU5Wa57Gx5aP/hRohW+uChPeulvSnIZzKIXiMhmiW3yMYQkB+8d//pD7ky7DLjTSkzfpd7wOldAAv6quS+ksh+LLEpYFl2U/dfiIFldDlzkH9RpjVDHCZU8tfEGaN0+fEmKwFiQ/w5oQ1XN0ekwRwuU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776330288; c=relaxed/simple; bh=xFADogH/29XnzhsKtl5h1vUcQsc5r6HbJAkKVcssRGg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JyoR+BxGbcXEs6nKBNgvUAysxQnDyMD7TO7/LbiePx9nmo4jDVZVxGpI9l+7KTs+Jm+wp0DnhjhBJS5ItsusOIMAp8M0MHFbmRr/1rWOOgb2RGA5TOuJyHlKgWKfCwB7JLIPo6a1dTWjDnyPWJkDJtMy+Ddd2UZ6TF3zcDWkloE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ctjpf9rc; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ctjpf9rc" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43d64313c39so4545410f8f.3 for ; Thu, 16 Apr 2026 02:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776330285; x=1776935085; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z4l6MiEafYZbPelSJ82SM6IlDLYy9fabNTGo/9W+w4k=; b=ctjpf9rcd3qkxW/f/gD+vukd67Aoyug8Lo7C6pNo/Ucs80h3pYrBwhlbQ7vk/zE69D esn2UFhcOnHDTxRKET9A9P7/PB6htX9pmY5ZC4s85eQFBjqRfEjNfD2wnnCWNyksXyEB LXrr3SCqp7pUTdE8g08XkFYKw3RhfMRczlS1aQJw4FroqidvUkUxlTzdRSFXeaV0IH65 u5A6Ny8jIZ7DItT2W+I0jn4e8FplIky1gq1XKLVcyl9hAwmEYp1g79Hz9PiIMClvJ0md eZxxS9+c78ma0VrIshsRXdQQDWEf6G7zOdnO1w5Pgp0Gmm9OVEvd6JBTQ0eUjlaTZ/lu MY0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776330285; x=1776935085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z4l6MiEafYZbPelSJ82SM6IlDLYy9fabNTGo/9W+w4k=; b=kbdxNWATtevzoXsy9hzGhijcRvQROEwT47miiF36iZNh3UTj9oSvbPfvrgDhGVJd7o O5JJB+rUR431AVp56YL+cJiO9sPo6Oi92wppU7aaoQEI2tjqBjDH+gonhgXj6y/8A1Ae vEvCIMZja3NxBaaFIiAsCg/xdSXaQ1O4bw53pEoxPc2/gdI6HaJJJ/J68jJKd7pS/nOV uipfta1cRc2FD+dYn/DkriyF4QjauuwHi9kibisTGdmLRfrpJcBH1xcfcm3jNHTOoRCJ 2X6+6ZPK2vL3P+EtEi8ecYpPNcDuT/DUSAszMyLj915HLr34vwkDP0so7CUTP6/jLh8K pgfQ== X-Forwarded-Encrypted: i=1; AFNElJ9Pytm0RrFR4B+mbtFMTD5kbX5TAHe2iIzvsT4NCvIx0r3Sx69M/b7XV6h3HklRY9L94OCbFza4qYjaYeQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwiNqjAAYEsm54JqoyHBKqKjvcsW8hZxDxYbPU8qeItYUM133/g ooKxDO3c4FNJPSPLCnPF5hWZOze5tIFISaSzAaJK/8+Ly+OricWkgrGYbwNol3OnJdw= X-Gm-Gg: AeBDiesXMmVR9xfQr2rjQKdHcqroQXlFOZd0GjL1F/BM41ub99hbuM+oT/fENx0KlzT mMXMLS4iGEXJMIMsKFD8LkVjuFexccU1oWsLgaD0BIHh1F7/9GVAS0Wk5gRkAvQxS1hqlW71yQA CC1Cjk/9/QtBMxQUbN8za9BRGx//B8+YXhcqUx4Y7q8j2cS79yrE6fxA8Sp/QofESvOpiCIJ6ug GWK9ob6CwsbqPGv0UsxiRNjTl9os9Rdm2M1RpZozKVs6dVBAzIvOzuSgLXDPFuYLWxi91YqZscj TMnVHAj647T9gf3eHYVn94dHOsNmOI5vdDdIbRKuRaZeGQfHDKsgaGjfU3pZrnhlLg7bGsFhVDV PXmidjpojYxQu/ZYZzeMAn6Q7Za6xkFqhPYh8XwVMgiNV5o7QG4KUYn6+6mNYjUPLqsBiBcziOx pxJrFPXZIhhGGj3SUYhiDTExfP6ScBSi3xGKt/wM8Pd9kDmHdTuIrORc959qo2kOlnA1t9R0lC6 3vuB7jtEOuYN9Ubwwgrb5vY X-Received: by 2002:a5d:5d0b:0:b0:439:b55d:b0e5 with SMTP id ffacd0b85a97d-43d642a7a61mr38001620f8f.28.1776330285188; Thu, 16 Apr 2026 02:04:45 -0700 (PDT) Received: from localhost.localdomain ([212.154.124.146]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43ead3ebd38sm12565221f8f.31.2026.04.16.02.04.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 16 Apr 2026 02:04:44 -0700 (PDT) From: Baran Arda To: asmadeus@codewreck.org Cc: ericvh@kernel.org, lucho@ionkov.net, linux_oss@crudebyte.com, v9fs@lists.linux.dev, linux-kernel@vger.kernel.org, Baran Arda Subject: [PATCH v2] fs/9p: remove unnecessary extern keywords from function prototypes Date: Thu, 16 Apr 2026 12:04:38 +0300 Message-ID: <20260416090438.42844-1-baran9arda@gmail.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello Dominique, Thank you for your feedback. In this second version, I have removed the 'extern' keywords only from function prototypes. I understand this is a minor cleanup, but it is my first contribution to the Linux kernel and I am excited to learn the process. I appreciate your time and effort in reviewing this. Best regards, Baran Arda fs/9p: remove unnecessary extern keywords from function prototypes Remove explicit extern keywords from function prototypes in 9p header files. This cleans up the code in accordance with the kernel coding style. Signed-off-by: Baran Arda --- v2: - Restored 'extern' keywords for variables as requested by maintainers. - Only modified function prototypes in this version. fs/9p/cache.h | 6 +++--- fs/9p/v9fs.h | 24 ++++++++++++------------ 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/fs/9p/cache.h b/fs/9p/cache.h index ee1b6b06a2fd..25f0dd58122e 100644 --- a/fs/9p/cache.h +++ b/fs/9p/cache.h @@ -11,10 +11,10 @@ #ifdef CONFIG_9P_FSCACHE #include -extern int v9fs_cache_session_get_cookie(struct v9fs_session_info *v9ses, - const char *dev_name); +int v9fs_cache_session_get_cookie(struct v9fs_session_info *v9ses, + const char *dev_name); -extern void v9fs_cache_inode_get_cookie(struct inode *inode); +void v9fs_cache_inode_get_cookie(struct inode *inode); #else /* CONFIG_9P_FSCACHE */ diff --git a/fs/9p/v9fs.h b/fs/9p/v9fs.h index 6a12445d3858..2d37505704a9 100644 --- a/fs/9p/v9fs.h +++ b/fs/9p/v9fs.h @@ -168,30 +168,30 @@ static inline struct fscache_volume *v9fs_session_cache(struct v9fs_session_info extern const struct fs_parameter_spec v9fs_param_spec[]; -extern int v9fs_parse_param(struct fs_context *fc, struct fs_parameter *param); -extern int v9fs_show_options(struct seq_file *m, struct dentry *root); +int v9fs_parse_param(struct fs_context *fc, struct fs_parameter *param); +int v9fs_show_options(struct seq_file *m, struct dentry *root); struct p9_fid *v9fs_session_init(struct v9fs_session_info *v9ses, struct fs_context *fc); -extern void v9fs_session_close(struct v9fs_session_info *v9ses); -extern void v9fs_session_cancel(struct v9fs_session_info *v9ses); -extern void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses); -extern struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, - unsigned int flags); -extern int v9fs_vfs_unlink(struct inode *i, struct dentry *d); -extern int v9fs_vfs_rmdir(struct inode *i, struct dentry *d); -extern int v9fs_vfs_rename(struct mnt_idmap *idmap, +void v9fs_session_close(struct v9fs_session_info *v9ses); +void v9fs_session_cancel(struct v9fs_session_info *v9ses); +void v9fs_session_begin_cancel(struct v9fs_session_info *v9ses); +struct dentry *v9fs_vfs_lookup(struct inode *dir, struct dentry *dentry, + unsigned int flags); +int v9fs_vfs_unlink(struct inode *i, struct dentry *d); +int v9fs_vfs_rmdir(struct inode *i, struct dentry *d); +int v9fs_vfs_rename(struct mnt_idmap *idmap, struct inode *old_dir, struct dentry *old_dentry, struct inode *new_dir, struct dentry *new_dentry, unsigned int flags); -extern struct inode *v9fs_inode_from_fid(struct v9fs_session_info *v9ses, +struct inode *v9fs_inode_from_fid(struct v9fs_session_info *v9ses, struct p9_fid *fid, struct super_block *sb, int new); extern const struct inode_operations v9fs_dir_inode_operations_dotl; extern const struct inode_operations v9fs_file_inode_operations_dotl; extern const struct inode_operations v9fs_symlink_inode_operations_dotl; extern const struct netfs_request_ops v9fs_req_ops; -extern struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses, +struct inode *v9fs_inode_from_fid_dotl(struct v9fs_session_info *v9ses, struct p9_fid *fid, struct super_block *sb, int new);