From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 592B7378D9E for ; Thu, 16 Apr 2026 09:32:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776331927; cv=none; b=bFP2sBL8K+sN3TClRpOCopcyNthqROxrYxNtXxsRDxKbXMQaG2CXEX8SUZwLAha1UU1jIhF5j85E9RDqBEHmHiP1VVv3O9ilc9w0Je20BM7Vxz4JPu+bi1mhs87aB2nAQZnDklZT0EgjwXF2+3MlRjV3R/rWLq0GgRWToEdxhaQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776331927; c=relaxed/simple; bh=9qYZV2Eb0ePelYvXOpZKhb/azu6xkr9bR5sQYdEPZmo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HusmhEwRgK8r7vXMdwJbMLQNG1SjYWRXmBXfBq6llalarxqTPGpAdzO71ETl8wBcWBsewsa74C2QTmuJaT3M8aHeve6s2imtHQY75JZqhErZu0H1si96Kjdb/3LbTvldyVETMJi22pgN74jkifX5+sIB+118GJ0JIlEFvW8TEm4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hXJawbCN; arc=none smtp.client-ip=209.85.214.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hXJawbCN" Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-2b249d6ba0bso5032595ad.2 for ; Thu, 16 Apr 2026 02:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776331926; x=1776936726; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ziW1kBAvi5eeUGJnyi0Kk8txQ47lAeHn3mhssBVXCLs=; b=hXJawbCNG+AVedOuwb9WvAaQhUD4ZL6vL8V1/MlsaydoPBuyAthCRsDNmjqrgKTBja i/Z+WXLKNGDzUOh9zi3NRs7Yp2uwqQmjCdMRgwnBPJ40w8Yj+J6FAZ2Gx0nrvvkdTOHW ZiMNOW5h7NBNOAvIPi9mYJtrGSvIFlO40yu+IrwJDfIKMuzq9t++aMO+wgrWDiCtvibF zx7zxJLOXor1nXqZCEqEnDkFOC5MLeGBhL2BD82qpWhglcgjRPAFjFW6SN4cFLHtqRPJ 9h7pS0fZGYThLdOTqM15XvVut1m6pMXKOXqknvzMp9eoBoTTmwKhJ3lacOJflPvxf65z A04w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776331926; x=1776936726; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ziW1kBAvi5eeUGJnyi0Kk8txQ47lAeHn3mhssBVXCLs=; b=JqAsQUFGlzJqcHdnSmtRVVksRqPC78clEjGkq96Im69bdOfG4ANr2Jyf36A4PcbBPV 1CIxQpQ9o598+0837oAKX8bdgwDPXm2BTfz4M4jKjLqQljRkqh7DNH08ieVObmPq4Qod ljlGRH8ZQLNsUvHj1mgD+QTf5M6/StYBFc2bAWX5+ySwpGqWrGRtDA7Fp17Ju5tLiGC9 iwJ/E/v9sbFkS5lKYCJIME5IWI+6/kfgGOSsAGvz8BpTiGsIKwmseK9nLuejmN+thGUE iHOdzqKeVkmwNXQG3CfOYa+WUGpM+uO7ijoNeY+3hQ8gc/U/vfJv4vuPU5KEz7X4lY40 p4EQ== X-Forwarded-Encrypted: i=1; AFNElJ8Jn8bz/SS58XFJzNeR39hWqI3agfx0Q9NGycJQrz1x8oWI9n8E3E7deaEgkXIjV7Ayu7gn7mRaiy4dLaE=@vger.kernel.org X-Gm-Message-State: AOJu0YzQA+8/ck0fOiNH8hgYLwOIrX7DzRDlJ6BPkx+p2w/4eW/QcHEx cpzL0guh6bQxjMO7pk7LcYrZ1OuI7Wko2F9z4qWQYzTCAKpCSkv5/cb3 X-Gm-Gg: AeBDiesOUMmpPfhl0BvJwfdwLq/f4SopTSZXnVo8KG6KIYYJ16WwdjrWLT9hqiHHX8G 7nuUhphoF+HAm4YqN6p+LbJl1MViv8DEaEIIuM0TyRrfi4/3b7HBWIZQ9ROatsaSp1YEjwycON9 WqXodZRFtmKfqdgK0YLig0CotpzZ0uF05lk64z9TS5u7AbD04d5z48YJvinwZ8On+nH3D4pDPps GBhL9OkI55yNlDycX9lRmVe744kLpmNIsw2DrPjxGoJ+xAjy+vYvc+UxtOzSu0VYdvh3rchlGDs PwiRdMQKBFDLsDt7PVpVu3I2ou/7pEa51EQi5yW/H1R7SJs52QQshsKfuJ8yEgiuMne41k8M4K3 UGIQg8vKqC197BFHLf8DnIuOATkOCMQuo39+31mlDEXsyRZMK9PmcruiqE7Mtpqn2GfYp7GEWJv hP208I8k/F9ny1ks0OPfyv3WnnhAWzj9JX5F97PcjY6CU8641rEvUl/JdD+k3ZkvO3rommK+Oe X-Received: by 2002:a17:903:903:b0:2b2:5857:5847 with SMTP id d9443c01a7336-2b5eda46fd0mr11515325ad.5.1776331925536; Thu, 16 Apr 2026 02:32:05 -0700 (PDT) Received: from fedora.izzigo.tv (45.62.127.193.16clouds.com. [45.62.127.193]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b478292053sm60643655ad.56.2026.04.16.02.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 02:32:04 -0700 (PDT) From: Frank Zhang To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: dw-hdmi-qp: Guard clear_audio_infoframe when PHY is down Date: Thu, 16 Apr 2026 17:31:50 +0800 Message-ID: <20260416093150.13853-1-rmxpzlb@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The following panic was observed during system reboot: Kernel panic - not syncing: Asynchronous SError Interrupt CPU: 7 UID: 1000 PID: 2637 Comm: pipewire ... 6.19.10-300.fc44.aarch64 Call trace: ... regmap_update_bits_base+0x5c/0x90 dw_hdmi_qp_bridge_clear_infoframe+0xb0/0x120 [dw_hdmi_qp] drm_bridge_connector_clear_infoframe+0x28/0x48 [drm_display_helper] ... dw_hdmi_qp_audio_disable+0x24/0xb8 [dw_hdmi_qp] drm_bridge_connector_audio_shutdown+0x30/0x60 [drm_display_helper] drm_connector_hdmi_audio_shutdown+0x24/0x38 [drm_display_helper] hdmi_codec_shutdown+0x60/0x90 [snd_soc_hdmi_codec] ... snd_pcm_release_substream.part.0+0x44/0xd8 [snd_pcm] snd_pcm_release+0x60/0xe8 [snd_pcm] ... The root cause is pipewire tries to close the HDMI audio device after atomic_disable(), which sets tmds_char_rate to 0 and disable the PHY. In this case, dw_hdmi_qp_audio_disable() will call clear_audio_infoframe(), accessing registers without checking tmds_char_rate. Add a tmds_char_rate check in dw_hdmi_qp_bridge_clear_audio_infoframe() to skip the register write when the PHY is inactive. Signed-off-by: Frank Zhang diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c index d649a1cf07f5..f963dff81dc6 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c @@ -886,11 +886,12 @@ static int dw_hdmi_qp_bridge_clear_audio_infoframe(struct drm_bridge *bridge) { struct dw_hdmi_qp *hdmi = bridge->driver_private; - dw_hdmi_qp_mod(hdmi, 0, - PKTSCHED_ACR_TX_EN | - PKTSCHED_AUDS_TX_EN | - PKTSCHED_AUDI_TX_EN, - PKTSCHED_PKT_EN); + if (hdmi->tmds_char_rate) + dw_hdmi_qp_mod(hdmi, 0, + PKTSCHED_ACR_TX_EN | + PKTSCHED_AUDS_TX_EN | + PKTSCHED_AUDI_TX_EN, + PKTSCHED_PKT_EN); return 0; } -- 2.53.0