From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1698739F17E for ; Thu, 16 Apr 2026 10:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776335051; cv=none; b=WVOeIjEb4Ki8UC07DRVEr1rKluXT+gXgbWuxDGZduPNUfb277koY0H00Q0HzzfpPcIac4wvoWli1vIIrr3f9JAsgOpGtD82oVtArlCc2NokBsolw9ff2/9Ossm8G54k03Yp3z2kBKlfUuwfr1x+g4Aw+JSBfgv9aPCaN2sfo0Ac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776335051; c=relaxed/simple; bh=hoSWFt1lN7mgDuGcRxcB1lkiBWIHGGLW3aOdhlsJdAw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=rpuGIF8wM8MXcw+Ho15C7nguoAlTaNbavUHiEw21OMpqUz1+JNeaDT60P2NIjbnm9ZsIvrTKGrNhTXXNr/TyQyzN6ZUbYGtPQ9JinYQ6pf8MPw4HlhTTSgfiNYEVi3LMClO25SsCX+8GBfKiy9CHktkOuVA60KCrH3ExHv6U72Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nC+Z6I6U; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nC+Z6I6U" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-483487335c2so85881685e9.2 for ; Thu, 16 Apr 2026 03:24:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776335048; x=1776939848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZezAuOM8XC3wh9BcVHj9NdPAqzBIZU7wkxD6LaGlRhs=; b=nC+Z6I6UkvR+NQHRigwbPuYNBHaKAzgVg2x3QOoNf6ujpJKr5KDN9Lyx5dQo1HFevU wYZx1iYxHrvokeVRLAyAjpDqy2WDtZqgz1n6LqzE2GBqSm8gz7rkQD5fMJqJfjH/MOhg wgTqVeNJGyynUBaaeZMhnntt1pFpU9VYzt/N9XPzIu+WUt3AvWW6NkaDtZdsGQGHR4WG NKJ7/usUdjF6eUdfAfafosipqrf2bAvR/MQbvkjm53OQQskHgP0ym6qiTeXfkg24CWes 0n/vB5jU0svyoEOBsDg4soF8PSrYJ/aakFwOXbx6h3oa4rW6NTEedrCQu/4l7LKi41Vr MUfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776335048; x=1776939848; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZezAuOM8XC3wh9BcVHj9NdPAqzBIZU7wkxD6LaGlRhs=; b=s1Sw7HQSRIVWIyzYqPxq7A853ac0lIQpMx8NaGMCUqwGDIWHaRHKhA4nRIS3Wdiyuz Qq/qIJfCPdq/UKITrbfHJ39YZjk8XBoufsZ7hrO36uulrWTzo6zRff7jOwLfhyZIgzN8 bGvnnG0xo9GQNjVWWIOJlQ0310uR7FiTxRuMJkyxKdVgKNUnQkZR4tbhvV57ygNtx1WB eKQcuHxMTThaUsivMEPIvoJlgcULoTT6bz9SpRqOKhj3VPgRSyarAok57g5MGoqqvo/P 04DyMwG6jmgjC27NVlt13B+fxXit29j4Luc67Ykq5JSlySgi2CTO7OhcQGFPXqOolw6T UFVg== X-Forwarded-Encrypted: i=1; AFNElJ/+TO7ZLXfpQ9/NX39v/6nkCv4eKBJMxduJEGWubgJ/KJtRhbnlanWHPps1IUfGTrf1OI/hSIt2+UOqYHA=@vger.kernel.org X-Gm-Message-State: AOJu0YwPSRQIM3/VUFa6PyGtyz9WboIoJULdVcR8EB0f/CRT04DxaA6P oErSeBLFUgXgYydIUQqJD11LPlDnZXpI3OtnWKH89/Qt8DZ7Y+MAS+jHArICV9nM X-Gm-Gg: AeBDieshpsGHraLmg0cKcOwpTVk8Z2jJtTCdiTF0zM7QmzTMM2C/0DLiQ9BX/P9OCu7 kY4hgh9mCSB56XVoeyqV+pSg4vfLKj5709UvBSq8WbV+gGzWPvCRE3cHrDxR2k49DUE1pcy2BWu acnC8A6b4NXvM3XkoM+pD4y1yS9NND81z1X2IdQ01EsiHeBHwZGXWJvhvydymO2jgvs9rgXNJ7u 6Dlf5993nkqblxdZqgfcegmXvrsgyhoHCGZTJNbkljmHHImHzGFEEsPpBEpKsFd+OAFaut+1vM9 B4tYa6lmxWqNoVXdPJAaYYMIU9x5z2nlxTlH0A7Rm5LZ+zaPbh3HIfRy/kzRu2E3F9CDcmffl9u /272Jr9a+3Ad+aZkXkVX/QPgYQad3VcxwORnUhfifKhZN4iLgLmfnzVTDrDMLOt9hmX55KQp3c8 m2rrg2bOO78e7quCA6SsRgdLM1TQtlBsg1FCZ2sm2O20DW6NofQf8tMQwPlaIIfqhq X-Received: by 2002:a05:600c:64cf:b0:485:b6dd:5066 with SMTP id 5b1f17b1804b1-488d67ce664mr337518265e9.7.1776335048179; Thu, 16 Apr 2026 03:24:08 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488f57da2aesm71848815e9.0.2026.04.16.03.24.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 03:24:07 -0700 (PDT) Date: Thu, 16 Apr 2026 11:24:06 +0100 From: David Laight To: kernel test robot Cc: Herbert Xu , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: crypto/hmac.c:251:12: warning: stack frame size (1152) exceeds limit (1024) in 'hmac_setkey_ahash' Message-ID: <20260416112406.68b7afcd@pumpkin> In-Reply-To: <202604161035.PMTaI4Cg-lkp@intel.com> References: <202604161035.PMTaI4Cg-lkp@intel.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 16 Apr 2026 11:04:43 +0800 kernel test robot wrote: > Hi Herbert, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > head: 9e1e9d660255d7216067193d774f338d08d8528d > commit: c3103416d5217655d707d9417aaf66f184e3d72f crypto: hmac - Add ahash support > date: 11 months ago > config: mips-eyeq6_defconfig (https://download.01.org/0day-ci/archive/20260416/202604161035.PMTaI4Cg-lkp@intel.com/config) > compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260416/202604161035.PMTaI4Cg-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Fixes: c3103416d521 ("crypto: hmac - Add ahash support") > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202604161035.PMTaI4Cg-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> crypto/hmac.c:251:12: warning: stack frame size (1152) exceeds limit (1024) in 'hmac_setkey_ahash' [-Wframe-larger-than] > 251 | static int hmac_setkey_ahash(struct crypto_ahash *parent, > | ^ > 1 warning generated. For a typical x86-64 build with gcc the frame is 700 bytes. Most will be for req - so it should be pretty architecture/compiler neutral. Really need the associated object file to see what is going on. The config file doesn't seem to contain anything unusual. There are some unrelated oddities though. > > > vim +/hmac_setkey_ahash +251 crypto/hmac.c > > 250 > > 251 static int hmac_setkey_ahash(struct crypto_ahash *parent, > 252 const u8 *inkey, unsigned int keylen) > 253 { > 254 struct ahash_hmac_ctx *tctx = crypto_ahash_ctx(parent); > 255 struct crypto_ahash *fb = crypto_ahash_fb(tctx->hash); > 256 int ds = crypto_ahash_digestsize(parent); > 257 int bs = crypto_ahash_blocksize(parent); > 258 int ss = crypto_ahash_statesize(parent); > 259 HASH_REQUEST_ON_STACK(req, fb); > 260 u8 *opad = &tctx->pads[ss]; Is ss actually guaranteed to be not smaller than bs ? > 261 u8 *ipad = &tctx->pads[0]; > 262 int err, i; > 263 > 264 if (fips_enabled && (keylen < 112 / 8)) > 265 return -EINVAL; > 266 > 267 ahash_request_set_callback(req, 0, NULL, NULL); > 268 > 269 if (keylen > bs) { > 270 ahash_request_set_virt(req, inkey, ipad, keylen); > 271 err = crypto_ahash_digest(req); > 272 if (err) > 273 goto out_zero_req; > 274 > 275 keylen = ds; Is ds guaranteed to be not larger than bs? > 276 } else > 277 memcpy(ipad, inkey, keylen); > 278 > 279 memset(ipad + keylen, 0, bs - keylen); > 280 memcpy(opad, ipad, bs); > 281 > 282 for (i = 0; i < bs; i++) { > 283 ipad[i] ^= HMAC_IPAD_VALUE; > 284 opad[i] ^= HMAC_OPAD_VALUE; > 285 } > 286 > 287 ahash_request_set_virt(req, ipad, NULL, bs); > 288 err = crypto_ahash_init(req) ?: > 289 crypto_ahash_update(req) ?: > 290 crypto_ahash_export(req, ipad); > 291 > 292 ahash_request_set_virt(req, opad, NULL, bs); > 293 err = err ?: > 294 crypto_ahash_init(req) ?: > 295 crypto_ahash_update(req) ?: > 296 crypto_ahash_export(req, opad); > 297 > 298 out_zero_req: > 299 HASH_REQUEST_ZERO(req); > 300 return err; > 301 } > 302 >