From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 308E186331 for ; Thu, 16 Apr 2026 15:02:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776351778; cv=none; b=qRX2iBCUIn3LBoSNwiTGrcJMFvznJuDGT6nBSHjtWAursnwKydKQp3CyzQADObN8ESgCeD7ai64wIk7RMx4rZsVHX54l1f/KKWnFt5dhnWpXWP/IEzU6fPms90tGoRa7qtTH8pixoQB8Wv9LrcDwtl0qKRXLBD7Lo4uYLXSRY1Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776351778; c=relaxed/simple; bh=K4zCV4fsKTvohS3Ddt0QX5xidGQGe6CWXVrEjoP/Xqg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ppcvFNPRfpvwA8ni7qN4EAV8tnnqrIuORY94q9USQyJ1X4hBywFZDe7Z4QBBE1NFfWVSOqvVLrq0UYWi96iiialv/VyOsWbNBg+v8AOXFwOF0rQACaxC3gvshdRDLu0qLF3QjfTiUUOwTCxHgZSzniuI/yyEVmUPSVMERiA1JlQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=tbIDTcZF; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="tbIDTcZF" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0D7E72574; Thu, 16 Apr 2026 08:02:44 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 43FE23F7D8; Thu, 16 Apr 2026 08:02:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776351769; bh=K4zCV4fsKTvohS3Ddt0QX5xidGQGe6CWXVrEjoP/Xqg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tbIDTcZFjAGoKuYH6bJ7yoys6cwr9l4qvLKwwjGw3oy95snCfMMzIrf0ooX+WM8Qp N+Pe4MieOMCymUeXRRl6ynX+SqsHHdMSMtZLKwED4masEKKaIzXxJeoTN7LUgnGM2c Zf9OIRIrSVLTmGEo0rbv8v58QkDmRH06B2NVwljs= Date: Thu, 16 Apr 2026 16:02:47 +0100 From: Leo Yan To: Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v5 01/12] coresight: etm4x: fix wrong check of etm4x_sspcicrn_present() Message-ID: <20260416150247.GK356832@e132581.arm.com> References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-2-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415165528.3369607-2-yeoreum.yun@arm.com> On Wed, Apr 15, 2026 at 05:55:17PM +0100, Yeoreum Yun wrote: > According to Embedded Trace Macrocell Architecture Specification > ETMv4.0 to ETM4.6 [0], TRCSSPCICR is present only if all of > the following are true: > > - TRCIDR4.NUMSSCC > n. > - TRCIDR4.NUMPC > 0b0000. > - TRCSSCSR.PC == 0b1. > > Comment for etm4x_sspcicrn_present() is align with the specification. > However, the check should use drvdata->nr_pe_cmp to check TRCIDR4.NUMPC > not nr_pe. > > Link: https://developer.arm.com/documentation/ihi0064/latest/ [0] > Signed-off-by: Yeoreum Yun Reviewed-by: Leo Yan