From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47A7030B50F for ; Thu, 16 Apr 2026 15:11:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776352267; cv=none; b=CJeQczcsnOcwb0sysyQN0MoA/bAFAuSGEhVh/5NmXtH+HTvPkpNIMISGxgvwTcv+eck/UG5NqPnwpRRTPSBr0/i5AezbvEh+m9/i+MRY6h/bh5M81XOonkNkSrhoxb3iX499NpSE+JvesmlF2VbsLXF842Zh+8jByg0M1HKQAy0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776352267; c=relaxed/simple; bh=krNOmdR6RwpLOzyXWjHfsuZMKqOBvSItCgTMpAtAuKY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uk7fi8QSJ6DEiUWa0ZpKk7Na71Fd/xy0E3o6U+7O5GW0epR5EyyC2WPKZNt67CDZR0RnHe/2jZmk+IVfqh9kGZFz2kRqmP80Ejwy0w80+GjuKLX1RC04dm6aE//fuz4nHlE3Q4UIjGXmybQtmKqSrlf03al+/BNBtVV6UjxmFhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=jKWtHQS0; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="jKWtHQS0" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C109A2574; Thu, 16 Apr 2026 08:10:58 -0700 (PDT) Received: from localhost (e132581.arm.com [10.1.196.87]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0669A3F7B4; Thu, 16 Apr 2026 08:11:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1776352264; bh=krNOmdR6RwpLOzyXWjHfsuZMKqOBvSItCgTMpAtAuKY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jKWtHQS077IJqK8KCGZjVVyNStj7binMrHh0DKQUcdPkrTVe8hhLTgCyaOnd3cM93 yYALX0y9jb2j5WXIdRrKHpkitdDvGpnEsbWGG5PrNj08ZlVeoWxXocwPX/uWzz4SgL hrl4TA/+QArHuk1TQSlPbqdc5i6ePFd3YHshyrqE= Date: Thu, 16 Apr 2026 16:11:02 +0100 From: Leo Yan To: Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v5 02/12] coresight: etm4x: fix underflow for nrseqstate Message-ID: <20260416151102.GL356832@e132581.arm.com> References: <20260415165528.3369607-1-yeoreum.yun@arm.com> <20260415165528.3369607-3-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260415165528.3369607-3-yeoreum.yun@arm.com> On Wed, Apr 15, 2026 at 05:55:18PM +0100, Yeoreum Yun wrote: > TCRSEQEVR is implemented only when TCRIDR5.NUMSEQSTATE is 0b100, > in which case n ranges from 0 to 2; otherwise, TCRIDR5.NUMSEQSTATE is 0b000. My suggestion in previous version is not quite right, thanks for making this correct. [...] > @@ -1395,6 +1395,8 @@ static ssize_t seq_idx_store(struct device *dev, > struct etmv4_drvdata *drvdata = dev_get_drvdata(dev->parent); > struct etmv4_config *config = &drvdata->config; > > + if (!drvdata->nrseqstate) > + return -EINVAL; For "nrseqstate = 0" case, would it return -EOPNOTSUPP instead? Otherwise, LGTM: Reviewed-by: Leo Yan