From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BACE21DE894 for ; Thu, 16 Apr 2026 16:34:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776357244; cv=none; b=DbEfMLCJx5yFZ3BMVyNwZOzNRvor/t6MrDEXHR+dTULifSGJzcN1+X+ZQOk/sQvNd4jWO0oI303Re1fAn6OX9G1TlMD3mEwadOaFxD23+C94I8dvGO6MOY3GUNosc4i3sLNZg6Odn+UqCD2hPTAXdKYBJs6eRlKBgT++NWuVgFs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776357244; c=relaxed/simple; bh=iOHgLBjGBG8/L1J9/LEWCIms8zOb4aTUViXXlGyIwbs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ibY/GlCtZsNPcbKPpkwffl7F8cGpYKbXtmZ3ENGzekVwbflmnuMmwI4LX65nJ3O3DTFaDVj0A/0ZZB2auYjV2UGoa0JzM2Jt8QE7vnrhN4rGNsEvaloGyo1GHHoSefdgggZsnnVjMuoq2wNKHyeHkQdFG7vNnYN5lcm9t5EMEK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VUw+XGhQ; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VUw+XGhQ" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2b45cb89f7eso32101675ad.0 for ; Thu, 16 Apr 2026 09:34:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776357243; x=1776962043; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N3169mZIk8RorZVUOvI3bWe2SqAjpNH7g375pxr0zAU=; b=VUw+XGhQmm4eLiPbECiHurLmLz+iIhtVMWjybgP9FzOng+5t4uajrCJOz+cDU/yi4O eEUBbV074vDGqa6GXYP10xC7x+hVmQvhsav/bkxLhshUgfA4xi5+lFsUMIw+6KAEViY7 HoeC22uX72PWdC0IRCtV84ipjlWNoLPWUA0sBQxky4GhnN5yM9REtTP1ITHFd2EuwGUt vIlsPyHK/F1bGQykJwegvJgWe1GSjLtv0PfutaDHvDw2bwe8WBiUh0iLypS7iUXvGcO/ mqxdwyHOLkDnM6zBxTpd18azCJGLwrk4j7inEtjGlqGsk3Hb7yknDL0M+41D6PPlOiba Mb7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776357243; x=1776962043; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N3169mZIk8RorZVUOvI3bWe2SqAjpNH7g375pxr0zAU=; b=dMiu0ls1eua97gjjoX16t7tHiQEp0MRsjwCFdInmSItD5Caa9bXK7aN64vmcl4wDkt RaBh+f7fOQtIcjMqMXeedy7LvE8qg4toNmVvZt2bF3UvTaoxCIZmAbkxbcK/tdqlJbZ+ N490XID2nez92yLiSBugayYz4J3DBwqxooJvyrMysHx8AiZr3ltAirvMBWXpPlZNRfQE wlRFFpy/Ltvk6LvRrZQS6ItlcwH9Uvcthw4dhvktgb2Q/SU2fZRxwFD4MNstQeXu6ln4 5NJz+LBwHzHLVflf9n1JXP6x/RlF7u9scSjfEJrZyMs+82j5h3QZ+ZQyxkHMuxfQ+uiD X8sQ== X-Forwarded-Encrypted: i=1; AFNElJ8V6p6Af1RCD6wx2g1yUHTBg0H4hJpC2p2i4vLIu1E4SCSAp7opse2e7XrtyR7t+loSR9yyPxaf1Emj5Zw=@vger.kernel.org X-Gm-Message-State: AOJu0YxTJQjxVu3mbthEPboiNlYjyt9BH7FLyqhfX/ATLVWToN1hmqm2 WKRPnA+KeUUnGRKQ20vR67zGAVxtpcLcn/2iTyWBQricDdlg5stoxdfw X-Gm-Gg: AeBDiesILjnxkAA38Il6bi/zxIoy98RmVpvA9tYiiaqwd0Gf+QD5vt9VsV3I4l4k9Ho T/Y93E5iuoV34q961WzinNLehhTjk6PAVmQNke7eROCSiGtuQR72SqYsY0B8cUVCwVJQ1nsSBne 22Sot22P/DGcKoD6BgekBkG8EnGKgu/OQIThk5VvTG5oqi8/RIM7ZKuFPn81lpE07qpTYLpkVsG TQEmkT4ClP7h1qmqk3goCN+Ph88/VAcGaR7nLFqHZlayA92+pmNpZ4hT+7VfLtIaOkg1ahNXgos XXSuMY/7URHv8btf040ZbWkp3jD9aFwl61F+n+BIWxQ+OBNQye+csNYeM0HbZxtyA/mXN1ES3WD IFt31Y0uFL32Jj0XA4zRrk6c5lOjA+jikDO5pg6iE53uNlqcvsl6Zq1NEh1ny96QvvsW8zSWRuC yCnZRrfD0TBodvUpL9CGvn1rPSue+zGHs5bEZn/LdD4pVZQHxj X-Received: by 2002:a17:903:3c25:b0:2b2:5704:5715 with SMTP id d9443c01a7336-2b2d596af25mr270626605ad.15.1776357242968; Thu, 16 Apr 2026 09:34:02 -0700 (PDT) Received: from ubuntu.. ([49.205.37.103]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-2b47826e2f9sm59633285ad.42.2026.04.16.09.34.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 09:34:02 -0700 (PDT) From: Ajith P V To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, ajithpv.linux@gmail.com Subject: [PATCH] staging: most: video: replace BUG_ON() in comp_exit Date: Thu, 16 Apr 2026 16:33:34 +0000 Message-ID: <20260416163334.80699-1-ajithpv.linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace BUG_ON() with WARN_ON() and pr_err inside comp_exit(). BUG_ON() is risky and not recommended to use in kernel. It should replace with proper handlers such as WARN()-family (see Documentation/process/deprecated.rst). Signed-off-by: Ajith P V --- drivers/staging/most/video/video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/most/video/video.c b/drivers/staging/most/video/video.c index 04351f8ccccf..78cbf367c308 100644 --- a/drivers/staging/most/video/video.c +++ b/drivers/staging/most/video/video.c @@ -577,7 +577,8 @@ static void __exit comp_exit(void) most_deregister_configfs_subsys(&comp); most_deregister_component(&comp); - BUG_ON(!list_empty(&video_devices)); + if (WARN_ON(!list_empty(&video_devices))) + pr_err("video_devices list not empty during module exit\n"); } module_init(comp_init); -- 2.43.0