From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7ABA72DC792 for ; Thu, 16 Apr 2026 23:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776383297; cv=none; b=jPrfLA8LLq9t5capCThG/ixYc5SIPLsVszqF+exK6zrpBRciO0U2x9n6Mj4E1ZoAiEz7FIle43imH72zGchVzX2hcephzafb4AOF0V8cSmhqJtS+bkilDEDOVv76T6XiIZxysXTKEhjDfWAkKFZVE2H9nR8MI7QIIwqTUH2yB4o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776383297; c=relaxed/simple; bh=aMqWnAbuX1K5vk/MzshtiXoWSMcWcxO+y6Dl/UQ9OA4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uml7XiqrLPx1K8SQAcqkzkCisNB6Nz5q4mPRLcJvnYo6Cle4Jy44dD8x82tuSQuyHSM/LjuMcJA1zED9JjHijTaHzpuW5BNDVSEcCKIpSDuB4XEUILjm17G3k22+Q591TVzdNe/w6A7x/1nkwtmhPSWQeOj1XwEdsgqK/JFTE7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=onatbaker.dev; spf=pass smtp.mailfrom=onatbaker.dev; dkim=pass (2048-bit key) header.d=onatbaker.dev header.i=@onatbaker.dev header.b=Em/7G7V1; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=onatbaker.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=onatbaker.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=onatbaker.dev header.i=@onatbaker.dev header.b="Em/7G7V1" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-488afb0427eso1154625e9.1 for ; Thu, 16 Apr 2026 16:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onatbaker.dev; s=google; t=1776383295; x=1776988095; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cqr7D/SMiGCFOcynGjh+DQXRaU3Cg9DvCAA8s/ypA+o=; b=Em/7G7V1PxuIsLPxe2xf0gqibOacWhoSIFlhPp/nvCc1hPynCY5KSHjWiEkt6WZctr uayA5+L9XsgbKb6hm+VrMgGHIs+X5PgJrK68Qjgj9dtMgsqAqks6xiMLUMMsHgqTVrIr 1umNhdFb/TfGpGFOBCiBJbS/WyAxtuC94Sd53dAkbRPieN8H1xwRXXw1UDSJdxp+NHZj lEwakgfPYDy458uZVLOthv5qeD+2U/QO8OVB/uEahZb5dKa5BwGqmllb5JZAbwiVI4L0 Z/J8vYjWe7dmmiGw1vHSOmc6sl9YqlvvHyNbnA4ZJ7IRPLDGtgziFT6mBooylxJu+v46 qUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776383295; x=1776988095; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cqr7D/SMiGCFOcynGjh+DQXRaU3Cg9DvCAA8s/ypA+o=; b=HYLlDlCMS35Z/WQTxfH3we5bl1Vf2rPiLs/GCGaW7g+6lkeipxvqYQzbje73lp6J5+ +Rh6nkzI22+ZS3RQ0AiMhqSzdQGK9iZ4jVu2FjpOcOPZb/jkaVngvmvk9EElPdiGkjda gja0TSpubFqvnC5CtfkVeVZnM1zMfHKp8b2qYLh5SYpCNOdiMpXifASfWhJyhEvG4GTB mHyZ/LyBUnnGe/sB+Xm0qVxZBGrDDlfFPjAH8FWRu9t7SICGmToPI1MM/VQxhTwKPdD1 wXWQJxgaBf6j0AD+OJEOJIXszRMudeOH/xzzZ2CoqEsi4WNlV+db6xt9o8I/R2QMXau0 gMSw== X-Forwarded-Encrypted: i=1; AFNElJ/IVpBfL1ENVkauiHnC7Krkxb1+svpKTXEdwAtraLfKGZ8RukqqydVuVKtcioTOY7Q0eurhWUH78cTQzkw=@vger.kernel.org X-Gm-Message-State: AOJu0YwO+DigtdWcuDhTsnMv+nDhaBvBu4ropz51eM9IwUbvhmnUHduR LcT0Kz20jd2Agz3jSsDJaao3OkRzN3nn1HHQ1fS7t56hzI8HhoepfWowA+lNBRg+rlc8 X-Gm-Gg: AeBDieunXhudnjDhTrluD39a1rME44vXhmt01fsVQE9wKFf6SCPd1Cydi2dne54FY4D N5LJ8OD4jWIl2l7z5bfF/dMoDS8QLs5zAPhdPxSJ11660XLj3t/Ksw+jyPZEbj8Q7SrvvNZJUUo qnuj6awLsMYtngFFoILfdQ9DGMS010jnsV4WuTIwLuQS3fvFzaUui/5GyMKwOpU0/F0kn+0pDjx XZ8QSY0ZHZlwvLdPrdy609slFy40STemEbaQZKQ8a1jnabgKJJn/NdeN1KUVPSUkgX2tDI9l7/e 6btV52W4JKSF2IN3rNZyCtj9baBiZt/aUnDuRgDvRJBWMXjqKMNNlWWxd93I9QQqgPeB415CPu9 yZh1JqVnMaf/XE1dM75WvlUatnRQI4vRRyabfs/6/qNvgDH7/LlPatLKkNjR065DH4Ose/nUfuA kW7pMWsywfd9B93YqCbCgfVK37NDjLCurwofIdm1Km1wq6lcfe+2pZCFujfODXxLesBKIFr9K+K 5rC0Q== X-Received: by 2002:a05:600c:45d1:b0:488:c14b:201b with SMTP id 5b1f17b1804b1-488fb74fcd5mr7797565e9.10.1776383294314; Thu, 16 Apr 2026 16:48:14 -0700 (PDT) Received: from localhost.localdomain ([88.233.160.245]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb794d2esm6142705e9.6.2026.04.16.16.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Apr 2026 16:48:13 -0700 (PDT) From: Onat Baker To: ogabbay@kernel.org Cc: koby.elbaz@intel.com, konstantin.sinyuk@intel.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] accel/habanalabs: simplify function pointer checks in mmu.c Date: Fri, 17 Apr 2026 02:47:14 +0300 Message-ID: <20260416234714.8143-1-onat@onatbaker.dev> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Function pointers can be tested directly without an explicit comparison to NULL. Simplify the repeated checks in mmu.c by using direct pointer truth tests. No functional change intended. Signed-off-by: Onat Baker --- drivers/accel/habanalabs/common/mmu/mmu.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/accel/habanalabs/common/mmu/mmu.c b/drivers/accel/habanalabs/common/mmu/mmu.c index 6c7c4ff8a8a9..222cd6b77891 100644 --- a/drivers/accel/habanalabs/common/mmu/mmu.c +++ b/drivers/accel/habanalabs/common/mmu/mmu.c @@ -50,13 +50,13 @@ int hl_mmu_init(struct hl_device *hdev) mutex_init(&hdev->mmu_lock); - if (hdev->mmu_func[MMU_DR_PGT].init != NULL) { + if (hdev->mmu_func[MMU_DR_PGT].init) { rc = hdev->mmu_func[MMU_DR_PGT].init(hdev); if (rc) return rc; } - if (hdev->mmu_func[MMU_HR_PGT].init != NULL) { + if (hdev->mmu_func[MMU_HR_PGT].init) { rc = hdev->mmu_func[MMU_HR_PGT].init(hdev); if (rc) goto fini_dr_mmu; @@ -65,7 +65,7 @@ int hl_mmu_init(struct hl_device *hdev) return 0; fini_dr_mmu: - if (hdev->mmu_func[MMU_DR_PGT].fini != NULL) + if (hdev->mmu_func[MMU_DR_PGT].fini) hdev->mmu_func[MMU_DR_PGT].fini(hdev); return rc; @@ -86,10 +86,10 @@ void hl_mmu_fini(struct hl_device *hdev) if (hdev->mmu_disable) return; - if (hdev->mmu_func[MMU_DR_PGT].fini != NULL) + if (hdev->mmu_func[MMU_DR_PGT].fini) hdev->mmu_func[MMU_DR_PGT].fini(hdev); - if (hdev->mmu_func[MMU_HR_PGT].fini != NULL) + if (hdev->mmu_func[MMU_HR_PGT].fini) hdev->mmu_func[MMU_HR_PGT].fini(hdev); mutex_destroy(&hdev->mmu_lock); @@ -111,13 +111,13 @@ int hl_mmu_ctx_init(struct hl_ctx *ctx) if (hdev->mmu_disable) return 0; - if (hdev->mmu_func[MMU_DR_PGT].ctx_init != NULL) { + if (hdev->mmu_func[MMU_DR_PGT].ctx_init) { rc = hdev->mmu_func[MMU_DR_PGT].ctx_init(ctx); if (rc) return rc; } - if (hdev->mmu_func[MMU_HR_PGT].ctx_init != NULL) { + if (hdev->mmu_func[MMU_HR_PGT].ctx_init) { rc = hdev->mmu_func[MMU_HR_PGT].ctx_init(ctx); if (rc) goto fini_dr_ctx; @@ -126,7 +126,7 @@ int hl_mmu_ctx_init(struct hl_ctx *ctx) return 0; fini_dr_ctx: - if (hdev->mmu_func[MMU_DR_PGT].fini != NULL) + if (hdev->mmu_func[MMU_DR_PGT].fini) hdev->mmu_func[MMU_DR_PGT].fini(hdev); return rc; @@ -149,10 +149,10 @@ void hl_mmu_ctx_fini(struct hl_ctx *ctx) if (hdev->mmu_disable) return; - if (hdev->mmu_func[MMU_DR_PGT].ctx_fini != NULL) + if (hdev->mmu_func[MMU_DR_PGT].ctx_fini) hdev->mmu_func[MMU_DR_PGT].ctx_fini(ctx); - if (hdev->mmu_func[MMU_HR_PGT].ctx_fini != NULL) + if (hdev->mmu_func[MMU_HR_PGT].ctx_fini) hdev->mmu_func[MMU_HR_PGT].ctx_fini(ctx); } -- 2.47.3