From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E739933262F for ; Thu, 16 Apr 2026 23:51:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776383468; cv=none; b=pwyQPb2fh7g8PEySyd6T+HslwWbaVl1qxO+hA7u2kJQg7jIplEcf1LUaSVoM+GAKwQ1oTUgsUxVDhl3o1ZvBE+j7K9NnYZlmnc4Zi9wy9GG18OGdpoMqdS4JDimwaV3wZexCKEcepdKlNliK3ETE61AcTym7shdAmu7nw4OhDqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776383468; c=relaxed/simple; bh=wTOVfHug79g8+nbILjm69mxMVmRi87HcrvZ9H4ZTYco=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=q2g8nCdL1p84K4aG9fzDFD+SJPz/iPkcdmZWHNwUgIwlLWWjsfaRky7f/bHyGDfHt1NDXXINOvVWrOejm409RImG/05mnD6abJL1A6JmMjkIkipK0Ptvb2ucKkRA7dAEdOKpgO9ONAGO2h+r8LOYIB3ziVOPgP4/psvXaGvYuu4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xf7kwT/1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xf7kwT/1" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1471CC2BCAF; Thu, 16 Apr 2026 23:51:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1776383467; bh=wTOVfHug79g8+nbILjm69mxMVmRi87HcrvZ9H4ZTYco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Xf7kwT/1seW+bniYGSl6Ad5DBg847D3Pgrgy5fl5cCAAfMj9wVbAVrbt3x/EZFhbK +xKKk/sBtj2dqGoh+8Cq4PV82gJdypZnAn1AzBfXHcKhgR90hx8Wyaa6KxKq4GEDgu iCWCCItKbw2gjjF0mxJyME849CZKXO/ZZPHPRd5ncZ0PKUHOsALY0TMDjWKFW3rA+t v7aQQQqbNfYoEflJTjZfLNpGrt7t2/fxS1agXijs6ceFa2hw8/fKd5RV2VeXSxhpb0 rId5IaltXmYYgovviWZgZaVHWTVBMb9p+RiaT4iYp64RLoS1bHO1GOdbjI2eAf1XqI kG37RxGrpduyA== From: SeongJae Park To: Sunny Patel Cc: SeongJae Park , David Hildenbrand , Andrew Morton , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/migrate_device: Cleanup up PMD Checks and warnings Date: Thu, 16 Apr 2026 16:50:59 -0700 Message-ID: <20260416235059.58706-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260414141344.29949-1-nueralspacetech@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 14 Apr 2026 19:43:38 +0530 Sunny Patel wrote: > Remove the odd VM_WARN_ON_FOLIO(!folio, folio) usage and replace it > with a simpler VM_WARN_ON_ONCE(!folio) check. > > Drop the redundant VM_WARN_ON_ONCE(!pmd_none(*pmdp) && > !is_huge_zero_pmd(*pmdp)). > > Refactor the PMD checks to use pmd_present(), making the control flow > clearer and avoiding duplicate condition checks. > > Signed-off-by: Sunny Patel Acked-by: SeongJae Park [...] > @@ -865,12 +864,13 @@ static int migrate_vma_insert_huge_pmd_page(struct migrate_vma *migrate, > if (userfaultfd_missing(vma)) > goto unlock_abort; > > - if (!pmd_none(*pmdp)) { > + if (pmd_present(*pmdp)) { > if (!is_huge_zero_pmd(*pmdp)) > goto unlock_abort; > flush = true; > - } else if (!pmd_none(*pmdp)) > + } else if (!pmd_none(*pmdp)) { > goto unlock_abort; > + } I like this coding style [1] fix. [1] https://docs.kernel.org/process/coding-style.html#placing-braces-and-spaces Thanks, SJ [...]